From patchwork Fri Aug 15 12:40:08 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Griffin X-Patchwork-Id: 35455 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pa0-f69.google.com (mail-pa0-f69.google.com [209.85.220.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 86BDB20523 for ; Fri, 15 Aug 2014 12:40:32 +0000 (UTC) Received: by mail-pa0-f69.google.com with SMTP id kx10sf18138468pab.0 for ; Fri, 15 Aug 2014 05:40:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=gBF3DI8Kr7nlTUx035yYVvhrHHKpVhhinHm8Nhixiew=; b=H4cP7ODBB+dlZbzYseI0HDYxUWh9juLOW/VOTHX1AcU5nJcLmpmNRM2tMUUBsaAd1H JE9ZLLnDYPVwB0Yurs1ZLeG168ACkrA52Vo+RdP88Z4xiDcCrfocCnwFFZ8rO2A8WJvy +vFBkwclnY+/ConBaYiMwKmy6ZcZ2AeqkTNrCwyIPuMzaTwnSnZ/BuwiDQOk0SCwbb6n bqmlw6CMcszeIlBMDOyg/DCsk1pH12HdsGggmSeNKbiBqQvUeFpdrtRMFdgukATLssH1 na/IVJqtppooI77EyF4iGQlEAR+3ek4XuhCf9rne6TKr9KGJfmqBb6NWsxHzf+meqsro J4dg== X-Gm-Message-State: ALoCoQl1APN0dE3WnlUjRi8clRWDSjBRnhboDoI2xqr+7sinWIQaKRJ/u24VFrCubM5C6jqv1f+V X-Received: by 10.66.163.41 with SMTP id yf9mr9091337pab.36.1408106424677; Fri, 15 Aug 2014 05:40:24 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.35.197 with SMTP id n63ls1445701qgn.35.gmail; Fri, 15 Aug 2014 05:40:24 -0700 (PDT) X-Received: by 10.229.57.138 with SMTP id c10mr27343513qch.30.1408106424555; Fri, 15 Aug 2014 05:40:24 -0700 (PDT) Received: from mail-vc0-f171.google.com (mail-vc0-f171.google.com [209.85.220.171]) by mx.google.com with ESMTPS id m6si11652482qao.36.2014.08.15.05.40.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Aug 2014 05:40:24 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) client-ip=209.85.220.171; Received: by mail-vc0-f171.google.com with SMTP id hq11so2874205vcb.16 for ; Fri, 15 Aug 2014 05:40:24 -0700 (PDT) X-Received: by 10.52.144.232 with SMTP id sp8mr554368vdb.61.1408106424317; Fri, 15 Aug 2014 05:40:24 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp109557vcb; Fri, 15 Aug 2014 05:40:23 -0700 (PDT) X-Received: by 10.194.158.226 with SMTP id wx2mr18877639wjb.107.1408106423310; Fri, 15 Aug 2014 05:40:23 -0700 (PDT) Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by mx.google.com with ESMTPS id qh12si2478644wic.54.2014.08.15.05.40.22 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 15 Aug 2014 05:40:23 -0700 (PDT) Received-SPF: pass (google.com: domain of peter.griffin@linaro.org designates 209.85.212.181 as permitted sender) client-ip=209.85.212.181; Received: by mail-wi0-f181.google.com with SMTP id bs8so766206wib.8 for ; Fri, 15 Aug 2014 05:40:22 -0700 (PDT) X-Received: by 10.194.95.234 with SMTP id dn10mr20704126wjb.73.1408106422873; Fri, 15 Aug 2014 05:40:22 -0700 (PDT) Received: from localhost.localdomain (cpc14-aztw22-2-0-cust189.18-1.cable.virginm.net. [82.45.1.190]) by mx.google.com with ESMTPSA id fr2sm6486559wib.7.2014.08.15.05.40.21 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 15 Aug 2014 05:40:22 -0700 (PDT) From: Peter Griffin To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kishon@ti.com, kgene.kim@samsung.com, maxime.ripard@free-electrons.com, linux-samsung-soc@vger.kernel.org Cc: peter.griffin@linaro.org, patches@linaro.org, lee.jones@linaro.org Subject: [PATCH 1/9] phy: phy-omap-control: Remove unncessary site specific OOM messages Date: Fri, 15 Aug 2014 13:40:08 +0100 Message-Id: <1408106416-19044-2-git-send-email-peter.griffin@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> References: <1408106416-19044-1-git-send-email-peter.griffin@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: peter.griffin@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.171 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , The site specific OOM messages are unncessary, because they duplicate messages from the memory subsystem which include dump_stack(). Removing these superflous messages makes the kernel smaller. A discussion here http://patchwork.ozlabs.org/patch/324158/ found that all error paths from kzalloc will print a error message, and that any error path which maybe found which doesn't would be considered a bug in kzalloc. Signed-off-by: Peter Griffin --- drivers/phy/phy-omap-control.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/phy/phy-omap-control.c b/drivers/phy/phy-omap-control.c index 9487bf1..cb2f4d1 100644 --- a/drivers/phy/phy-omap-control.c +++ b/drivers/phy/phy-omap-control.c @@ -295,10 +295,8 @@ static int omap_control_phy_probe(struct platform_device *pdev) control_phy = devm_kzalloc(&pdev->dev, sizeof(*control_phy), GFP_KERNEL); - if (!control_phy) { - dev_err(&pdev->dev, "unable to alloc memory for control phy\n"); + if (!control_phy) return -ENOMEM; - } control_phy->dev = &pdev->dev; control_phy->type = *(enum omap_control_phy_type *)of_id->data;