From patchwork Wed Aug 20 20:41:52 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Soren Brinkmann X-Patchwork-Id: 35715 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-pd0-f199.google.com (mail-pd0-f199.google.com [209.85.192.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 8858020351 for ; Wed, 20 Aug 2014 20:44:23 +0000 (UTC) Received: by mail-pd0-f199.google.com with SMTP id v10sf63054681pde.6 for ; Wed, 20 Aug 2014 13:44:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:sender:precedence:list-id :x-original-sender:x-original-authentication-results:mailing-list :list-post:list-help:list-archive:list-unsubscribe; bh=806ni9LDLBOBzzi9mRBTC9s29ptXarqHOuB6wMzieUU=; b=GNYeCnQpplygNligX45n1PK+aV2AHaX/YtnPiEYC+0lG2lhl/ZOBjOgjfFpXvhHXPI mvSSWMNNYPWEClDQYF+biF8NTWZdP63Tt37IRZ4yVARZQt3mcXVq1XgOdShimCbNIxtk lYfEtpkLqgHp1dyDwRhaVLm7T+xncfLS8NxAQON+1WkE16eP3UuOJlBkX4QWpgq4wMkP HBM2eBMHLTSrl0yHSIjVvvExYsuD/0cJOxKcX/aVe4aDeMe540zvSNRayPPWb/+U9CNW ieTE5MvnEEO4hlb8ldS0vtbzUfx0UwEJHi5UmoaH2xv/IkuHmZAgRCRPtB7/SuHggv9N ymJA== X-Gm-Message-State: ALoCoQl/dioEqcaLDKXbY3eiesjrvXJbj5f2XzwssBEse6UIQqX3w69Fzui6WL330xEgu1FnvqWk X-Received: by 10.68.135.99 with SMTP id pr3mr1645041pbb.9.1408567456434; Wed, 20 Aug 2014 13:44:16 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.81.200 with SMTP id f66ls393384qgd.24.gmail; Wed, 20 Aug 2014 13:44:16 -0700 (PDT) X-Received: by 10.221.21.8 with SMTP id qq8mr3916217vcb.57.1408567456303; Wed, 20 Aug 2014 13:44:16 -0700 (PDT) Received: from mail-vc0-x22f.google.com (mail-vc0-x22f.google.com [2607:f8b0:400c:c03::22f]) by mx.google.com with ESMTPS id te2si11405732vcb.101.2014.08.20.13.44.16 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 20 Aug 2014 13:44:16 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::22f as permitted sender) client-ip=2607:f8b0:400c:c03::22f; Received: by mail-vc0-f175.google.com with SMTP id ik5so9828073vcb.34 for ; Wed, 20 Aug 2014 13:44:16 -0700 (PDT) X-Received: by 10.52.94.108 with SMTP id db12mr500007vdb.8.1408567456224; Wed, 20 Aug 2014 13:44:16 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.45.67 with SMTP id uj3csp82387vcb; Wed, 20 Aug 2014 13:44:15 -0700 (PDT) X-Received: by 10.66.158.130 with SMTP id wu2mr55705220pab.59.1408567455372; Wed, 20 Aug 2014 13:44:15 -0700 (PDT) Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id on4si33311132pbc.158.2014.08.20.13.44.14 for ; Wed, 20 Aug 2014 13:44:15 -0700 (PDT) Received-SPF: none (google.com: linux-kernel-owner@vger.kernel.org does not designate permitted sender hosts) client-ip=209.132.180.67; Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753278AbaHTUoD (ORCPT + 24 others); Wed, 20 Aug 2014 16:44:03 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:38605 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753084AbaHTUmt (ORCPT ); Wed, 20 Aug 2014 16:42:49 -0400 Received: by mail-pa0-f51.google.com with SMTP id ey11so12595106pad.24 for ; Wed, 20 Aug 2014 13:42:43 -0700 (PDT) X-Received: by 10.68.223.34 with SMTP id qr2mr55605734pbc.29.1408567363942; Wed, 20 Aug 2014 13:42:43 -0700 (PDT) Received: from localhost ([149.199.62.254]) by mx.google.com with ESMTPSA id ey10sm35431337pdb.50.2014.08.20.13.42.42 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 20 Aug 2014 13:42:43 -0700 (PDT) From: Soren Brinkmann To: Michal Simek , Russell King , "Rafael J. Wysocki" , Daniel Lezcano , Rob Herring , Mark Rutland Cc: =?UTF-8?q?S=C3=B6ren=20Brinkmann?= , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org, Pawel Moll , Ian Campbell , Kumar Gala Subject: [PATCH 6/9] ARM: zynq: cpuidle: Remove pointless code Date: Wed, 20 Aug 2014 13:41:52 -0700 Message-Id: <1408567315-28479-7-git-send-email-soren.brinkmann@xilinx.com> X-Mailer: git-send-email 2.0.1.1.gfbfc394 In-Reply-To: <1408567315-28479-1-git-send-email-soren.brinkmann@xilinx.com> References: <1408567315-28479-1-git-send-email-soren.brinkmann@xilinx.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: list List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Original-Sender: linux-kernel-owner@vger.kernel.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 2607:f8b0:400c:c03::22f as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org; dkim=neutral (body hash did not verify) header.i=@ Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , From: Daniel Lezcano The core is not powered down, it is pointless to call the cpu_pm notifiers and switch to the global timer. Signed-off-by: Daniel Lezcano Reviewed-and-tested-by: Soren Brinkmann --- drivers/cpuidle/cpuidle-zynq.c | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/cpuidle/cpuidle-zynq.c b/drivers/cpuidle/cpuidle-zynq.c index aded75928028..c61b8b2a7c77 100644 --- a/drivers/cpuidle/cpuidle-zynq.c +++ b/drivers/cpuidle/cpuidle-zynq.c @@ -26,7 +26,6 @@ */ #include -#include #include #include #include @@ -38,15 +37,9 @@ static int zynq_enter_idle(struct cpuidle_device *dev, struct cpuidle_driver *drv, int index) { - /* Devices must be stopped here */ - cpu_pm_enter(); - /* Add code for DDR self refresh start */ cpu_do_idle(); - /* Add code for DDR self refresh stop */ - cpu_pm_exit(); - return index; } @@ -59,8 +52,7 @@ static struct cpuidle_driver zynq_idle_driver = { .enter = zynq_enter_idle, .exit_latency = 10, .target_residency = 10000, - .flags = CPUIDLE_FLAG_TIME_VALID | - CPUIDLE_FLAG_TIMER_STOP, + .flags = CPUIDLE_FLAG_TIME_VALID, .name = "RAM_SR", .desc = "WFI and RAM Self Refresh", },