From patchwork Mon Aug 3 15:31:23 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Auger Eric X-Patchwork-Id: 51863 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-la0-f72.google.com (mail-la0-f72.google.com [209.85.215.72]) by patches.linaro.org (Postfix) with ESMTPS id 91B4C229FD for ; Mon, 3 Aug 2015 15:32:23 +0000 (UTC) Received: by labjb5 with SMTP id jb5sf11054957lab.1 for ; Mon, 03 Aug 2015 08:32:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:delivered-to:from:to:cc:subject :date:message-id:in-reply-to:references:x-original-sender :x-original-authentication-results:precedence:mailing-list:list-id :list-post:list-help:list-archive:list-unsubscribe; bh=Bn9ZY3W738Y4BQ9Qm0gg5t47xBCw/E8fhRFafD60EOs=; b=Cso4uc1jQQ5ja/L77F6Pe5jQrZUghMVuZK/dLEj8qPncbqJvnU2qtgmsX9W/Vh9qEy 9KEfV/oVnlmAFt3cN05Iv3sIA88NnOt7+SNT1zElo419CwLQahJ9Jyfzm/RgxoKizQj7 SKCd5bnizSlHOO4Pr3tZLhUkOkwNKn8nh43TYZXUQ8MY/v7PD40gc7SNKFeoE0YIvuwd fRAsy7JJ4ktMBVETbXO01grwO6f6u57zOxA0W8GqVOyiyBkKWeB4icS3233JnOZB2Tff q2MW2R4O6iGLUU7lk0Xqj5P9jT7DbGe0rhpLDw9tkQRrBse2pk60lChblywR9ARBttOc /UVw== X-Gm-Message-State: ALoCoQk9+ibxByHvQT8z7nEyhUNQvFDvuIzXgUUl4tvqjXg23OqgiiZsgG/jceCYAvtmLpmw5LX1 X-Received: by 10.180.11.226 with SMTP id t2mr5944042wib.0.1438615942582; Mon, 03 Aug 2015 08:32:22 -0700 (PDT) MIME-Version: 1.0 X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.37.163 with SMTP id z3ls292024laj.32.gmail; Mon, 03 Aug 2015 08:32:22 -0700 (PDT) X-Received: by 10.152.29.200 with SMTP id m8mr15320156lah.83.1438615942429; Mon, 03 Aug 2015 08:32:22 -0700 (PDT) Received: from mail-lb0-f173.google.com (mail-lb0-f173.google.com. [209.85.217.173]) by mx.google.com with ESMTPS id s10si12284511laj.84.2015.08.03.08.32.22 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 08:32:22 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.173 as permitted sender) client-ip=209.85.217.173; Received: by lbbpo9 with SMTP id po9so6073096lbb.2 for ; Mon, 03 Aug 2015 08:32:22 -0700 (PDT) X-Received: by 10.152.36.161 with SMTP id r1mr17296089laj.88.1438615941901; Mon, 03 Aug 2015 08:32:21 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patches@linaro.org Received: by 10.112.7.198 with SMTP id l6csp1933100lba; Mon, 3 Aug 2015 08:32:21 -0700 (PDT) X-Received: by 10.180.94.7 with SMTP id cy7mr32582857wib.79.1438615940943; Mon, 03 Aug 2015 08:32:20 -0700 (PDT) Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com. [209.85.212.178]) by mx.google.com with ESMTPS id fs10si10508594wjb.209.2015.08.03.08.32.20 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 08:32:20 -0700 (PDT) Received-SPF: pass (google.com: domain of eric.auger@linaro.org designates 209.85.212.178 as permitted sender) client-ip=209.85.212.178; Received: by wibud3 with SMTP id ud3so119210467wib.0 for ; Mon, 03 Aug 2015 08:32:20 -0700 (PDT) X-Received: by 10.194.87.102 with SMTP id w6mr33611414wjz.111.1438615940431; Mon, 03 Aug 2015 08:32:20 -0700 (PDT) Received: from gnx2579.home (LCaen-156-56-7-90.w80-11.abo.wanadoo.fr. [80.11.198.90]) by smtp.gmail.com with ESMTPSA id ny7sm14134420wic.11.2015.08.03.08.32.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 08:32:19 -0700 (PDT) From: Eric Auger To: eric.auger@st.com, eric.auger@linaro.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, christoffer.dall@linaro.org, marc.zyngier@arm.com Cc: linux-kernel@vger.kernel.org, patches@linaro.org, pbonzini@redhat.com, andre.przywara@arm.com, p.fedin@samsung.com Subject: [PATCH v3 1/7] KVM: api: pass the devid in the msi routing entry Date: Mon, 3 Aug 2015 17:31:23 +0200 Message-Id: <1438615889-10892-2-git-send-email-eric.auger@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1438615889-10892-1-git-send-email-eric.auger@linaro.org> References: <1438615889-10892-1-git-send-email-eric.auger@linaro.org> X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: eric.auger@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Precedence: list Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org List-ID: X-Google-Group-Id: 836684582541 List-Post: , List-Help: , List-Archive: List-Unsubscribe: , On ARM, the MSI msg (address and data) comes along with out-of-band device ID information. The device ID encodes the device that writes the MSI msg. Let's convey the device id in kvm_irq_routing_msi and use KVM_MSI_VALID_DEVID flag value in kvm_irq_routing_entry to indicate the msi devid is populated. Signed-off-by: Eric Auger --- v2 -> v3: - replace usage of KVM_IRQ_ROUTING_EXTENDED_MSI type by usage of KVM_MSI_VALID_DEVID flag - add note about KVM_CAP_MSI_DEVID capability v1 -> v2: - devid id passed in kvm_irq_routing_msi instead of in kvm_irq_routing_entry RFC -> PATCH - remove kvm_irq_routing_extended_msi and use union instead --- Documentation/virtual/kvm/api.txt | 18 ++++++++++++++++-- include/uapi/linux/kvm.h | 5 ++++- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/Documentation/virtual/kvm/api.txt b/Documentation/virtual/kvm/api.txt index 1b53155..d4b29df 100644 --- a/Documentation/virtual/kvm/api.txt +++ b/Documentation/virtual/kvm/api.txt @@ -1454,7 +1454,10 @@ struct kvm_irq_routing_entry { #define KVM_IRQ_ROUTING_MSI 2 #define KVM_IRQ_ROUTING_S390_ADAPTER 3 -No flags are specified so far, the corresponding field must be set to zero. +flags: +- KVM_MSI_VALID_DEVID: used along with KVM_IRQ_ROUTING_MSI + routing entry type, it tells the msi devid contains a valid value. +- zero otherwise struct kvm_irq_routing_irqchip { __u32 irqchip; @@ -1465,9 +1468,20 @@ struct kvm_irq_routing_msi { __u32 address_lo; __u32 address_hi; __u32 data; - __u32 pad; + union { + __u32 pad; + __u32 devid; + }; }; +devid: If KVM_MSI_VALID_DEVID is set, contains a unique device identifier + for the device that wrote the MSI message. + For PCI, this is usually a BFD identifier in the lower 16 bits. + +The per-VM KVM_CAP_MSI_DEVID capability advertises the need to provide +the device ID. If this capability is not set, userland cannot rely on +the kernel to allow the KVM_MSI_VALID_DEVID flag being set. + struct kvm_irq_routing_s390_adapter { __u64 ind_addr; __u64 summary_addr; diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h index 1c48def..3c865b9 100644 --- a/include/uapi/linux/kvm.h +++ b/include/uapi/linux/kvm.h @@ -830,7 +830,10 @@ struct kvm_irq_routing_msi { __u32 address_lo; __u32 address_hi; __u32 data; - __u32 pad; + union { + __u32 pad; + __u32 devid; + }; }; struct kvm_irq_routing_s390_adapter {