From patchwork Mon Dec 7 11:50:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 57783 Delivered-To: patch@linaro.org Received: by 10.202.179.86 with SMTP id c83csp945491oif; Mon, 7 Dec 2015 03:54:58 -0800 (PST) X-Received: by 10.66.193.36 with SMTP id hl4mr42536737pac.153.1449489298038; Mon, 07 Dec 2015 03:54:58 -0800 (PST) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id t10si42213175pfi.128.2015.12.07.03.54.57 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Dec 2015 03:54:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org; dkim=neutral (body hash did not verify) header.i=@linaro-org.20150623.gappssmtp.com Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a5uM6-0003dZ-NV; Mon, 07 Dec 2015 11:53:22 +0000 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a5uJu-00023V-UI for linux-arm-kernel@lists.infradead.org; Mon, 07 Dec 2015 11:51:10 +0000 Received: by wmec201 with SMTP id c201so147238347wme.1 for ; Mon, 07 Dec 2015 03:50:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro-org.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:in-reply-to:references; bh=1i7r3dT15s4R2j1MTiwqP0cwbeGm1D2rNFbSNt0pWh8=; b=QRcGqDa7pU9Xv5D2CcjCi7AF25jS8+HAh5c8QV7i1qpWJSoGEpYAwGr0HPHGFCRrNn ujcCXAdbmf5hukncEkOzbQZk1EtDPA4K+PvSHzjYjTYyNCEYyDVyf0OrmqI145yrbBxR Jx/NPMouIqgMijm6morhp1FmQbUoYXSlB/eJ79SqTBbfsdnrT1BzspCMqg8HG7reWP03 /C/QR5YpW8tgc85CQ1P3ar7HyJzsWuGlIUq9vDSHytwB+PtXTKigBd5fdA7lrogG6vcl fOVI9a/xFGux72Lddy7Qj19umHdcjt77atDkT7AZyWigo96bS5R9Ry8lbmwkSJ/c2d8G 0Xhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references; bh=1i7r3dT15s4R2j1MTiwqP0cwbeGm1D2rNFbSNt0pWh8=; b=W04wCAFDEEoj7bkSz9LEgbISEb323dBnyUIFaZzfCuHIXIGmiSLpd5BQiP7vFt6hl4 EsCot9G90YEqQR2jurUNHeOrurIVdAPHfotJlMzPHAWtyqOGyp3jPCEHZT4uBPBUcgNU MtGBnr7iojVfoDO0CRCet/b+1uks6hE6ml0t5ABq1jcRR2gL/69Ikr30hWneE00yjgx2 6huJp5Et5ZMxtWoXohw+IvrQhqwViHCpivzhw6BfyM3bVKfUhCwFKlBSdMZc2BxpykrN LBUcGaoKUm1HmV/bXu0CEKNKlsc6SFuZmGuoti2vcb9B5RxsFrxWrjxUOUVqw3HVbls0 IsIg== X-Gm-Message-State: ALoCoQkF+as8FJlNWHc4VNWLUe1kCAWJKldur7EzpwZfHpdpIL43UTQOQ0woyR5f5ffiNBEI43VK X-Received: by 10.194.222.135 with SMTP id qm7mr32679920wjc.106.1449489045633; Mon, 07 Dec 2015 03:50:45 -0800 (PST) Received: from localhost.localdomain (host81-129-174-134.range81-129.btcentralplus.com. [81.129.174.134]) by smtp.gmail.com with ESMTPSA id z1sm24806533wje.35.2015.12.07.03.50.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 07 Dec 2015 03:50:45 -0800 (PST) From: Lee Jones To: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH 05/19] mfd: ab8500-debugfs: Clean-up non-conforming commenting and print formatting Date: Mon, 7 Dec 2015 11:50:18 +0000 Message-Id: <1449489032-14374-6-git-send-email-lee.jones@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1449489032-14374-1-git-send-email-lee.jones@linaro.org> References: <1449489032-14374-1-git-send-email-lee.jones@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151207_035107_299889_0287DECE X-CRM114-Status: GOOD ( 13.00 ) X-Spam-Score: -2.6 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:22b listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org WARNING: Block comments use a trailing */ on a separate line + * not be accessed from here */ WARNING: Block comments use a trailing */ on a separate line + * not be accessed from here */ WARNING: Block comments use a trailing */ on a separate line + * the output is wanted in any case */ WARNING: Consecutive strings are generally better as a single string + " addr=0x%08X, mask=0x%X, shift=%d" "value=0x%X\n", total: 0 errors, 4 warnings, 3331 lines checked Cc: Linus Walleij Signed-off-by: Lee Jones --- drivers/mfd/ab8500-debugfs.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) -- 1.9.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c index 0236cd7..69d9fff 100644 --- a/drivers/mfd/ab8500-debugfs.c +++ b/drivers/mfd/ab8500-debugfs.c @@ -242,8 +242,10 @@ static struct ab8500_prcmu_ranges ab8500_debug_ranges[AB8500_NUM_BANKS] = { .first = 0x40, .last = 0x44, }, - /* 0x80-0x8B is SIM registers and should - * not be accessed from here */ + /* + * 0x80-0x8B are SIM registers and should + * not be accessed from here + */ }, }, [AB8500_USB] = { @@ -587,8 +589,10 @@ static struct ab8500_prcmu_ranges ab8505_debug_ranges[AB8500_NUM_BANKS] = { .first = 0x40, .last = 0x48, }, - /* 0x80-0x8B is SIM registers and should - * not be accessed from here */ + /* + * 0x80-0x8B are SIM registers and should + * not be accessed from here + */ }, }, [AB8500_USB] = { @@ -1306,8 +1310,10 @@ static int ab8500_registers_print(struct device *dev, u32 bank, if (s) { seq_printf(s, " [0x%02X/0x%02X]: 0x%02X\n", bank, reg, value); - /* Error is not returned here since - * the output is wanted in any case */ + /* + * Error is not returned here since + * the output is wanted in any case + */ if (seq_has_overflowed(s)) return 0; } else { @@ -2740,10 +2746,9 @@ static ssize_t hwreg_common_write(char *b, struct hwreg_cfg *cfg, *cfg = loc; #ifdef ABB_HWREG_DEBUG - pr_warn("HWREG request: %s, %s,\n" - " addr=0x%08X, mask=0x%X, shift=%d" "value=0x%X\n", - (write) ? "write" : "read", - REG_FMT_DEC(cfg) ? "decimal" : "hexa", + pr_warn("HWREG request: %s, %s,\n", (write) ? "write" : "read", + REG_FMT_DEC(cfg) ? "decimal" : "hexa"); + pr_warn(" addr=0x%08X, mask=0x%X, shift=%d" "value=0x%X\n", cfg->addr, cfg->mask, cfg->shift, val); #endif