From patchwork Tue Apr 19 17:24:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Auger Eric X-Patchwork-Id: 66137 Delivered-To: patches@linaro.org Received: by 10.140.93.198 with SMTP id d64csp1983754qge; Tue, 19 Apr 2016 10:25:17 -0700 (PDT) X-Received: by 10.28.175.76 with SMTP id y73mr4699096wme.16.1461086708654; Tue, 19 Apr 2016 10:25:08 -0700 (PDT) Return-Path: Received: from mail-wm0-x233.google.com (mail-wm0-x233.google.com. [2a00:1450:400c:c09::233]) by mx.google.com with ESMTPS id j9si5272886wma.95.2016.04.19.10.25.08 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 19 Apr 2016 10:25:08 -0700 (PDT) Received-SPF: pass (google.com: domain of eric.auger@linaro.org designates 2a00:1450:400c:c09::233 as permitted sender) client-ip=2a00:1450:400c:c09::233; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org; spf=pass (google.com: domain of eric.auger@linaro.org designates 2a00:1450:400c:c09::233 as permitted sender) smtp.mailfrom=eric.auger@linaro.org; dmarc=pass (p=NONE dis=NONE) header.from=linaro.org Received: by mail-wm0-x233.google.com with SMTP id n3so41796191wmn.0 for ; Tue, 19 Apr 2016 10:25:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=BD5kMnLbXFzOVhTs+7nai2bsM8zOyk7Yz/d4GLgWSmE=; b=NSj3h73h8hEXgFBm+PTBqK7u9mlWXR9ZRsupOAjbhfaPXI4M/9TQl+FzxMnzcFeq1i 0BupdHthyC/3iXSjyX8k00zjUMSKuOt3TBGwfpPstxBhJr/tUVUsO08HGLdUsEBSBB09 xALfD2GnNjef+2bNDK4T8Kwz33CsJozIBgWY8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=BD5kMnLbXFzOVhTs+7nai2bsM8zOyk7Yz/d4GLgWSmE=; b=X0WoMUsubc4XTnROFG5kGar7gCsxzKwwm7PpsoGHIsj2zv1fEoOmlyZrdJTCR3EXGh FblyBb4HtyfjA0tRnVRsPjtEFzsUfOP8mjnKgnpI+VIiooJow/pGdfun0S9kfzj9V79/ 1o0o7Xn680WjeyeIjF1zaC0QMzqtYduKM0vSeqtRMNsusYSG3zLEmgAH3hk9pO3eoKmW z1jBzsd3qsjxnysbmq4bfpBNfejkJZRxtShiPvv+ltToeZaGh+D5FxS/1bExziu6UneY V5rZNuPAzd/falWGLau2auCER/AmaVKVbDWktUG1tDn0QOSea+8nCbJ71fpbzB8w2ni/ /kNg== X-Gm-Message-State: AOPr4FVRvfQR4z4NeNMXuN4Girnsi0Ei4Jt7RzkJ1nS812Qolg8t2hmO4pn/ZoJGCWtJrGzPh2I= X-Received: by 10.28.157.142 with SMTP id g136mr4807408wme.29.1461086708347; Tue, 19 Apr 2016 10:25:08 -0700 (PDT) Return-Path: Received: from new-host-34.home (LMontsouris-657-1-37-90.w80-11.abo.wanadoo.fr. [80.11.198.90]) by smtp.gmail.com with ESMTPSA id w202sm5330220wmw.18.2016.04.19.10.25.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Apr 2016 10:25:07 -0700 (PDT) From: Eric Auger To: eric.auger@st.com, eric.auger@linaro.org, robin.murphy@arm.com, alex.williamson@redhat.com, will.deacon@arm.com, joro@8bytes.org, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, christoffer.dall@linaro.org, linux-arm-kernel@lists.infradead.org Cc: patches@linaro.org, linux-kernel@vger.kernel.org, Bharat.Bhushan@freescale.com, pranav.sawargaonkar@gmail.com, p.fedin@samsung.com, iommu@lists.linux-foundation.org, Jean-Philippe.Brucker@arm.com, julien.grall@arm.com Subject: [PATCH v7 7/7] vfio/type1: return MSI mapping requirements with VFIO_IOMMU_GET_INFO Date: Tue, 19 Apr 2016 17:24:47 +0000 Message-Id: <1461086687-2658-8-git-send-email-eric.auger@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1461086687-2658-1-git-send-email-eric.auger@linaro.org> References: <1461086687-2658-1-git-send-email-eric.auger@linaro.org> This patch allows the user-space to know whether MSI addresses need to be mapped in the IOMMU. The user-space uses VFIO_IOMMU_GET_INFO ioctl and IOMMU_INFO_REQUIRE_MSI_MAP gets set if they need to. The computation of the number of IOVA pages to be provided by the user space will be implemented in a separate patch using capability chains. Signed-off-by: Eric Auger --- v6 -> v7: - remove the computation of the number of IOVA pages to be provisionned. This number depends on the domain/group/device topology which can dynamically change. Let's rely instead rely on an arbitrary max depending on the system v4 -> v5: - move msi_info and ret declaration within the conditional code v3 -> v4: - replace former vfio_domains_require_msi_mapping by more complex computation of MSI mapping requirements, especially the number of pages to be provided by the user-space. - reword patch title RFC v1 -> v1: - derived from [RFC PATCH 3/6] vfio: Extend iommu-info to return MSIs automap state - renamed allow_msi_reconfig into require_msi_mapping - fixed VFIO_IOMMU_GET_INFO --- drivers/vfio/vfio_iommu_type1.c | 24 ++++++++++++++++++++++++ include/uapi/linux/vfio.h | 5 ++++- 2 files changed, 28 insertions(+), 1 deletion(-) -- 1.9.1 diff --git a/drivers/vfio/vfio_iommu_type1.c b/drivers/vfio/vfio_iommu_type1.c index 51b1f15..a63ce6f 100644 --- a/drivers/vfio/vfio_iommu_type1.c +++ b/drivers/vfio/vfio_iommu_type1.c @@ -310,6 +310,27 @@ static int vaddr_get_pfn(unsigned long vaddr, int prot, unsigned long *pfn) } /* + * vfio_domains_require_msi_mapping: return whether MSI doorbells must be + * iommu mapped + * + * returns true if msi mapping is requested + */ +static bool vfio_domains_require_msi_mapping(struct vfio_iommu *iommu) +{ + struct vfio_domain *d; + bool flag; + + mutex_lock(&iommu->lock); + /* All domains have same require_msi_map property, pick first */ + d = list_first_entry(&iommu->domain_list, struct vfio_domain, next); + flag = (!(iommu_domain_get_attr(d->domain, + DOMAIN_ATTR_MSI_MAPPING, NULL))); + + mutex_unlock(&iommu->lock); + + return flag; +} +/* * Attempt to pin pages. We really don't want to track all the pfns and * the iommu can only map chunks of consecutive pfns anyway, so get the * first page and all consecutive pages with the same locking. @@ -1231,6 +1252,9 @@ static long vfio_iommu_type1_ioctl(void *iommu_data, info.flags = VFIO_IOMMU_INFO_PGSIZES; + if (vfio_domains_require_msi_mapping(iommu)) + info.flags |= VFIO_IOMMU_INFO_REQUIRE_MSI_MAP; + info.iova_pgsizes = vfio_pgsize_bitmap(iommu); return copy_to_user((void __user *)arg, &info, minsz) ? diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h index 0637f35..4d9c97d 100644 --- a/include/uapi/linux/vfio.h +++ b/include/uapi/linux/vfio.h @@ -488,6 +488,7 @@ struct vfio_iommu_type1_info { __u32 argsz; __u32 flags; #define VFIO_IOMMU_INFO_PGSIZES (1 << 0) /* supported page sizes info */ +#define VFIO_IOMMU_INFO_REQUIRE_MSI_MAP (1 << 1)/* MSI must be mapped */ __u64 iova_pgsizes; /* Bitmap of supported page sizes */ }; @@ -501,7 +502,9 @@ struct vfio_iommu_type1_info { * * In case RESERVED_MSI_IOVA flag is set, the API only aims at registering an * IOVA region that will be used on some platforms to map the host MSI frames. - * In that specific case, vaddr is ignored. + * In that specific case, vaddr is ignored. The requirement for provisioning + * such reserved IOVA range can be checked by calling VFIO_IOMMU_GET_INFO and + * testing the VFIO_IOMMU_INFO_REQUIRE_MSI_MAP flag. */ struct vfio_iommu_type1_dma_map { __u32 argsz;