From patchwork Tue Aug 16 15:51:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ard Biesheuvel X-Patchwork-Id: 74029 Delivered-To: patch@linaro.org Received: by 10.140.29.52 with SMTP id a49csp2074941qga; Tue, 16 Aug 2016 08:53:49 -0700 (PDT) X-Received: by 10.66.172.237 with SMTP id bf13mr11178171pac.42.1471362829347; Tue, 16 Aug 2016 08:53:49 -0700 (PDT) Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org. [2001:1868:205::9]) by mx.google.com with ESMTPS id j29si32647815pfk.53.2016.08.16.08.53.49 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 16 Aug 2016 08:53:49 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) client-ip=2001:1868:205::9; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org; spf=pass (google.com: best guess record for domain of linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org designates 2001:1868:205::9 as permitted sender) smtp.mailfrom=linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org; dmarc=fail (p=NONE dis=NONE) header.from=linaro.org Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1bZgfa-0005O5-A9; Tue, 16 Aug 2016 15:52:50 +0000 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1bZgf5-0005Cb-1d for linux-arm-kernel@lists.infradead.org; Tue, 16 Aug 2016 15:52:21 +0000 Received: by mail-wm0-x234.google.com with SMTP id i5so177072027wmg.0 for ; Tue, 16 Aug 2016 08:51:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hhnRqfW7HwLf7ZeOjlMt8acYwcWZKdnJGhQWAHXG1VU=; b=QOuTJ/P4iMpuW3tiUaXbH1dD8p4iFXXqlvQUWayzJUMWcOFrAMsY1zO7Fg6vffm9az lBMfRhyeFF6Ll/iwbBoAxPRXb1yRzVevTd4ZrfIMoxWUSzJ3CcYSUz1ylL/EuS6W7Rs4 /LyXjvRdso4dtiCPcwlrwD/crQyOO8RbWPWGg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hhnRqfW7HwLf7ZeOjlMt8acYwcWZKdnJGhQWAHXG1VU=; b=b9PGCWgC9NFGM0Z3Dp80N3UYCI5O7UU98Jio21xuVArmK+sdf/DTisXJWIOQEAsm7a 8p615sysLk53+IZSvl9CsOdYJ1V1wmP4WceEMHZYEVPGiQuAM8Iq3yZzI8KZYtZ9L9a/ hXnbdQe20F0ufbwclq2jNeU6HEXbH/ZLDsUPkFz9tf9xAhLK9nfCPufqAhXZWG099iGa m4cPEiddPHl/Ltujwd6j9WsPsj0wNy0GAU0lVR6gNHNmeHoAqdYnbdDqJgWFqIuqMyww Ycy5DYzfJgrsqUwQlEyk36WpsmvlWXpAJP3WpPkVrrz8hw8po99t3R2NhQRJASZr0vYr UT1w== X-Gm-Message-State: AEkoout2ZrRrHR6acmOJaMO7OfX+aOwxN6RmbVOdEQJATIteedR3weZL3xCRUlbo/8k2kOrn X-Received: by 10.28.223.139 with SMTP id w133mr23009725wmg.90.1471362717284; Tue, 16 Aug 2016 08:51:57 -0700 (PDT) Received: from localhost.localdomain (46.red-81-37-107.dynamicip.rima-tde.net. [81.37.107.46]) by smtp.gmail.com with ESMTPSA id p23sm22377448wme.8.2016.08.16.08.51.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 16 Aug 2016 08:51:56 -0700 (PDT) From: Ard Biesheuvel To: linux-arm-kernel@lists.infradead.org, linux@arm.linux.org.uk, dave.martin@arm.com Subject: [PATCH 2/2] ARM: kernel: allocate PLT entries only for external symbols Date: Tue, 16 Aug 2016 17:51:46 +0200 Message-Id: <1471362706-29859-3-git-send-email-ard.biesheuvel@linaro.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1471362706-29859-1-git-send-email-ard.biesheuvel@linaro.org> References: <1471362706-29859-1-git-send-email-ard.biesheuvel@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160816_085219_367272_EF0E5115 X-CRM114-Status: GOOD ( 22.59 ) X-Spam-Score: -2.7 (--) X-Spam-Report: SpamAssassin version 3.4.0 on bombadil.infradead.org summary: Content analysis details: (-2.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [2a00:1450:400c:c09:0:0:0:234 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: namhyung.kim@lge.com, youngho.shin@lge.com, arnd@arndb.de, Ard Biesheuvel , neidhard.kim@lge.com, chanho.min@lge.com MIME-Version: 1.0 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patch=linaro.org@lists.infradead.org When CONFIG_ARM_MODULE_PLTS is enabled, jump and call instructions in modules no longer need to be within 16 MB (8 MB for Thumb2) of their targets. If they are further away, a PLT entry will be generated on the fly for each of them, which extends the range to the entire 32-bit address space. However, since these PLT entries will become the branch targets of the original jump and call instructions, the PLT itself needs to be in range, or we end up in the same situation we started in. Since the PLT is in a separate section, this essentially means that all jumps and calls inside the same module must be resolvable without PLT entries. The PLT allocation code executes before the module itself is loaded in its final location, and so it has to use a worst-case estimate for which jumps and calls will require an entry in the PLT at relocation time. As an optimization, this code deduplicates entries pointing to the same symbol, using a O(n^2) algorithm. However, it does not take the above into account, i.e., that PLT entries will only be needed for jump and call relocations against symbols that are not defined in the module. So disregard relocations against symbols that are defined in the module itself. As an additional minor optimization, ignore input sections that lack the SHF_EXECINSTR flag. Since jump and call relocations operate on executable instructions only, there is no need to look in sections that do not contain executable code. Signed-off-by: Ard Biesheuvel --- arch/arm/kernel/module-plts.c | 32 +++++++++++++++++--- 1 file changed, 28 insertions(+), 4 deletions(-) -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel diff --git a/arch/arm/kernel/module-plts.c b/arch/arm/kernel/module-plts.c index 6832d1d6444e..59d2fcaff7d2 100644 --- a/arch/arm/kernel/module-plts.c +++ b/arch/arm/kernel/module-plts.c @@ -88,7 +88,8 @@ static int duplicate_rel(Elf32_Addr base, const Elf32_Rel *rel, int num, } /* Count how many PLT entries we may need */ -static unsigned int count_plts(Elf32_Addr base, const Elf32_Rel *rel, int num) +static unsigned int count_plts(const Elf32_Sym *syms, Elf32_Addr base, + const Elf32_Rel *rel, int num) { unsigned int ret = 0; int i; @@ -97,7 +98,17 @@ static unsigned int count_plts(Elf32_Addr base, const Elf32_Rel *rel, int num) * Sure, this is order(n^2), but it's usually short, and not * time critical */ - for (i = 0; i < num; i++) + for (i = 0; i < num; i++) { + /* + * We only have to consider branch targets that resolve + * to undefined symbols. This is not simply a heuristic, + * it is a fundamental limitation, since the PLT itself + * is part of the module, and needs to be within range + * as well, so modules can never grow beyond that limit. + */ + if (syms[ELF32_R_SYM(rel[i].r_info)].st_shndx != SHN_UNDEF) + continue; + switch (ELF32_R_TYPE(rel[i].r_info)) { case R_ARM_CALL: case R_ARM_PC24: @@ -114,6 +125,7 @@ static unsigned int count_plts(Elf32_Addr base, const Elf32_Rel *rel, int num) ret++; #endif } + } return ret; } @@ -122,19 +134,27 @@ int module_frob_arch_sections(Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, { unsigned long plts = 0; Elf32_Shdr *s, *sechdrs_end = sechdrs + ehdr->e_shnum; + Elf32_Sym *syms = NULL; /* * To store the PLTs, we expand the .text section for core module code * and for initialization code. */ - for (s = sechdrs; s < sechdrs_end; ++s) + for (s = sechdrs; s < sechdrs_end; ++s) { if (strcmp(".plt", secstrings + s->sh_name) == 0) mod->arch.plt = s; + else if (s->sh_type == SHT_SYMTAB) + syms = (Elf32_Sym *)s->sh_addr; + } if (!mod->arch.plt) { pr_err("%s: module PLT section missing\n", mod->name); return -ENOEXEC; } + if (!syms) { + pr_err("%s: module symtab section missing\n", mod->name); + return -ENOEXEC; + } for (s = sechdrs + 1; s < sechdrs_end; ++s) { const Elf32_Rel *rels = (void *)ehdr + s->sh_offset; @@ -144,7 +164,11 @@ int module_frob_arch_sections(Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, if (s->sh_type != SHT_REL) continue; - plts += count_plts(dstsec->sh_addr, rels, numrels); + /* ignore relocations that operate on non-exec sections */ + if (!(dstsec->sh_flags & SHF_EXECINSTR)) + continue; + + plts += count_plts(syms, dstsec->sh_addr, rels, numrels); } mod->arch.plt->sh_type = SHT_NOBITS;