mbox series

[v2,0/6] rpmsg: glink stability fixes

Message ID 20191004222702.8632-1-bjorn.andersson@linaro.org
Headers show
Series rpmsg: glink stability fixes | expand

Message

Bjorn Andersson Oct. 4, 2019, 10:26 p.m. UTC 
Fixes for issues found in GLINK during reboot testing of a remoteproc.

Arun Kumar Neelakantam (2):
  rpmsg: glink: Fix reuse intents memory leak issue
  rpmsg: glink: Fix use after free in open_ack TIMEOUT case

Bjorn Andersson (2):
  rpmsg: glink: Don't send pending rx_done during remove
  rpmsg: glink: Free pending deferred work on remove

Chris Lew (2):
  rpmsg: glink: Put an extra reference during cleanup
  rpmsg: glink: Fix rpmsg_register_device err handling

 drivers/rpmsg/qcom_glink_native.c | 52 +++++++++++++++++++++++++------
 1 file changed, 42 insertions(+), 10 deletions(-)

-- 
2.18.0

Comments

Chris Lew Oct. 9, 2019, 1:08 a.m. UTC | #1 
On 10/4/2019 3:27 PM, Bjorn Andersson wrote:
> Attempting to transmit rx_done messages after the GLINK instance is

> being torn down will cause use after free and memory leaks. So cancel

> the intent_work and free up the pending intents.

> 

> With this there are no concurrent accessors of the channel left during

> qcom_glink_native_remove() and there is therefor no need to hold the

> spinlock during this operation - which would prohibit the use of

> cancel_work_sync() in the release function. So remove this.

> 

> Fixes: 1d2ea36eead9 ("rpmsg: glink: Add rx done command")

> Cc: stable@vger.kernel.org

> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>

> Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---


Acked-By: Chris Lew <clew@codeaurora.org>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project