| Message ID | 20201222222637.3204929-1-robert.marko@sartura.hr |
|---|---|
| Headers | show |
| Series | Add support for Qualcomm QCA807x PHYs | expand |
> + gpio-controller: true > + "#gpio-cells": > + const: 2 > + > + qcom,single-led-1000: > + description: | > + If present, then dedicated 1000 Mbit will light up for 1000Base-T. > + This is a workround for boards with a single LED instead of two. > + type: boolean > + > + qcom,single-led-100: > + description: | > + If present, then dedicated 1000 Mbit will light up for 100Base-TX. > + This is a workround for boards with a single LED instead of two. > + type: boolean > + > + qcom,single-led-10: > + description: | > + If present, then dedicated 1000 Mbit will light up for 10Base-Te. > + This is a workround for boards with a single LED instead of two. > + type: boolean Sorry, but no. Please look at the work being done for allow PHY LEDs to be controlled via the LED subsystem. > + qcom,tx-driver-strength: > + description: PSGMII/QSGMII TX driver strength control. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] Please use the actual values here, and have the driver convert to the value poked into the register. So the property would be qcom,tx-driver-strength-mv and it would have the value 220 for example. > + > + qcom,control-dac: > + description: Analog MDI driver amplitude and bias current. > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1, 2, 3, 4, 5, 6, 7] Make here. Andrew
On Wed, Dec 23, 2020 at 01:56:33AM +0100, Andrew Lunn wrote: > > + gpio-controller: true > > + "#gpio-cells": > > + const: 2 > > + > > + qcom,single-led-1000: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 1000Base-T. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > + > > + qcom,single-led-100: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 100Base-TX. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > + > > + qcom,single-led-10: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 10Base-Te. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > Sorry, but no. Please look at the work being done for allow PHY LEDs > to be controlled via the LED subsystem. > > > + qcom,tx-driver-strength: > > + description: PSGMII/QSGMII TX driver strength control. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] > > Please use the actual values here, and have the driver convert to the > value poked into the register. So the property would be > qcom,tx-driver-strength-mv and it would have the value 220 for > example. The LED binding has properties for specifying the current already. And it's max current which is the h/w property where as anything less is just software configuration (IOW, doesn't belong in DT).
On Wed, Dec 23, 2020 at 1:56 AM Andrew Lunn <andrew@lunn.ch> wrote: > > > + gpio-controller: true > > + "#gpio-cells": > > + const: 2 > > + > > + qcom,single-led-1000: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 1000Base-T. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > + > > + qcom,single-led-100: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 100Base-TX. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > + > > + qcom,single-led-10: > > + description: | > > + If present, then dedicated 1000 Mbit will light up for 10Base-Te. > > + This is a workround for boards with a single LED instead of two. > > + type: boolean > > Sorry, but no. Please look at the work being done for allow PHY LEDs > to be controlled via the LED subsystem. Ok, I will drop the LED configuration from the driver until there is a generic way to do it. I was following the work on it, but it seems to have halted after September. > > > + qcom,tx-driver-strength: > > + description: PSGMII/QSGMII TX driver strength control. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] > > Please use the actual values here, and have the driver convert to the > value poked into the register. So the property would be > qcom,tx-driver-strength-mv and it would have the value 220 for > example. Ok, it actually makes more sense than using dt-binding includes for this. > > > + > > + qcom,control-dac: > > + description: Analog MDI driver amplitude and bias current. > > + $ref: /schemas/types.yaml#/definitions/uint32 > > + enum: [0, 1, 2, 3, 4, 5, 6, 7] > > Make here. I am using defines in dt-binding includes for this one as it makes the values humanly readable in DT as these configure the amplitude and bias current for power saving. > > Andrew
On Sun, Jan 3, 2021 at 6:00 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > > > + qcom,tx-driver-strength: > > > > + description: PSGMII/QSGMII TX driver strength control. > > > > + $ref: /schemas/types.yaml#/definitions/uint32 > > > > + enum: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12] > > > > > > Please use the actual values here, and have the driver convert to the > > > value poked into the register. So the property would be > > > qcom,tx-driver-strength-mv and it would have the value 220 for > > > example. > > > > The LED binding has properties for specifying the current already. And > > it's max current which is the h/w property where as anything less is > > just software configuration (IOW, doesn't belong in DT). > > Hi Rob > > My understanding of this is it is the drive strength of the SERDES > line. Nothing to do with LEDs. The description needs improving. Yes, this is used to set the PSGMII/QSMII SerDes TX driver strength. It has nothing to do with LEDs. I agree that the description is a bit confusing, I will try to make it a bit clearer. > > Andrew