From patchwork Wed May 18 12:11:02 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Zapolskiy X-Patchwork-Id: 574351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9147C43219 for ; Wed, 18 May 2022 12:11:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236306AbiERMLZ (ORCPT ); Wed, 18 May 2022 08:11:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42032 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236294AbiERMLN (ORCPT ); Wed, 18 May 2022 08:11:13 -0400 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0142B33A38 for ; Wed, 18 May 2022 05:11:11 -0700 (PDT) Received: by mail-lf1-x134.google.com with SMTP id u23so3289511lfc.1 for ; Wed, 18 May 2022 05:11:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nUFvXB8NXMFcyU7UqQtHGu+yWvXe5nBkItYTmYIGtoU=; b=MZncvBXNIASuguQoyC0dPlNo13lla4FLlCdQfqMPgXDOWl7K3C2kzKve6FJd2VIDAe kiYnDNFqDIRcs5R7W2ELHMoZlZ7oxCTX4Qc+uHTnhK+xgfZ+5I+xLyqr38V0jlyGbNiu g6VWxLp6wpUC5vuGZzR1n5FpZhwQa7lqLGoBTIYqXQJmSxxbuvd7FM/oD0MmKfufD0Qu ykfkRT6wRT4+aFJBwuu/IWXXIfphzFJCUaWwSxICOTHhUiBaBa9o0zFgjI2/HkXC7Eja uigOojG9GGZdnkQ4D+lGRR9xiH5VnTRW6bBlS52qummqcHrvcuPgnDWh6JOjoxucUWS6 74OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nUFvXB8NXMFcyU7UqQtHGu+yWvXe5nBkItYTmYIGtoU=; b=lqyd8rwqwF9gl8CFcRGtVUYfgLjDEQMw2hMPOFIKDITTJj6/sc/4RdhpXAd+B9gkit +gs7gRXhYJEMVH4JPHgo4qhXrJcuITaKVXoyq8j2RTADiaUMRiuZid2Dn7YjWKwDh5fy RSyFNnEut59+J4+zLvrwihCIo33BuTgQ3b+cXK7VdMuzFKZ8yUDfDf9Cq68KZvUKvWr6 Hlahbcm058lnN8ej6tpks/gTZQBYrdoRjN6T6q7mBxBIyjuJmHw87ANwsMzgcMnQ6ifO rVbhOUHaRAHFVr5QhgwxqRIJOIXVXY63JSOKnlpQp0wHZS8UbYSIJj4QYkanfxvHEzNJ Bjjw== X-Gm-Message-State: AOAM532tayLyLNVVnISdRWyPuOur5Zl5BJ6Jz3TA4aMQZqNY/paecg19 6QhuD+wDVhE29MS7Y9eUVJqfvQ== X-Google-Smtp-Source: ABdhPJydAp5C4QR31PB6tNqxtPVxmkq1XR/QpCAPPE05LbQTnj16rSElfQrK1y+UDah+wKvJgYaRaA== X-Received: by 2002:a05:6512:39c1:b0:44a:e25d:47fd with SMTP id k1-20020a05651239c100b0044ae25d47fdmr19960149lfu.580.1652875869362; Wed, 18 May 2022 05:11:09 -0700 (PDT) Received: from localhost.localdomain (mobile-access-b04822-211.dhcp.inet.fi. [176.72.34.211]) by smtp.gmail.com with ESMTPSA id o8-20020a2ebd88000000b0024f3d1daeccsm194460ljq.84.2022.05.18.05.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 May 2022 05:11:08 -0700 (PDT) From: Vladimir Zapolskiy To: Robert Foss , Todor Tomov , Andy Gross , Bjorn Andersson Cc: Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH 0/2] media: dt-bindings: media: sm8250-camss: Add power-domain-names property Date: Wed, 18 May 2022 15:11:02 +0300 Message-Id: <20220518121104.951621-1-vladimir.zapolskiy@linaro.org> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org QCOM SM8250 camera subsystem depends on three power domains, at the moment all of them are not differentiated one from another, however the power domains compose a hierarchical structure with vfe0 and vfe1 as subdomains of titan_top, also managing vfe0 and vfe1 separately allows to get more fine-grained power control in runtime. The change relates to my review comment for v2 of CAMSS on SM8250 submission: https://lore.kernel.org/all/13ad033e-cd5d-3a8c-b036-50a3ac4245c0@linaro.org/ Apparently it becomes important to manage CAMSS power domains much better for newer platforms, this referes to platforms with Titan GDSC, for instance CAMSS on SM8450 has 6 power domains, and dealing with them in bulk is not an option. There was a note in commit 2f6f8af67203 ("media: camss: Refactor VFE power domain toggling") about problems with power VFE domains on/off, but perhaps it's related to the fact that Titan GDSC is a special power domain and VFE are subdomains, the latter shall not be enabled earlier than the Titan, but the driver did not construct a proper hierarchy and leaves a room for races. The change should have no implications on any SM8250 CAMSS users, since none of the supported in upstream boards enables the camss device tree node. The correspondent changes in the driver will follow this dt specific series. Most likely a similar change is required for SDM845 platform, but it would need additional investigation and testing. Vladimir Zapolskiy (2): media: dt-bindings: media: sm8250-camss: Add power-domain-names property arm64: dts: qcom: sm8250: camss: Add power-domain-names property .../devicetree/bindings/media/qcom,sm8250-camss.yaml | 7 +++++++ arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 + 2 files changed, 8 insertions(+)