mbox series

[v4,0/7] remoteproc: qcom_q6v5_mss: Add MSM8909 and MSM8953

Message ID 20220908182433.466908-1-stephan.gerhold@kernkonzept.com
Headers show
Series remoteproc: qcom_q6v5_mss: Add MSM8909 and MSM8953 | expand

Message

Stephan Gerhold Sept. 8, 2022, 6:24 p.m. UTC
Convert parts of the qcom,q6v5.txt binding documentation to a DT schema
(together with some DT fixes) in preparation of adding new compatibles
for MSM8909 and MSM8953. The schema can be easily shared between
MSM8916, MSM8974, MSM8909 and MSM8953 because they have almost the same
requirements. The other SoCs are quite different and are likely more
clearly described in separate DT schema(s) to avoid a lot of complicated
if statements.

Since there were some concerns about overlap with the more generic
(but also more complex) DT schema Sireesh made in [1], I've coordinated
with Sireesh for v3 and include his adjusted changes for MSM8953 here.

---
Changes in v4:
  - Address review comments from Krzysztof

Changes in v3:
  - Combine series with Sireesh's for MSM8953

Changes in v2:
  - Address review comments from Krzysztof
  - Drop "ARM: dts: qcom: msm8974: Disable remoteprocs by default"
    since Bjorn applied it already


Sireesh Kodali (1):
  remoteproc: qcom: q6v5-mss: Add modem support on MSM8953

Stephan Gerhold (6):
  arm64: dts: qcom: msm8916: Drop MSS fallback compatible
  dt-bindings: remoteproc: qcom,q6v5: Move MSM8916 to schema
  dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8974
  dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8909
  remoteproc: qcom: q6v5-mss: Add support for MSM8909
  dt-bindings: remoteproc: qcom,msm8916-mss-pil: Add MSM8953

 .../remoteproc/qcom,msm8916-mss-pil.yaml      | 289 ++++++++++++++++++
 .../bindings/remoteproc/qcom,q6v5.txt         |  35 ---
 arch/arm64/boot/dts/qcom/msm8916.dtsi         |   2 +-
 drivers/remoteproc/qcom_q6v5_mss.c            | 174 +++++++++--
 4 files changed, 431 insertions(+), 69 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml

Comments

Krzysztof Kozlowski Sept. 9, 2022, 8:34 a.m. UTC | #1
On 08/09/2022 20:24, Stephan Gerhold wrote:
> qcom,q6v5.txt covers multiple SoCs with quite different binding
> requirements. Converting this into one DT schema would require
> several if statements, making the DT schema overall harder to
> read and understand.
> 
> To avoid this, follow the example of SC7180/SC7280 and split
> "qcom,msm8916-mss-pil" (and the equivalent deprecated "qcom,q6v5-pil"
> compatible) into a separate DT schema. The schema is somewhat based
> on the one for SC7180/SC7280 but adjusted for the old platforms.
> 
> Compared to the old plain text bindings, add missing documentation for
> the "bam-dmux" subnode and recommend one particular approach to specify
> the MBA/MPSS "memory-region" (the other one is marked as deprecated).
> 
> Signed-off-by: Stephan Gerhold <stephan.gerhold@kernkonzept.com>
> ---
> "dt-bindings: remoteproc: qcom,smd-edge: Add APR/FastRPC" [1] should be
> applied additionally to avoid a dtbs_check warning related to fastrpc in
> msm8916.dtsi.
> 
> Changes in v4: Add "unevaluatedProperties: false" to smd-edge
> Changes in v3: None
> Changes in v2:
>   - Add blank lines between top-level properties
>   - Drop "deprecated" in "oneOf" list, it is not clear if this is valid
>     and it should be redundant since the properties itself are already
>     marked as "deprecated"
> 
> [1]: https://lore.kernel.org/linux-arm-msm/20220908181432.458900-1-stephan.gerhold@kernkonzept.com/


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>


Best regards,
Krzysztof
Bjorn Andersson Oct. 18, 2022, 3:15 a.m. UTC | #2
On Thu, 8 Sep 2022 20:24:26 +0200, Stephan Gerhold wrote:
> Convert parts of the qcom,q6v5.txt binding documentation to a DT schema
> (together with some DT fixes) in preparation of adding new compatibles
> for MSM8909 and MSM8953. The schema can be easily shared between
> MSM8916, MSM8974, MSM8909 and MSM8953 because they have almost the same
> requirements. The other SoCs are quite different and are likely more
> clearly described in separate DT schema(s) to avoid a lot of complicated
> if statements.
> 
> [...]

Applied, thanks!

[1/7] arm64: dts: qcom: msm8916: Drop MSS fallback compatible
      commit: ff02ac621634e82c0c34d02a79d402ae700cdfd0

Best regards,