| Message ID | 20221014221138.7552-1-quic_molvera@quicinc.com |
|---|---|
| Headers | show |
| Series | Add base device tree files for QDU1000/QRU1000 | expand |
On 10/14/2022 3:11 PM, Melody Olvera wrote: > This series adds the base device tree files and DTS support for the > Qualcomm QDU1000 and QRU1000 IDP SoCs, including the clocks, tlmm, smmu, > regulators, mmc, interconnects, cpufreq, and qup. > > This patchset is based off of [1] which adds support for the PMIC arb used > on these SoCs. > > The Qualcomm Technologies, Inc. Distributed Unit 1000 and Radio Unit > 1000 are new SoCs meant for enabling Open RAN solutions. See more at > https://www.qualcomm.com/content/dam/qcomm-martech/dm-assets/documents/qualcomm_5g_ran_platforms_product_brief.pdf > > [1] https://lore.kernel.org/all/20220914165212.3705892-3-vkoul@kernel.org/ Changes from v1: - squashed dtsi changes and dts changes into one commit each - changed qdru to qdu and used qru dtsi file for changes from qdu - removed underscores from node names - revised idle states and domain idle states - sorted devices by addr - removed undocumented fields - fixed pin functions - revised regulator node names > > Melody Olvera (3): > dt-bindings: arm: qcom: Document QDU1000/QRU1000 SoCs and boards > arm64: dts: qcom: Add base QDU1000/QRU1000 DTSIs > arm64: dts: qcom: Add base QDU1000/QRU1000 IDP DTs > > .../devicetree/bindings/arm/qcom.yaml | 16 + > arch/arm64/boot/dts/qcom/Makefile | 2 + > arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 230 +++ > arch/arm64/boot/dts/qcom/qdu1000.dtsi | 1646 +++++++++++++++++ > arch/arm64/boot/dts/qcom/qru1000-idp.dts | 230 +++ > arch/arm64/boot/dts/qcom/qru1000.dtsi | 27 + > 6 files changed, 2151 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/qdu1000-idp.dts > create mode 100644 arch/arm64/boot/dts/qcom/qdu1000.dtsi > create mode 100644 arch/arm64/boot/dts/qcom/qru1000-idp.dts > create mode 100644 arch/arm64/boot/dts/qcom/qru1000.dtsi > > > base-commit: dca0a0385a4963145593ba417e1417af88a7c18d > prerequisite-patch-id: 5e7a02607aecd3f5346a2f450982601cf6935e54
On 14/10/2022 18:11, Melody Olvera wrote: > Add DTs for Qualcomm IDP platforms using the QDU1000 and QRU1000 > SoCs. > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > arch/arm64/boot/dts/qcom/Makefile | 2 + > arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 230 +++++++++++++++++++++++ > arch/arm64/boot/dts/qcom/qru1000-idp.dts | 230 +++++++++++++++++++++++ > 3 files changed, 462 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/qdu1000-idp.dts > create mode 100644 arch/arm64/boot/dts/qcom/qru1000-idp.dts > > diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile > index d7669a7cee9f..8417295adfeb 100644 > --- a/arch/arm64/boot/dts/qcom/Makefile > +++ b/arch/arm64/boot/dts/qcom/Makefile > @@ -51,7 +51,9 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb > dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb > dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb > +dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb > dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb > +dtb-$(CONFIG_ARCH_QCOM) += qru1000-idp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sa8295p-adp.dtb > dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb > diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > new file mode 100644 > index 000000000000..47a8eaf4fda2 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts > @@ -0,0 +1,230 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> > +#include "qdu1000.dtsi" > +#include "pm8150.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. QDU1000 IDP"; > + compatible = "qcom,qdu1000-idp", "qcom,qdu1000"; > + > + aliases { > + serial0 = &uart7; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + ppvar_sys: ppvar-sys-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "ppvar_sys"; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + vph_pwr: vph-pwr-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-min-microvolt = <3700000>; > + regulator-max-microvolt = <3700000>; > + > + regulator-always-on; > + regulator-boot-on; > + > + vin-supply = <&ppvar_sys>; > + }; > +}; > + > +&apps_rsc { > + pm8150-regulators { regulators > + compatible = "qcom,pm8150-rpmh-regulators"; > + qcom,pmic-id = "a"; > + > + vdd-s1-supply = <&vph_pwr>; > + vdd-s2-supply = <&vph_pwr>; > + vdd-s3-supply = <&vph_pwr>; > + vdd-s4-supply = <&vph_pwr>; > + vdd-s5-supply = <&vph_pwr>; > + vdd-s6-supply = <&vph_pwr>; > + vdd-s7-supply = <&vph_pwr>; > + vdd-s8-supply = <&vph_pwr>; > + vdd-s9-supply = <&vph_pwr>; > + vdd-s10-supply = <&vph_pwr>; > + > + vdd-l1-l8-l11-supply = <&vreg_s6a_0p9>; > + vdd-l2-l10-supply = <&vph_pwr>; > + vdd-l3-l4-l5-l18-supply = <&vreg_s5a_2p0>; > + vdd-l6-l9-supply = <&vreg_s6a_0p9>; > + vdd-l7-l12-l14-l15-supply = <&vreg_s4a_1p8>; > + vdd-l13-l16-l17-supply = <&vph_pwr>; > + > + vreg_s2a_0p5: smps2 { > + regulator-name = "vreg_s2a_0p5"; > + regulator-min-microvolt = <320000>; > + regulator-max-microvolt = <570000>; > + }; > + > + vreg_s3a_1p05: smps3 { > + regulator-name = "vreg_s3a_1p05"; > + regulator-min-microvolt = <950000>; > + regulator-max-microvolt = <1170000>; > + }; > + > + vreg_s4a_1p8: smps4 { > + regulator-name = "vreg_s4a_1p8"; > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <1800000>; > + }; > + > + vreg_s5a_2p0: smps5 { > + regulator-name = "vreg_s5a_2p0"; > + regulator-min-microvolt = <1904000>; > + regulator-max-microvolt = <2000000>; > + }; > + > + vreg_s6a_0p9: smps6 { > + regulator-name = "vreg_s6a_0p9"; > + regulator-min-microvolt = <920000>; > + regulator-max-microvolt = <1128000>; > + }; > + > + vreg_s7a_1p2: smps7 { > + regulator-name = "vreg_s7a_1p2"; > + regulator-min-microvolt = <1200000>; > + regulator-max-microvolt = <1200000>; > + }; > + > + vreg_s8a_1p3: smps8 { > + regulator-name = "vreg_s8a_1p3"; > + regulator-min-microvolt = <1352000>; > + regulator-max-microvolt = <1352000>; > + }; > + > + vreg_l1a_0p91: ldo1 { > + regulator-name = "vreg_l1a_0p91"; > + regulator-min-microvolt = <312000>; > + regulator-max-microvolt = <1304000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l2a_2p3: ldo2 { > + regulator-name = "vreg_l2a_2p3"; > + regulator-min-microvolt = <2970000>; > + regulator-max-microvolt = <3300000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l3a_1p2: ldo3 { > + regulator-name = "vreg_l3a_1p2"; > + regulator-min-microvolt = <920000>; > + regulator-max-microvolt = <1260000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l5a_0p8: ldo5 { > + regulator-name = "vreg_l5a_0p8"; > + regulator-min-microvolt = <312000>; > + regulator-max-microvolt = <1304000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l6a_0p91: ldo6 { > + regulator-name = "vreg_l6a_0p91"; > + regulator-min-microvolt = <880000>; > + regulator-max-microvolt = <950000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l7a_1p8: ldo7 { > + regulator-name = "vreg_l7a_1p8"; > + regulator-min-microvolt = <1650000>; > + regulator-max-microvolt = <2000000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + > + }; > + > + vreg_l8a_0p91: ldo8 { > + regulator-name = "vreg_l8a_0p91"; > + regulator-min-microvolt = <888000>; > + regulator-max-microvolt = <925000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l9a_0p91: ldo9 { > + regulator-name = "vreg_l8a_0p91"; > + regulator-min-microvolt = <312000>; > + regulator-max-microvolt = <1304000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l10a_2p95: ldo10 { > + regulator-name = "vreg_l10a_2p95"; > + regulator-min-microvolt = <2700000>; > + regulator-max-microvolt = <3544000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l11a_0p91: ldo11 { > + regulator-name = "vreg_l11a_0p91"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1000000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l12a_1p8: ldo12 { > + regulator-name = "vreg_l12a_1p8"; > + regulator-min-microvolt = <1504000>; > + regulator-max-microvolt = <1504000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l14a_1p8: ldo14 { > + regulator-name = "vreg_l14a_1p8"; > + regulator-min-microvolt = <1650000>; > + regulator-max-microvolt = <1950000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l15a_1p8: ldo15 { > + regulator-name = "vreg_l15a_1p8"; > + regulator-min-microvolt = <1504000>; > + regulator-max-microvolt = <2000000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l16a_1p8: ldo16 { > + regulator-name = "vreg_l16a_1p8"; > + regulator-min-microvolt = <1710000>; > + regulator-max-microvolt = <1890000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l17a_3p3: ldo17 { > + regulator-name = "vreg_l17a_3p3"; > + regulator-min-microvolt = <3000000>; > + regulator-max-microvolt = <3544000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + > + vreg_l18a_1p2: ldo18 { > + regulator-name = "vreg_l18a_1p2"; > + regulator-min-microvolt = <312000>; > + regulator-max-microvolt = <1304000>; > + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; > + }; > + }; > +}; > + > +&qupv3_id_0 { > + status = "okay"; > +}; > + > +&uart7 { > + status = "okay"; > +}; > diff --git a/arch/arm64/boot/dts/qcom/qru1000-idp.dts b/arch/arm64/boot/dts/qcom/qru1000-idp.dts > new file mode 100644 > index 000000000000..54770c697db8 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/qru1000-idp.dts > @@ -0,0 +1,230 @@ > +// SPDX-License-Identifier: BSD-3-Clause > +/* > + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. > + */ > + > +/dts-v1/; > + > +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> > +#include "qru1000.dtsi" > +#include "pm8150.dtsi" > + > +/ { > + model = "Qualcomm Technologies, Inc. QRU1000 IDP"; > + compatible = "qcom,qru1000-idp", "qcom,qru1000"; > + > + aliases { > + serial0 = &uart7; > + }; > + > + chosen { > + stdout-path = "serial0:115200n8"; > + }; > + > + ppvar_sys: ppvar-sys-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "ppvar_sys"; > + regulator-always-on; > + regulator-boot-on; > + }; > + > + vph_pwr: vph-pwr-regulator { > + compatible = "regulator-fixed"; > + regulator-name = "vph_pwr"; > + regulator-min-microvolt = <3700000>; > + regulator-max-microvolt = <3700000>; > + > + regulator-always-on; > + regulator-boot-on; > + > + vin-supply = <&ppvar_sys>; > + }; > +}; > + > +&apps_rsc { > + pm8150-regulators { regulators Best regards, Krzysztof
On 14/10/2022 18:11, Melody Olvera wrote: (...) > + > + firmware { > + qcom_scm { > + compatible = "qcom,scm-qdu100", "qcom.scm-qru1000", "qcom,scm"; > + #reset-cells = <1>; > + }; > + }; > + > + clk_virt: interconnect-0 { > + compatible = "qcom,qdu1000-clk-virt", "qcom,qru1000-clk-virt"; How does this pass your dtbs_check tests? This applies everywhere... Best regards, Krzysztof
On 10/15/2022 6:29 AM, Krzysztof Kozlowski wrote: > On 14/10/2022 18:11, Melody Olvera wrote: >> Add DTs for Qualcomm IDP platforms using the QDU1000 and QRU1000 >> SoCs. >> >> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/Makefile | 2 + >> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 230 +++++++++++++++++++++++ >> arch/arm64/boot/dts/qcom/qru1000-idp.dts | 230 +++++++++++++++++++++++ >> 3 files changed, 462 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> create mode 100644 arch/arm64/boot/dts/qcom/qru1000-idp.dts >> >> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >> index d7669a7cee9f..8417295adfeb 100644 >> --- a/arch/arm64/boot/dts/qcom/Makefile >> +++ b/arch/arm64/boot/dts/qcom/Makefile >> @@ -51,7 +51,9 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb >> dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb >> +dtb-$(CONFIG_ARCH_QCOM) += qru1000-idp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sa8295p-adp.dtb >> dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb >> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> new file mode 100644 >> index 000000000000..47a8eaf4fda2 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >> @@ -0,0 +1,230 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> + >> +/dts-v1/; >> + >> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> +#include "qdu1000.dtsi" >> +#include "pm8150.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. QDU1000 IDP"; >> + compatible = "qcom,qdu1000-idp", "qcom,qdu1000"; >> + >> + aliases { >> + serial0 = &uart7; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + >> + ppvar_sys: ppvar-sys-regulator { >> + compatible = "regulator-fixed"; >> + regulator-name = "ppvar_sys"; >> + regulator-always-on; >> + regulator-boot-on; >> + }; >> + >> + vph_pwr: vph-pwr-regulator { >> + compatible = "regulator-fixed"; >> + regulator-name = "vph_pwr"; >> + regulator-min-microvolt = <3700000>; >> + regulator-max-microvolt = <3700000>; >> + >> + regulator-always-on; >> + regulator-boot-on; >> + >> + vin-supply = <&ppvar_sys>; >> + }; >> +}; >> + >> +&apps_rsc { >> + pm8150-regulators { > regulators Just 'regulators' as the node name isn't compliant with the bindings for rpmh-rsc devices. Do the bindings need to be updated or should I leave this as is? > >> + compatible = "qcom,pm8150-rpmh-regulators"; >> + qcom,pmic-id = "a"; >> + >> + vdd-s1-supply = <&vph_pwr>; >> + vdd-s2-supply = <&vph_pwr>; >> + vdd-s3-supply = <&vph_pwr>; >> + vdd-s4-supply = <&vph_pwr>; >> + vdd-s5-supply = <&vph_pwr>; >> + vdd-s6-supply = <&vph_pwr>; >> + vdd-s7-supply = <&vph_pwr>; >> + vdd-s8-supply = <&vph_pwr>; >> + vdd-s9-supply = <&vph_pwr>; >> + vdd-s10-supply = <&vph_pwr>; >> + >> + vdd-l1-l8-l11-supply = <&vreg_s6a_0p9>; >> + vdd-l2-l10-supply = <&vph_pwr>; >> + vdd-l3-l4-l5-l18-supply = <&vreg_s5a_2p0>; >> + vdd-l6-l9-supply = <&vreg_s6a_0p9>; >> + vdd-l7-l12-l14-l15-supply = <&vreg_s4a_1p8>; >> + vdd-l13-l16-l17-supply = <&vph_pwr>; >> + >> + vreg_s2a_0p5: smps2 { >> + regulator-name = "vreg_s2a_0p5"; >> + regulator-min-microvolt = <320000>; >> + regulator-max-microvolt = <570000>; >> + }; >> + >> + vreg_s3a_1p05: smps3 { >> + regulator-name = "vreg_s3a_1p05"; >> + regulator-min-microvolt = <950000>; >> + regulator-max-microvolt = <1170000>; >> + }; >> + >> + vreg_s4a_1p8: smps4 { >> + regulator-name = "vreg_s4a_1p8"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <1800000>; >> + }; >> + >> + vreg_s5a_2p0: smps5 { >> + regulator-name = "vreg_s5a_2p0"; >> + regulator-min-microvolt = <1904000>; >> + regulator-max-microvolt = <2000000>; >> + }; >> + >> + vreg_s6a_0p9: smps6 { >> + regulator-name = "vreg_s6a_0p9"; >> + regulator-min-microvolt = <920000>; >> + regulator-max-microvolt = <1128000>; >> + }; >> + >> + vreg_s7a_1p2: smps7 { >> + regulator-name = "vreg_s7a_1p2"; >> + regulator-min-microvolt = <1200000>; >> + regulator-max-microvolt = <1200000>; >> + }; >> + >> + vreg_s8a_1p3: smps8 { >> + regulator-name = "vreg_s8a_1p3"; >> + regulator-min-microvolt = <1352000>; >> + regulator-max-microvolt = <1352000>; >> + }; >> + >> + vreg_l1a_0p91: ldo1 { >> + regulator-name = "vreg_l1a_0p91"; >> + regulator-min-microvolt = <312000>; >> + regulator-max-microvolt = <1304000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l2a_2p3: ldo2 { >> + regulator-name = "vreg_l2a_2p3"; >> + regulator-min-microvolt = <2970000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l3a_1p2: ldo3 { >> + regulator-name = "vreg_l3a_1p2"; >> + regulator-min-microvolt = <920000>; >> + regulator-max-microvolt = <1260000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l5a_0p8: ldo5 { >> + regulator-name = "vreg_l5a_0p8"; >> + regulator-min-microvolt = <312000>; >> + regulator-max-microvolt = <1304000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l6a_0p91: ldo6 { >> + regulator-name = "vreg_l6a_0p91"; >> + regulator-min-microvolt = <880000>; >> + regulator-max-microvolt = <950000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l7a_1p8: ldo7 { >> + regulator-name = "vreg_l7a_1p8"; >> + regulator-min-microvolt = <1650000>; >> + regulator-max-microvolt = <2000000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + >> + }; >> + >> + vreg_l8a_0p91: ldo8 { >> + regulator-name = "vreg_l8a_0p91"; >> + regulator-min-microvolt = <888000>; >> + regulator-max-microvolt = <925000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l9a_0p91: ldo9 { >> + regulator-name = "vreg_l8a_0p91"; >> + regulator-min-microvolt = <312000>; >> + regulator-max-microvolt = <1304000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l10a_2p95: ldo10 { >> + regulator-name = "vreg_l10a_2p95"; >> + regulator-min-microvolt = <2700000>; >> + regulator-max-microvolt = <3544000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l11a_0p91: ldo11 { >> + regulator-name = "vreg_l11a_0p91"; >> + regulator-min-microvolt = <800000>; >> + regulator-max-microvolt = <1000000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l12a_1p8: ldo12 { >> + regulator-name = "vreg_l12a_1p8"; >> + regulator-min-microvolt = <1504000>; >> + regulator-max-microvolt = <1504000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l14a_1p8: ldo14 { >> + regulator-name = "vreg_l14a_1p8"; >> + regulator-min-microvolt = <1650000>; >> + regulator-max-microvolt = <1950000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l15a_1p8: ldo15 { >> + regulator-name = "vreg_l15a_1p8"; >> + regulator-min-microvolt = <1504000>; >> + regulator-max-microvolt = <2000000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l16a_1p8: ldo16 { >> + regulator-name = "vreg_l16a_1p8"; >> + regulator-min-microvolt = <1710000>; >> + regulator-max-microvolt = <1890000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l17a_3p3: ldo17 { >> + regulator-name = "vreg_l17a_3p3"; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3544000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + >> + vreg_l18a_1p2: ldo18 { >> + regulator-name = "vreg_l18a_1p2"; >> + regulator-min-microvolt = <312000>; >> + regulator-max-microvolt = <1304000>; >> + regulator-initial-mode = <RPMH_REGULATOR_MODE_LPM>; >> + }; >> + }; >> +}; >> + >> +&qupv3_id_0 { >> + status = "okay"; >> +}; >> + >> +&uart7 { >> + status = "okay"; >> +}; >> diff --git a/arch/arm64/boot/dts/qcom/qru1000-idp.dts b/arch/arm64/boot/dts/qcom/qru1000-idp.dts >> new file mode 100644 >> index 000000000000..54770c697db8 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/qru1000-idp.dts >> @@ -0,0 +1,230 @@ >> +// SPDX-License-Identifier: BSD-3-Clause >> +/* >> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >> + */ >> + >> +/dts-v1/; >> + >> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> >> +#include "qru1000.dtsi" >> +#include "pm8150.dtsi" >> + >> +/ { >> + model = "Qualcomm Technologies, Inc. QRU1000 IDP"; >> + compatible = "qcom,qru1000-idp", "qcom,qru1000"; >> + >> + aliases { >> + serial0 = &uart7; >> + }; >> + >> + chosen { >> + stdout-path = "serial0:115200n8"; >> + }; >> + >> + ppvar_sys: ppvar-sys-regulator { >> + compatible = "regulator-fixed"; >> + regulator-name = "ppvar_sys"; >> + regulator-always-on; >> + regulator-boot-on; >> + }; >> + >> + vph_pwr: vph-pwr-regulator { >> + compatible = "regulator-fixed"; >> + regulator-name = "vph_pwr"; >> + regulator-min-microvolt = <3700000>; >> + regulator-max-microvolt = <3700000>; >> + >> + regulator-always-on; >> + regulator-boot-on; >> + >> + vin-supply = <&ppvar_sys>; >> + }; >> +}; >> + >> +&apps_rsc { >> + pm8150-regulators { > regulators Same as above. > > > Best regards, > Krzysztof > Thanks, Melody
On 19/10/2022 17:16, Melody Olvera wrote: > > > On 10/15/2022 6:29 AM, Krzysztof Kozlowski wrote: >> On 14/10/2022 18:11, Melody Olvera wrote: >>> Add DTs for Qualcomm IDP platforms using the QDU1000 and QRU1000 >>> SoCs. >>> >>> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/Makefile | 2 + >>> arch/arm64/boot/dts/qcom/qdu1000-idp.dts | 230 +++++++++++++++++++++++ >>> arch/arm64/boot/dts/qcom/qru1000-idp.dts | 230 +++++++++++++++++++++++ >>> 3 files changed, 462 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>> create mode 100644 arch/arm64/boot/dts/qcom/qru1000-idp.dts >>> >>> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile >>> index d7669a7cee9f..8417295adfeb 100644 >>> --- a/arch/arm64/boot/dts/qcom/Makefile >>> +++ b/arch/arm64/boot/dts/qcom/Makefile >>> @@ -51,7 +51,9 @@ dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-maple.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += msm8998-sony-xperia-yoshino-poplar.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-1000.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qcs404-evb-4000.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += qdu1000-idp.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += qrb5165-rb5.dtb >>> +dtb-$(CONFIG_ARCH_QCOM) += qru1000-idp.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sa8295p-adp.dtb >>> dtb-$(CONFIG_ARCH_QCOM) += sc7180-idp.dtb >>> diff --git a/arch/arm64/boot/dts/qcom/qdu1000-idp.dts b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>> new file mode 100644 >>> index 000000000000..47a8eaf4fda2 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/qcom/qdu1000-idp.dts >>> @@ -0,0 +1,230 @@ >>> +// SPDX-License-Identifier: BSD-3-Clause >>> +/* >>> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved. >>> + */ >>> + >>> +/dts-v1/; >>> + >>> +#include <dt-bindings/regulator/qcom,rpmh-regulator.h> >>> +#include "qdu1000.dtsi" >>> +#include "pm8150.dtsi" >>> + >>> +/ { >>> + model = "Qualcomm Technologies, Inc. QDU1000 IDP"; >>> + compatible = "qcom,qdu1000-idp", "qcom,qdu1000"; >>> + >>> + aliases { >>> + serial0 = &uart7; >>> + }; >>> + >>> + chosen { >>> + stdout-path = "serial0:115200n8"; >>> + }; >>> + >>> + ppvar_sys: ppvar-sys-regulator { >>> + compatible = "regulator-fixed"; >>> + regulator-name = "ppvar_sys"; >>> + regulator-always-on; >>> + regulator-boot-on; >>> + }; >>> + >>> + vph_pwr: vph-pwr-regulator { >>> + compatible = "regulator-fixed"; >>> + regulator-name = "vph_pwr"; >>> + regulator-min-microvolt = <3700000>; >>> + regulator-max-microvolt = <3700000>; >>> + >>> + regulator-always-on; >>> + regulator-boot-on; >>> + >>> + vin-supply = <&ppvar_sys>; >>> + }; >>> +}; >>> + >>> +&apps_rsc { >>> + pm8150-regulators { >> regulators > Just 'regulators' as the node name isn't compliant with the bindings for rpmh-rsc devices. > Do the bindings need to be updated or should I leave this as is? If bindings expect this, I propose to change them. Which schema is expecting this? I already fixed SMD RPM: https://lore.kernel.org/all/20220926092104.111449-1-krzysztof.kozlowski@linaro.org/ Best regards, Krzysztof