| Message ID | 20230118171621.102694-1-bryan.odonoghue@linaro.org |
|---|---|
| Headers | show |
| Series | mdss-dsi-ctrl binding and dts fixes | expand |
On Wed, 18 Jan 2023 17:16:19 +0000, Bryan O'Donoghue wrote: > V9: > - Adds Rob's RB to #1 > - Fixes two check splats - Dmitry > > V8: > - Squash first and last patch to fix bisectability > > [...] Applied, thanks! [1/2] dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC https://gitlab.freedesktop.org/lumag/msm/-/commit/0c0f65c6dd44 [2/2] dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis https://gitlab.freedesktop.org/lumag/msm/-/commit/d10bdc6ec6ac Best regards,
V9: - Adds Rob's RB to #1 - Fixes two check splats - Dmitry V8: - Squash first and last patch to fix bisectability link: https://lore.kernel.org/linux-arm-msm/167388664232.594279.4607492026981202284.robh@kernel.org/T/#u V7: - The bulk of the patches for this series have been merged. There are still four patches to be pushed/updated. - Adds clocks for msm8974 - Dmitry - Adds compat strings for sm8150, sm8350, sm8450, sm8550 - Dmitry - Changes last patch in series to state - Rob compatible: contains: const: qcom,mdss-dsi-ctrl link: https://lore.kernel.org/linux-arm-msm/20221223021025.1646636-1-bryan.odonoghue@linaro.org/ V6: - Squashes a number of patches per Krzysztof's comments on bisectability - Adds in Acked-by Rob and Krzysztof V5: - Adds compat strings to bindings/display/msm/qcom,SoC-mdss.yaml - Dmitry - Re-orders simple fixes to the start of the series to allow backports - Dmitry - VDDA and drop of node-names - Krzysztof - Deprecates qcom,dsi-ctrl-6g-qcm2290 - Krzysztof, Dmitry - Expands set of updated files to include new msm8953 - bod - Converts to agreed compat string qcom,SoC-dsi-ctrl hence - - qcom,mdss-dsi-ctrl-msm8996 + - qcom,msm8996-dsi-ctrl - Adds RB where indicated for the compat strings. V4: - Moves the update of the example from patch #5 to patch #4 V3: - Moves declaration of mdss-dsi-ctrl into compat string declaration patch - Krzysztof, Dmitry - Renames qcm-2290 compat string to agreed compat "qcom,socname-dsi-ctrl" Dmirty, Krzysztof - Adds empty line after if clause in yaml control flow section - Dmirty - Adds Rb/Ack - Krzysztof, Dmitry, Doug, David - vdd* Looking into this some more, I don't believe vdd, vdda, vddio ought to be required properties. Its up to the PCB manufacturer and the panel in-use how that panel is powered. Powering the panel is not something that even necessarily needs to be done from the dsi-ctrl driver. Originally marking vdd* as required in the .txt was an error, its not a SoC level dtsi requirement. - clock-names Rather than replicate the clock-name in each if block I listed them with a specific description from a similar reference in usb/qcom,dwc3.yaml. https://lore.kernel.org/linux-arm-msm/eb80681f-2e0b-605f-0444-ec65562f74b8@linaro.org/ V2: https://www.spinics.net/lists/linux-arm-msm/msg116326.html - Moves the DSI PHY changes to a different later series. There are enough dsi-controller-main changes to justify its own standalone series. - The original phy-name binding change given discussion with Rob and Krzysztof became its own standalone series that has since been merged. https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg403214.html - Retains the drop of power-domain from yaml as a required property. I dug into the available dtsi. The apq8064 doesn't appear to have any GDSC which can be attached as a power-domain, which means the power-domain requirement is not universal across the various silicon versions. - Adds Dmitry's RB to power-domain drop - For the clock declarations I've * I noticed that the simple change I had worked for msm8939 but subsquently broke other dtsi which drove a bigger change to document the clocks on a per compatible basis. * Added compat strings in yaml. * Moved the allOf down later in the file to acomodate the if/then. * Number of clocks validated on a per compatible basis * The driver code which doesn't care about the number of clocks can still operate on the mdss-dsi-ctrl compat but the dts checks will validate against the compat string and yaml. - vdd descriptions Took the previous text I missed from the .txt file - Krzysztof, Dmitry Adds vdd, vdda and vddio to the required list. This exposes warnings in existing dtsi but the previous .txt declared these regulators as required. - Krzysztof V1: This series fixes up a number of dtbs checks which are being flagged adding in the msm8939 dtsi. When converting from .txt to .yaml a number of the parameters for the older msm8916 silicon were not transmitted into the yaml. Adding in the msm8939 which is a near 1:1 copy of the msm8916 in terms of dtsi triggers a rake of dtbs checks as a result. https://www.mail-archive.com/dri-devel@lists.freedesktop.org/msg403211.html Bryan O'Donoghue (2): dt-bindings: msm: dsi-controller-main: Add compatible strings for every current SoC dt-bindings: msm: dsi-controller-main: Document clocks on a per compatible basis .../display/msm/dsi-controller-main.yaml | 248 ++++++++++++++++-- .../bindings/display/msm/qcom,mdss.yaml | 3 +- .../display/msm/qcom,msm8998-mdss.yaml | 8 +- .../display/msm/qcom,sc7180-mdss.yaml | 6 +- .../display/msm/qcom,sc7280-mdss.yaml | 6 +- .../display/msm/qcom,sdm845-mdss.yaml | 8 +- .../display/msm/qcom,sm8150-mdss.yaml | 8 +- .../display/msm/qcom,sm8250-mdss.yaml | 8 +- .../display/msm/qcom,sm8350-mdss.yaml | 6 +- .../display/msm/qcom,sm8450-mdss.yaml | 8 +- 10 files changed, 266 insertions(+), 43 deletions(-)