| Message ID | 20230524-pmi8998-charger-dts-v1-0-f9334afc4505@linaro.org |
|---|---|
| Headers | show |
| Series | Enable PMI8998 charger on supported devices | expand |
On 24.05.2023 19:38, Caleb Connolly wrote: > There is no need for the RRADC to be disabled by default, > lets just enable it by default and not clutter up DT. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > --- Acked-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi | 4 ---- > arch/arm64/boot/dts/qcom/pmi8998.dtsi | 2 -- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ---- > arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 4 ---- > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 4 ---- > 5 files changed, 18 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi > index 062d56c42385..68e634f8212c 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-common.dtsi > @@ -279,10 +279,6 @@ vol_keys_default: vol-keys-state { > }; > }; > > -&pmi8998_rradc { > - status = "okay"; > -}; > - > &qusb2phy { > status = "okay"; > > diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > index ffe587f281d8..be6f60bfc26c 100644 > --- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi > @@ -23,8 +23,6 @@ pmi8998_rradc: adc@4500 { > compatible = "qcom,pmi8998-rradc"; > reg = <0x4500>; > #io-channel-cells = <1>; > - > - status = "disabled"; > }; > }; > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index e14fe9bbb386..66087af02d74 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -649,10 +649,6 @@ led@5 { > }; > }; > > -&pmi8998_rradc { > - status = "okay"; > -}; > - > /* QUAT I2S Uses 4 I2S SD Lines for audio on LT9611 HDMI Bridge */ > &q6afedai { > dai@22 { > diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > index 5c384345c05d..55ee8dcf27c3 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi > @@ -480,10 +480,6 @@ pinconf { > }; > }; > > -&pmi8998_rradc { > - status = "okay"; > -}; > - > &q6afedai { > qi2s@22 { > reg = <22>; > diff --git a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > index 5ed975cc6ecb..1915643f1c49 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-common.dtsi > @@ -346,10 +346,6 @@ &pm8998_resin { > status = "okay"; > }; > > -&pmi8998_rradc { > - status = "okay"; > -}; > - > /* QUAT I2S Uses 1 I2S SD Line for audio on TAS2559/60 amplifiers */ > &q6afedai { > dai@22 { >
These devices have been fairly heavily validated with the driver and are known to not explode. Add the pmi8998_charger node to pmi8998 and enable the charger for the OnePlus 6(T), PocoPhone F1 and SHIFT6mq. The charger depends on the RRADC for the input voltage and current. The RRADC was originally disabled by default, but there isn't really a need for this as it's used by all devices. Let's take the opportunity to enable it by default. The associated driver and dt-bindings that this series depends on can be found here: https://lore.kernel.org/linux-arm-msm/20230524-pmi8998-charger-v8-0-b87ffcd9864d@linaro.org --- Caleb Connolly (5): dt-bindings: mfd: qcom,spmi-pmic: Document pmi8998 charger arm64: dts: qcom: pmi8998: enable rradc by default arm64: dts: qcom: pmi8998: add charger node arm64: dts: qcom: sdm845-oneplus: enable pmi8998 charger arm64: dts: qcom: sdm845-shift-axolotl: enable pmi8998 charger Joel Selvaraj (1): arm64: dts: qcom: sdm845-xiaomi-beryllium: enable pmi8998 charger .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + .../boot/dts/qcom/msm8998-oneplus-common.dtsi | 4 ---- arch/arm64/boot/dts/qcom/pmi8998.dtsi | 22 ++++++++++++++++++++-- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ---- .../arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 2 +- .../boot/dts/qcom/sdm845-oneplus-enchilada.dts | 4 ++++ arch/arm64/boot/dts/qcom/sdm845-oneplus-fajita.dts | 4 ++++ arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 9 +++++++++ .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 15 ++++++++++++--- 9 files changed, 51 insertions(+), 14 deletions(-) --- base-commit: cc08021afd54862446ef11fd683558a7e57cdc6a // Caleb (they/them)