mbox series

[v4,0/4] drm/msm: move resource allocation to the _probe function

Message ID 20230704174553.216248-1-dmitry.baryshkov@linaro.org
Headers show
Series drm/msm: move resource allocation to the _probe function | expand

Message

Dmitry Baryshkov July 4, 2023, 5:45 p.m. UTC 
This patchset was left untouched for almost a year. Let's reiterate it
in attempt to solve the long-standing issue.

As discussed several times on IRC, move display subdriver resource
allocation from kms_init to probe time to let it bail early.

Changes since v3:
- Fixed MMIO unmaping in the DPU case.

Changes since v2:
- Move even more resource allocation in the DPU init path.

Changes since v1:
- Dropped the applied patch
- Picked in the patch to pass msm_kms pointer via msm_drv_probe()

Dmitry Baryshkov (4):
  drm/msm: allow passing struct msm_kms to msm_drv_probe()
  drm/msm/dpu: move resource allocation to the _probe function
  drm/msm/mdp4: move resource allocation to the _probe function
  drm/msm/mdp5: move resource allocation to the _probe function

 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c  | 133 +++++++++++------------
 drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 107 +++++++++---------
 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 100 ++++++++---------
 drivers/gpu/drm/msm/msm_drv.c            |   6 +-
 drivers/gpu/drm/msm/msm_drv.h            |   3 +-
 5 files changed, 162 insertions(+), 187 deletions(-)

Comments

Rob Clark Oct. 9, 2023, 4:29 p.m. UTC | #1 
On Tue, Jul 4, 2023 at 10:45 AM Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> This patchset was left untouched for almost a year. Let's reiterate it
> in attempt to solve the long-standing issue.
>
> As discussed several times on IRC, move display subdriver resource
> allocation from kms_init to probe time to let it bail early.
>
> Changes since v3:
> - Fixed MMIO unmaping in the DPU case.
>
> Changes since v2:
> - Move even more resource allocation in the DPU init path.
>
> Changes since v1:
> - Dropped the applied patch
> - Picked in the patch to pass msm_kms pointer via msm_drv_probe()
>
> Dmitry Baryshkov (4):
>   drm/msm: allow passing struct msm_kms to msm_drv_probe()
>   drm/msm/dpu: move resource allocation to the _probe function
>   drm/msm/mdp4: move resource allocation to the _probe function
>   drm/msm/mdp5: move resource allocation to the _probe function

for the series,

Reviewed-by: Rob Clark <robdclark@gmail.com>

>
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c  | 133 +++++++++++------------
>  drivers/gpu/drm/msm/disp/mdp4/mdp4_kms.c | 107 +++++++++---------
>  drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 100 ++++++++---------
>  drivers/gpu/drm/msm/msm_drv.c            |   6 +-
>  drivers/gpu/drm/msm/msm_drv.h            |   3 +-
>  5 files changed, 162 insertions(+), 187 deletions(-)
>
> --
> 2.39.2
>