mbox series

[v2,0/7] Improvements to Qcom PCIe EP and EPF MHI drivers

Message ID 20230717065459.14138-1-manivannan.sadhasivam@linaro.org
Headers show
Series Improvements to Qcom PCIe EP and EPF MHI drivers | expand

Message

Manivannan Sadhasivam July 17, 2023, 6:54 a.m. UTC 
Hi,

This series adds eDMA (embedded DMA) support to the Qcom PCIe EP and EPF 
MHI drivers for offloading the transfers between PCIe bus and the EP
memory. eDMA support makes use of the recently merged eDMA DMAEngine driver
and its integration with DWC PCIe EP core [1].

This series also adds Qcom SM8450 SoC support to EPF MHI driver that has
the eDMA support built-in.

- Mani

[1] https://lore.kernel.org/all/20230113171409.30470-1-Sergey.Semin@baikalelectronics.ru/

Changes in v2:

* Rebased on top of v6.5-rc1

Manivannan Sadhasivam (7):
  PCI: qcom-ep: Pass alignment restriction to the EPF core
  PCI: epf-mhi: Make use of the alignment restriction from EPF core
  PCI: qcom-ep: Add eDMA support
  PCI: epf-mhi: Add eDMA support
  PCI: epf-mhi: Add support for SM8450
  PCI: epf-mhi: Use iATU for small transfers
  PCI: endpoint: Add kernel-doc for pci_epc_mem_init() API

 drivers/pci/controller/dwc/pcie-qcom-ep.c    |   5 +-
 drivers/pci/endpoint/functions/pci-epf-mhi.c | 280 ++++++++++++++++++-
 drivers/pci/endpoint/pci-epc-mem.c           |  10 +
 3 files changed, 281 insertions(+), 14 deletions(-)

Comments

Randy Dunlap July 17, 2023, 7:04 a.m. UTC | #1 
On 7/16/23 23:54, Manivannan Sadhasivam wrote:
> Add missing kernel-doc for pci_epc_mem_init() API.
> 
> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

Looks good. Thanks.

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>  drivers/pci/endpoint/pci-epc-mem.c | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/drivers/pci/endpoint/pci-epc-mem.c b/drivers/pci/endpoint/pci-epc-mem.c
> index 7dcf6f480b82..a9c028f58da1 100644
> --- a/drivers/pci/endpoint/pci-epc-mem.c
> +++ b/drivers/pci/endpoint/pci-epc-mem.c
> @@ -115,6 +115,16 @@ int pci_epc_multi_mem_init(struct pci_epc *epc,
>  }
>  EXPORT_SYMBOL_GPL(pci_epc_multi_mem_init);
>  
> +/**
> + * pci_epc_mem_init() - Initialize the pci_epc_mem structure
> + * @epc: the EPC device that invoked pci_epc_mem_init
> + * @base: Physical address of the window region
> + * @size: Total Size of the window region
> + * @page_size: Page size of the window region
> + *
> + * Invoke to initialize a single pci_epc_mem structure used by the
> + * endpoint functions to allocate memory for mapping the PCI host memory
> + */
>  int pci_epc_mem_init(struct pci_epc *epc, phys_addr_t base,
>  		     size_t size, size_t page_size)
>  {
Krzysztof Wilczyński Aug. 25, 2023, 6:28 p.m. UTC | #2 
Hello,

> This series adds eDMA (embedded DMA) support to the Qcom PCIe EP and EPF 
> MHI drivers for offloading the transfers between PCIe bus and the EP
> memory. eDMA support makes use of the recently merged eDMA DMAEngine driver
> and its integration with DWC PCIe EP core [1].
> 
> This series also adds Qcom SM8450 SoC support to EPF MHI driver that has
> the eDMA support built-in.

Apologies, I accidentally responded to an older series:

  https://lore.kernel.org/linux-pci/20230825175729.GB131548@rocinante

This series version was applied, of course.

	Krzysztof