mbox series

[0/2] pmdomain: qcom: Update part number to X1E80100

Message ID 20231117104254.28862-1-quic_sibis@quicinc.com
Headers show
Series pmdomain: qcom: Update part number to X1E80100 | expand

Message

Sibi Sankar Nov. 17, 2023, 10:42 a.m. UTC 
Our v1 post of the patchsets adding support for Snapdragon X Elite SoC had
the part number sc8380xp which is now updated to the new part number x1e80100
based on the new branding scheme and refers to the exact same SoC.

Dependencies: None
Release Link: https://www.qualcomm.com/news/releases/2023/10/qualcomm-unleashes-snapdragon-x-elite--the-ai-super-charged-plat

Sibi Sankar (2):
  dt-bindings: power: rpmpd: Update part number to X1E80100
  pmdomain: qcom: rpmhpd: Update part number to X1E80100

 .../devicetree/bindings/power/qcom,rpmpd.yaml        |  2 +-
 drivers/pmdomain/qcom/rpmhpd.c                       | 12 ++++++------
 2 files changed, 7 insertions(+), 7 deletions(-)

Comments

Krzysztof Kozlowski Nov. 17, 2023, 11:05 a.m. UTC | #1 
On 17/11/2023 11:42, Sibi Sankar wrote:
> Replace SC8380xp with the updated part number (X1E80100).
> 

You need to explain why. We don't update compatibles based on marketing
wishes.

Best regards,
Krzysztof
Sibi Sankar Nov. 17, 2023, 11:46 a.m. UTC | #2 
Hey Krzysztof,

Thanks for taking time to review the series.

On 11/17/23 16:35, Krzysztof Kozlowski wrote:
> On 17/11/2023 11:42, Sibi Sankar wrote:
>> Replace SC8380xp with the updated part number (X1E80100).
>>
> 
> You need to explain why. We don't update compatibles based on marketing
> wishes.

What we imply is that X1E80100 is the part number you would get when you
read out from a Snapdragon X Elite device in the wild, when it is
available and we didn't have this information when we posted out v1.

-Sibi

> 
> Best regards,
> Krzysztof
>
Konrad Dybcio Nov. 17, 2023, 11:40 p.m. UTC | #3 
On 17.11.2023 13:39, Krzysztof Kozlowski wrote:
> On 17/11/2023 12:46, Sibi Sankar wrote:
>> Hey Krzysztof,
>>
>> Thanks for taking time to review the series.
>>
>> On 11/17/23 16:35, Krzysztof Kozlowski wrote:
>>> On 17/11/2023 11:42, Sibi Sankar wrote:
>>>> Replace SC8380xp with the updated part number (X1E80100).
>>>>
>>>
>>> You need to explain why. We don't update compatibles based on marketing
>>> wishes.
>>
>> What we imply is that X1E80100 is the part number you would get when you
>> read out from a Snapdragon X Elite device in the wild, when it is
>> available and we didn't have this information when we posted out v1.
> 
> The commit msg must explain why.
(what Krzysztof meant is that your explanation is ok but it needs to be
part of the commit message and not just a reply here)

Moreover, it would also be good to say something like "this binding has
no users and has been erroneusly introduced very recently, so it was
decided that changing it is okay", as this is a rather special case.

Konrad