| Message ID | 20231203000532.1290480-1-dmitry.baryshkov@linaro.org |
|---|---|
| Headers | show |
| Series | drm/msm: cleanup private obj handling | expand |
On 12/2/2023 4:05 PM, Dmitry Baryshkov wrote: > Since the commit b962a12050a3 ("drm/atomic: integrate modeset lock with > private objects") the DRM framework no longer requires the external > lock for private objects. Drop the lock, letting the DRM to manage > private object locking. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 8 -------- > drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 - > 2 files changed, 9 deletions(-) > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On 12/2/2023 4:05 PM, Dmitry Baryshkov wrote: > Since the commit b962a12050a3 ("drm/atomic: integrate modeset lock with > private objects") the DRM framework no longer requires the external > lock for private objects. Drop the lock, letting the DRM to manage > private object locking. > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 8 -------- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 1 - > 2 files changed, 9 deletions(-) > Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
On Sun, 03 Dec 2023 03:05:27 +0300, Dmitry Baryshkov wrote: > Note: I'm resending this patch series as I haven't got any feedback from > the drm core maintainers to the first patch. > > While debugging one of the features in DRM/MSM I noticed that MSM > subdrivers still wrap private object access with manual modeset locking. > Since commit b962a12050a3 ("drm/atomic: integrate modeset lock with > private objects") this is no longer required, as the DRM framework > handles private objects internally. Drop these custom locks, while also > cleaning up the surrounding code. > > [...] Applied, thanks! [2/5] drm/msm/dpu: finalise global state object https://gitlab.freedesktop.org/lumag/msm/-/commit/49e27d3c9cd6 [3/5] drm/msm/dpu: drop global_state_lock https://gitlab.freedesktop.org/lumag/msm/-/commit/abbf3108bc63 [4/5] drm/msm/mdp5: migrate SMP dumping to using atomic_print_state https://gitlab.freedesktop.org/lumag/msm/-/commit/f9c27e649a0d [5/5] drm/msm/mdp5: drop global_state_lock https://gitlab.freedesktop.org/lumag/msm/-/commit/ffa0c87f172b Best regards,
Note: I'm resending this patch series as I haven't got any feedback from the drm core maintainers to the first patch. While debugging one of the features in DRM/MSM I noticed that MSM subdrivers still wrap private object access with manual modeset locking. Since commit b962a12050a3 ("drm/atomic: integrate modeset lock with private objects") this is no longer required, as the DRM framework handles private objects internally. Drop these custom locks, while also cleaning up the surrounding code. Dmitry Baryshkov (5): drm/atomic: add private obj state to state dump drm/msm/dpu: finalise global state object drm/msm/dpu: drop global_state_lock drm/msm/mdp5: migrate SMP dumping to using atomic_print_state drm/msm/mdp5: drop global_state_lock drivers/gpu/drm/drm_atomic.c | 9 ++++ drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 14 +++--- drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h | 1 - drivers/gpu/drm/msm/disp/mdp5/mdp5_irq.c | 2 - drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 54 +++++------------------- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.h | 1 - drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.c | 12 +----- drivers/gpu/drm/msm/disp/mdp5/mdp5_smp.h | 4 +- 8 files changed, 31 insertions(+), 66 deletions(-)