| Message ID | 20240212191046.77013-1-danila@jiaxyga.com |
|---|---|
| Headers | show |
| Series | pinctrl: qcom: Add SM8475 support | expand |
On 12/02/2024 20:10, Danila Tikhonov wrote: > Add pll_clk to pin group 98 for compatibility with SM8475. I don't understand this. What compatibility? Is it valid on SM8450? Ifi so, then this would be fix. If not, then you just introduced incorrect group for SM8450 and called it compatibility. > > Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> > --- > drivers/pinctrl/qcom/pinctrl-sm8450.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/qcom/pinctrl-sm8450.c b/drivers/pinctrl/qcom/pinctrl-sm8450.c > index 617286711695..45ac8e72c1c7 100644 > --- a/drivers/pinctrl/qcom/pinctrl-sm8450.c > +++ b/drivers/pinctrl/qcom/pinctrl-sm8450.c > @@ -957,7 +957,7 @@ static const char * const pll_bist_groups[] = { > }; > > static const char * const pll_clk_groups[] = { > - "gpio107", > + "gpio98", "gpio107", Best regards, Krzysztof
After comparing waipio (taro) and cape pinctrl in downstream, I found that these are the only differences. Let's just add this as it shouldn't cause issues on the SM8450 instead of writing a separate driver. To: Bjorn Andersson <andersson@kernel.org> To: Konrad Dybcio <konrad.dybcio@linaro.org> To: Linus Walleij <linus.walleij@linaro.org> To: Rob Herring <robh@kernel.org> To: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> To: Conor Dooley <conor+dt@kernel.org> To: Vinod Koul <vkoul@kernel.org> Cc: linux-arm-msm@vger.kernel.org Cc: linux-gpio@vger.kernel.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Danila Tikhonov <danila@jiaxyga.com> Danila Tikhonov (2): dt-bindings: pinctrl: qcom,sm8450-tlmm: Add compatible for SM8475 pinctrl: qcom: sm8450: Add pll_clk to pin group 98 for SM8475 .../devicetree/bindings/pinctrl/qcom,sm8450-tlmm.yaml | 7 ++++++- drivers/pinctrl/qcom/pinctrl-sm8450.c | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-)