mbox series

[v3,0/2] Enable various remoteprocs for qcm6490-idp and qcs6490-rb3gen2

Message ID 20240417120928.32344-1-quic_kbajaj@quicinc.com
Headers show
Series Enable various remoteprocs for qcm6490-idp and qcs6490-rb3gen2 | expand

Message

Komal Bajaj April 17, 2024, 12:09 p.m. UTC 
Enable various applicable remoteproc nodes for qcm6490-idp
and qcs6490-rb3gen2.

Firmwares are not shared at linux-firmware.git, it is under legal approval process.
Meantime, submitting the DT node changes for FW for review.

--------
Changes in v3:
* Rebased on top of linux-next
* Added firmware path for modem for rb3gen2 board for GPS usecase
* Link to v2: https://lore.kernel.org/all/20240402090349.30172-1-quic_kbajaj@quicinc.com/

Changes in v2:
* Updating the firmware name from mdt to mbn
* Link to v1: https://lore.kernel.org/all/20231220114225.26567-1-quic_kbajaj@quicinc.com/

Komal Bajaj (2):
  arm64: dts: qcom: qcm6490-idp: Enable various remoteprocs
  arm64: dts: qcom: qcs6490-rb3gen2: Enable various remoteprocs

 arch/arm64/boot/dts/qcom/qcm6490-idp.dts     | 20 ++++++++++++++++++++
 arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 10 ++++++++++
 2 files changed, 30 insertions(+)

--
2.42.0

Comments

Dmitry Baryshkov April 17, 2024, 6:25 p.m. UTC | #1 
On Wed, 17 Apr 2024 at 15:11, Komal Bajaj <quic_kbajaj@quicinc.com> wrote:
>
> Enable the ADSP, CDSP, MPSS and WPSS that are found on the SoC.
>
> Signed-off-by: Komal Bajaj <quic_kbajaj@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index f8f8a43f638d..01ea64b16969 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -580,6 +580,26 @@ &qupv3_id_0 {
>         status = "okay";
>  };
>
> +&remoteproc_adsp {
> +       firmware-name = "qcom/qcm6490/adsp.mbn";

Is there a difference between qcm6490 and qcs6490 firmware files? If
there is none, can we use the existing paths?

I assume that modem is the only difference there. In such a case,
please use "modem_nm.mbn" for the not-modem mpss and plain "modem.mbn"
for the standard one.

> +       status = "okay";
> +};
> +
> +&remoteproc_cdsp {
> +       firmware-name = "qcom/qcm6490/cdsp.mbn";
> +       status = "okay";
> +};
> +
> +&remoteproc_mpss {
> +       firmware-name = "qcom/qcm6490/modem.mbn";
> +       status = "okay";
> +};
> +
> +&remoteproc_wpss {
> +       firmware-name = "qcom/qcm6490/wpss.mbn";
> +       status = "okay";
> +};
> +
>  &sdhc_1 {
>         non-removable;
>         no-sd;
> --
> 2.42.0
>
>
Bjorn Andersson April 21, 2024, 10:29 p.m. UTC | #2 
On Wed, 17 Apr 2024 17:39:26 +0530, Komal Bajaj wrote:
> Enable various applicable remoteproc nodes for qcm6490-idp
> and qcs6490-rb3gen2.
> 
> Firmwares are not shared at linux-firmware.git, it is under legal approval process.
> Meantime, submitting the DT node changes for FW for review.
> 
> --------
> Changes in v3:
> * Rebased on top of linux-next
> * Added firmware path for modem for rb3gen2 board for GPS usecase
> * Link to v2: https://lore.kernel.org/all/20240402090349.30172-1-quic_kbajaj@quicinc.com/
> 
> [...]

Applied, thanks!

[1/2] arm64: dts: qcom: qcm6490-idp: Enable various remoteprocs
      commit: 99a1c9eedf6098826c0f9dcbda2c23e5dad20244
[2/2] arm64: dts: qcom: qcs6490-rb3gen2: Enable various remoteprocs
      commit: ac6d35b9b74c113753bd266e01d6b853618a1e37

Best regards,