mbox series

[0/2] media: qcom: camss: manage supply regulators as CSIPHY resources

Message ID 20240926211957.4108692-1-vladimir.zapolskiy@linaro.org
Headers show
Series media: qcom: camss: manage supply regulators as CSIPHY resources | expand

Message

Vladimir Zapolskiy Sept. 26, 2024, 9:19 p.m. UTC 
The change is based on a recent discussion of a changeset, which adds
CAMSS support of Qualcomm SM8550 platform:

  https://lore.kernel.org/all/6d78c1de-00bf-4aea-b0c6-a147faa40a8f@linaro.org/

Regulators shall be managed as CSIPHY resources, while apparently CSID
subdevices can be run with external regulators kept disabled.

Performed regression testing on RB5 successfully, however it might be
important to state that on RB5 board L5A and L9A supplies are always on.

Vladimir Zapolskiy (2):
  media: qcom: camss: add management of supply regulators to CSIPHY
  media: qcom: camss: move sm8250 regulators from CSID to CSIPHY subdevice

 .../media/platform/qcom/camss/camss-csiphy.c  | 35 ++++++++++++++++++-
 .../media/platform/qcom/camss/camss-csiphy.h  |  2 ++
 drivers/media/platform/qcom/camss/camss.c     | 20 +++++------
 3 files changed, 46 insertions(+), 11 deletions(-)

Comments

Bryan O'Donoghue Sept. 26, 2024, 11:31 p.m. UTC | #1 
On 26/09/2024 22:19, Vladimir Zapolskiy wrote:
> The change is based on a recent discussion of a changeset, which adds
> CAMSS support of Qualcomm SM8550 platform:
> 
>    https://lore.kernel.org/all/6d78c1de-00bf-4aea-b0c6-a147faa40a8f@linaro.org/
> 
> Regulators shall be managed as CSIPHY resources, while apparently CSID
> subdevices can be run with external regulators kept disabled.
> 
> Performed regression testing on RB5 successfully, however it might be
> important to state that on RB5 board L5A and L9A supplies are always on.
> 
> Vladimir Zapolskiy (2):
>    media: qcom: camss: add management of supply regulators to CSIPHY
>    media: qcom: camss: move sm8250 regulators from CSID to CSIPHY subdevice
> 
>   .../media/platform/qcom/camss/camss-csiphy.c  | 35 ++++++++++++++++++-
>   .../media/platform/qcom/camss/camss-csiphy.h  |  2 ++
>   drivers/media/platform/qcom/camss/camss.c     | 20 +++++------
>   3 files changed, 46 insertions(+), 11 deletions(-)
> 

This looks pretty good to me. I'll give it a test tomorrow and let you 
know how it goes.

---
bod