mbox series

[v2,0/2] qcom_tzmem: Enhance Error Handling for shmbridge

Message ID 20241014111527.2272428-1-quic_kuldsing@quicinc.com
Headers show
Series qcom_tzmem: Enhance Error Handling for shmbridge | expand

Message

Kuldeep Singh Oct. 14, 2024, 11:15 a.m. UTC
This patchset addresses the tzmem driver probe failure caused by
incorrect error handling. The qcom_scm_shm_bridge_enable() SCM call
captures SCM success/failure in a0 and E_NOT_SUPPORTED in a1.

Previously, qcom_scm returned values based solely on a0, without
capturing not_supported scenario. This patchset corrects that behavior.

Along with this, add sanity checks on input parameters passed to exposed
APIs as it is missing currently.

Changes in v2:
- Restructure qcom_scm_shm_bridge_enable scm return value
- Update commit message
- Keep relevant sanity in qcom_tzmem

v1:
Link: https://lore.kernel.org/linux-arm-msm/20241005140150.4109700-1-quic_kuldsing@quicinc.com/

Kuldeep Singh (1):
  firmware: qcom: qcom_tzmem: Implement sanity checks

Qingqing Zhou (1):
  firmware: qcom: scm: Return -EOPNOTSUPP for unsupported SHM bridge
    enabling

 drivers/firmware/qcom/qcom_scm.c   | 13 ++++++++++++-
 drivers/firmware/qcom/qcom_tzmem.c |  6 ++++++
 2 files changed, 18 insertions(+), 1 deletion(-)