| Message ID | 20241205080633.2623142-1-quic_srichara@quicinc.com |
|---|---|
| Headers | show |
| Series | mailbox: tmelite-qmp: Introduce QCOM TMEL QMP mailbox driver | expand |
On 12/5/2024 5:13 PM, Krzysztof Kozlowski wrote: > On 05/12/2024 10:17, Sricharan Ramabadhran wrote: >> >> >> On 12/5/2024 1:42 PM, Krzysztof Kozlowski wrote: >>> On 05/12/2024 09:06, Sricharan R wrote: >>>> From: Sricharan Ramabadhran <quic_srichara@quicinc.com> >>>> >>>> This binding describes the component responsible for communication >>>> between the TME-L server based subsystems (Q6) and the TME-L client >>>> (APPSS/BTSS/AUDIOSS), used for security services like secure image >>>> authentication, enable/disable efuses, crypto services. Each client >>>> in the SoC has its own block of message RAM and IRQ for communication >>>> with the TME-L SS. The protocol used to communicate in the message RAM >>>> is known as Qualcomm Messaging Protocol (QMP). >>> >>> This is RFC, so only limited review follows. I will review more once >>> this is ready for review. >>> >> Thanks. Once i get the design/approach confirmed, will post the V1. > > Not a v1, but next version. This was v1 already, because we do not count > from 0. Please use b4 to avoid such mistakes. Ok, understand. Regards, Sricharan
From: Sricharan Ramabadhran <quic_srichara@quicinc.com> The QMP mailbox is the primary means of communication between TME-L SS and other subsystem on the SoC. A dedicated pair of inbound and outbound mailboxes is implemented for each subsystem/external execution environment which needs to communicate with TME-L for security services. The inbound mailboxes are used to send IPC requests to TME-L, which are then processed by TME-L firmware and accordingly the responses are sent to the requestor via outbound mailboxes. It is an IPC transport protocol which is light weight and supports a subset of API's. It handles link initialization, negotiation, establishment and communication across client(APPSS/BTSS/AUDIOSS) and server(TME-L SS). ----------------------------------------------- --------------------------------------------------- | | | | | SOC CLIENT | SOC | TME-L SS | | | AHB | | | ---------- --------- --------- | | ------ ------- -------- ------------ | | | | | | | | | WO | | | R | | | | |SERVICES | | | | APPS |<-->| TMEL |<->| |------------->| | IN |-->| | | TMEL | |-------- | | | | | | COM | | QMP | | RO | | | W | QMP |<--->| COM |<-->| a) ATTEST | | | | | | | | |<-------------| | OUT |<--| | | | | b) CRYPTO | | | | | | | | | | | | | | | | | | .. more | | | --------- --------- --------- | | ------ ------- ------- ------------ | | | | | ----------------------------------------------- -------------------------------------------------- TME-L SS provides different kinds of services like secureboot, remote image authentication, key management, crypto, OEM provisioning etc. This patch adds support for remote image authentication. Support for rest of the services can be added. Remote proc driver subscribes to this mailbox and uses the mbox_send_message to use TME-L to securely authenticate/teardown the images. The intention of posting this is to get the design reviewed/corrected since there are also other possible ways of having this SS support like: a) Make TMEL QMP as a 'rpmsg' driver and clients can connect using rmpsg_send b) Keep TMEL APIs seperately in drivers/firmware which would export APIs and QMP mailbox seperately. Clients can then call the exported APIS. c) Combine both TMEL and QMP as mailbox (this is the approach used here) Since clients like same rproc driver use SCM/TMEL across socs, the goal here was to abstract the TMEL-QMP SS functionality, so that clients should be able to connect and send messages with a common API. Based on the feedback can explore any other options as well. Sricharan Ramabadhran (2): dt-bindings: mailbox: Document qcom,tmelite-qmp mailbox: tmelite-qmp: Introduce TMEL QMP mailbox driver .../bindings/mailbox/qcom,tmelite-qmp.yaml | 70 ++ drivers/mailbox/Kconfig | 7 + drivers/mailbox/Makefile | 2 + drivers/mailbox/qcom-tmelite-qmp.c | 949 ++++++++++++++++++ include/linux/mailbox/tmelcom-qmp.h | 157 +++ 5 files changed, 1185 insertions(+) create mode 100644 Documentation/devicetree/bindings/mailbox/qcom,tmelite-qmp.yaml create mode 100644 drivers/mailbox/qcom-tmelite-qmp.c create mode 100644 include/linux/mailbox/tmelcom-qmp.h