| Message ID | 20250301-pocof1-touchscreen-support-v3-0-af01c3b30b55@joelselvaraj.com |
|---|---|
| Headers | show |
| Series | Add Xiaomi Poco F1 touchscreen support | expand |
On Saturday, March 1st, 2025 at 5:43 PM, Joel Selvaraj via B4 Relay <devnull+foss.joelselvaraj.com@kernel.org> wrote: > ...clipped... > Since the touchscreen controller uses almost all the properties present in touchscreen.yaml... Sorry, should have been "Since the edt-ft5x06 touchscreen binding document uses almost all the properties...". I will wait for further review by others and will fix it v4. Or if it is acceptable with current commit message, let me know. Thanks, Joel Selvaraj
In the first patch, I have updated the edt-ft5x06 touchscreen binding documentation. In Xiaomi Poco F1(qcom/sdm845-xiaomi-beryllium-ebbg.dts), the FocalTech FT8719 touchscreen is integrally connected to the display panel (EBBG FT8719) and thus should be power sequenced together with display panel for proper functioning using the panel property. Since the edt-ft5x06 touchscreen binding uses almost all the properties present in touchscreen.yaml, let's remove additionalProperties: false and use unevaluatedProperties to include all the properties, including the needed panel property. In the second patch, I have enabled the qupv3_id_1 and gpi_dma1 as they are required for configuring touchscreen. Also added the pinctrl configurations. These are common for both the Poco F1 Tianma and EBBG panel variant. In the subsequent patches, I have enabled support for the Novatek NT36672a touchscreen and FocalTech FT8719 touchscreen that are used in the Poco F1 Tianma and EBBG panel variant respectively. Signed-off-by: Joel Selvaraj <foss@joelselvaraj.com> --- Changes in v3: - Fix SoB email id mismatch (suggested by Krzysztof Kozlowski) - Use unevaluatedProperties instead additionalProperties in dt-binding (suggested by Krzysztof Kozlowski) - Link to v2: https://lore.kernel.org/r/20241208-pocof1-touchscreen-support-v2-0-5a6e7739ef45@joelselvaraj.com Changes in v2: - Fixed the missing "panel" property dt-binding error reported by Rob Herring's bot. - Change the "input-enable" property to "output-disable" in qcom/sdm845-xiaomi-beryllium-common.dtsi (Based on a patch suggested by Konrad Dybcio). - Link to v1: https://lore.kernel.org/r/20241007-pocof1-touchscreen-support-v1-0-db31b21818c5@joelselvaraj.com --- Joel Selvaraj (4): dt-bindings: input: touchscreen: edt-ft5x06: use unevaluatedProperties arm64: dts: qcom: sdm845-xiaomi-beryllium-common: add touchscreen related nodes arm64: dts: qcom: sdm845-xiaomi-beryllium-tianma: introduce touchscreen support arm64: dts: qcom: sdm845-xiaomi-beryllium-ebbg: introduce touchscreen support .../bindings/input/touchscreen/edt-ft5x06.yaml | 9 +---- .../dts/qcom/sdm845-xiaomi-beryllium-common.dtsi | 39 ++++++++++++++++++++++ .../boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dts | 23 +++++++++++++ .../dts/qcom/sdm845-xiaomi-beryllium-tianma.dts | 23 +++++++++++++ 4 files changed, 86 insertions(+), 8 deletions(-) --- base-commit: c0eb65494e59d9834af7cbad983629e9017b25a1 change-id: 20241007-pocof1-touchscreen-support-c752a162cdc2 Best regards,