mbox series

[0/6] Enable QPIC BAM and QPIC NAND support for SDX75

Message ID 20250313130918.4238-1-quic_kaushalk@quicinc.com
Headers show
Series Enable QPIC BAM and QPIC NAND support for SDX75 | expand

Message

Kaushal Kumar March 13, 2025, 1:09 p.m. UTC 
Hello,

This series adds and enables devicetree nodes for QPIC BAM
and QPIC NAND for Qualcomm SDX75 platform.

This patch series depends on the below patches:
https://lore.kernel.org/linux-spi/20250310120906.1577292-5-quic_mdalam@quicinc.com/T/

Kaushal Kumar (6):
  dt-bindings: mtd: qcom,nandc: Document the SDX75 NAND
  dt-bindings: dma: qcom,bam: Document dma-coherent property
  ARM: dts: qcom: sdx75: Add QPIC BAM support
  ARM: dts: qcom: sdx75: Add QPIC NAND support
  ARM: dts: qcom: sdx75-idp: Enable QPIC BAM support
  ARM: dts: qcom: sdx75-idp: Enable QPIC NAND support

 .../devicetree/bindings/dma/qcom,bam-dma.yaml |  2 +
 .../devicetree/bindings/mtd/qcom,nandc.yaml   | 23 ++++++++---
 arch/arm64/boot/dts/qcom/sdx75-idp.dts        | 18 +++++++++
 arch/arm64/boot/dts/qcom/sdx75.dtsi           | 38 +++++++++++++++++++
 4 files changed, 75 insertions(+), 6 deletions(-)

--
2.17.1

Comments

Konrad Dybcio March 13, 2025, 2:37 p.m. UTC | #1 
On 3/13/25 2:09 PM, Kaushal Kumar wrote:
> Enable QPIC BAM devicetree node for Qualcomm SDX75-IDP board.
> 
> Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com>
> ---

There's not reason for this to be a separate commit

Konrad
Krzysztof Kozlowski March 13, 2025, 2:50 p.m. UTC | #2 
On 13/03/2025 14:09, Kaushal Kumar wrote:
> SDX75 BAM DMA controller has DMA-coherent support so define
> it in the properties section, without which 'dtbs_check'
> reports the following error:
> 
>   controller@1c9c000: 'dma-coherent' does not match any of the
>   regexes: 'pinctrl-[0-9]+'

How can I reproduce it?

> 

Fixes tag?

> Signed-off-by: Kaushal Kumar <quic_kaushalk@quicinc.com>
> ---
>  Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> index 3ad0d9b1fbc5..c4dd6a503964 100644
> --- a/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> +++ b/Documentation/devicetree/bindings/dma/qcom,bam-dma.yaml
> @@ -39,6 +39,8 @@ properties:
>    "#dma-cells":
>      const: 1
>  
> +  dma-coherent: true
> +

Which devices are DMA coherent?


Best regards,
Krzysztof