From patchwork Wed Apr 16 00:02:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Boyd X-Patchwork-Id: 881946 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 843AC2C9D for ; Wed, 16 Apr 2025 00:02:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744761734; cv=none; b=suKXDfbWWsaxZhP1d3Ww6leXlA7tr/QSIcL1Wb2Ycf0YNUK5zGJcZdPWyNuJACr5B/aDxvm0QDSqok3aoW6tEiW3fttflx3A+kQDJfZfitLjcmUiXwEIvrkoon29bHtrfQVN4WLFZAaF/gHAyuX/KnypC8aVblbc9qHaRujUbPY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744761734; c=relaxed/simple; bh=cRmda5bmrfCcBQPE77qN3/UFddHhyZ+FKubxHJT/wkw=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=jsXPDcbKy7LwtHgEqPk2Kj/X5O7R3UVlhpLhS3iBXz79IzQbjTu7mHw60pD510fZV+gGNpLOHhVS0Oj3vDQ6ikl6KvHVymjF8AyqY9aKTdPiov3P9cmQpan4xt8rC0bhx0OGhuxb+Ovfr3N3bZpluY1Z8l+qckZah/MTdUdcv3Q= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=b+IOVZmR; arc=none smtp.client-ip=209.85.216.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="b+IOVZmR" Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-30820167b47so184908a91.0 for ; Tue, 15 Apr 2025 17:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1744761732; x=1745366532; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=bgdhLXqZmm02+iuTYg8IYzdl8VvNi9VMKk7v6vfTzwQ=; b=b+IOVZmRWvXP7dxekykI47UwBU4k+7TRxs43A1LpgzkzUgu0hOsPHKvLmuymkjfdcv ULi4aEc+wIZO2orJE97BGh8QVRIFCtb1DJ5PTT1EnqEVYZAR8hxKDASF1dxYqfHAauZ5 cGPM/kcAoII60f0Et8CN+OFstOcHsX5uKQ1nM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744761732; x=1745366532; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bgdhLXqZmm02+iuTYg8IYzdl8VvNi9VMKk7v6vfTzwQ=; b=B7MJGjCbGvjSyayJ8KfesMxWNsyBUvgUDS44aQbKwF77g1wU4wNApa4PsPwMElSS8X gQie04B1RRmb+ZAuERtVcbt45IWrXpwXJEyiJwnG7R2fdIFFnWhRQaD8l+7jauxxoF8z FJjeUCjXMgMpd74P2rpGDVv8v05cvZV/q7CDSb4Rq2Ty6uJCyCFYVMJwnqx3nczuMJ5x rOVgelwmzaiwxFfiW/gfMLETuT9WZvsxDPxDETz8yiCxEzrqdlTT3aID5+ZdRLLSOJak SV08eJLWR/SzXRXlFzLjzM2SYbPNlJzIfpBiZ7ZC/ZjwSzFSIZbJKY+dvV1dCMDBoVRV NhvQ== X-Forwarded-Encrypted: i=1; AJvYcCW7U/UUU/ffCI39bggWQelpByG74fe7bdb6BHx8ben3YqDcGrPJOiosc3rJCs2QMrdBGnCBJsjLrXffkvrU@vger.kernel.org X-Gm-Message-State: AOJu0YyX9W0rB++4uK7RNTbQ2akJf01SUFQ23uYuyYoQoTAPN7nidqgw +47hotuvvAqInTk9NNPW/FTWd+MKPHnV3aL+ta/ORQ500/Si78oCWbT5fTIvZA== X-Gm-Gg: ASbGncvurSXtgqeIcY15G9178w/ShyGqYODMGnbQ8fwK1kOLl8PWtXpaJSddclP8pRC QDX5r1gcMSpTUr9GvD1k2nH0nbBztxOolNZOKgVcBSsKosMgV7zoXoJZlDJAIF7Btl3F80nvKtc 8LL0V/C3VBDGUbnHvDOLL5FzQQ7Ql3O/BOH1eegvfOZKtvkPxeeua99e3JdlhvAu86sLhfAnc4e 2H67PlqpoIwpZl7fPa/4n+5fEnXvtOY8248+vVlYhjKpxlnNiBCRjKpSI63zAbdHdRRGu7sgQYK LtAPJWL5Q6WXYlPDqDh9RGpTvHzk7TEfwol0EjWAGByiFZjQ58uGpX0GmwRjs9q02hn2fwZLVd8 XNg== X-Google-Smtp-Source: AGHT+IEW2BUyetqEJqp2Byr5gKAPoyPMy/3pBAQDFJR2uAF5E8DZzaAi+L5qSZqV09GCAbzUezOZCQ== X-Received: by 2002:a17:90b:5243:b0:2fa:2268:1af4 with SMTP id 98e67ed59e1d1-3084f3176d1mr7881903a91.7.1744761731705; Tue, 15 Apr 2025 17:02:11 -0700 (PDT) Received: from localhost (199.24.125.34.bc.googleusercontent.com. [34.125.24.199]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-308613b3849sm196226a91.38.2025.04.15.17.02.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Apr 2025 17:02:11 -0700 (PDT) From: Stephen Boyd To: Tzung-Bi Shih Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev, Bjorn Andersson , Konrad Dybcio , devicetree@vger.kernel.org, Dmitry Baryshkov , Krzysztof Kozlowski , Rob Herring , linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Conor Dooley , Benson Leung , chrome-platform@lists.linux.dev, Pin-yen Lin , Abhishek Pandit-Subedi , =?utf-8?q?=C5=81ukasz?= =?utf-8?q?_Bartosik?= , Jameson Thies , Andrei Kuchynski Subject: [PATCH 0/7] platform/chrome: Support for USB DP altmode muxing w/ DT Date: Tue, 15 Apr 2025 17:02:00 -0700 Message-ID: <20250416000208.3568635-1-swboyd@chromium.org> X-Mailer: git-send-email 2.49.0.604.gff1f9ca942-goog Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 This is a continuation of an earlier series[1] split out to become more manageable. After discussions at LPC2024 with Dmitry, I've settled on using the DisplayPort altmode driver to signal HPD to the DP controller through the out of band API. This series patches up the ChromeOS EC driver enough to the point that Chromebooks that use EC driven entry can bind the DP altmode driver (CONFIG_TYPEC_DP_ALTMODE) and signal the HPD state to the drm_connector. The first few patches make the DP altmode driver work on Trogdor and other EC mode entry based Chromebooks. The next couple patches add support to the cros-ec-typec binding to describe the DP graph connections between the DP controller and the DP altmode. I chose to put the graph into the altmode node, but I suspect it can just as easily be added to the usb-c-connector graph as another port or endpoint within the port@1 if we want to keep it close to the SuperSpeed endpoint. The final patches support creating a drm_bridge in the cros-ec-typec driver. They workaround a problem on Trogdor where HPD doesn't signal properly so we have to capture the HPD signal from the upstream drm_bridge and inject it into the USB type-c framework. We will pretty much only use this bridge on Trogdor where we're steering the DP lanes from the EC. With this series the USB type-c sysfs entries reflect the state of the port when the DP altmode driver binds. Trying to control the mode from the sysfs entries doesn't really work because the EC is in control and most writes are blocked if they try to exit DP altmode for example. There's still one part left though; finding the drm_connector from the DP altmode driver. The way that the binding is written for the Corsola case where a four lane DP bridge is hard-wired to two USB-C connectors requires more work, but we're pretty much setup to tackle the problem even on Trogdor with this proposed binding. I'm imagining in the Corsola scenario the DP chip has a binding like this: it6505 { ports { port@0 { }; // input port from MIPI DSI port@1 { // output port for DP dp_ml0_1: endpoint@0 { // output port for DP lanes ML0/1 data-lanes = <0 1>; remote-endpoint = <&usbc0_dp>; }; dp_ml2_3: endpoint@1 { // output port for DP lanes ML2/3 data-lanes = <2 3>; remote-endpoint = <&usbc1_dp>; }; }; }; cros-ec { typec { connector@0 { altmodes { displayport { port { usbc0_dp: endpoint { remote-endpoint = <&dp_ml0_1>; }; }; }; }; }; connector@1 { altmodes { displayport { port { usbc1_dp: endpoint { remote-endpoint = <&dp_ml2_3>; }; }; }; }; }; }; }; We'll need to implement a drm_bridge in the connector's altmode node that can be connected to the dp_ml0_1 or dp_ml2_3 endpoint. That final drm_bridge that lives in the DP altmode driver needs to be implemented on top of this series[2] that supports hotpluggable DRM bridges. If we do that we can hotplug the it6505 bridge and the usb-c-connector bridge when DP altmode is entered on the port. We'll also be able to easily associate the drm_connector with the usb-c connector because the bridge will be implemented there. Once we do that it should be possible to get rid of the out of band HPD API and signal HPD state from the drm_bridge created in the DP altmode driver while hotplugging the bridge chain upon DP altmode entry. [1] https://lore.kernel.org/r/20240901040658.157425-1-swboyd@chromium.org [2] https://lore.kernel.org/r/20250206-hotplug-drm-bridge-v6-0-9d6f2c9c3058@bootlin.com Cc: Benson Leung Cc: Tzung-Bi Shih Cc: Cc: Pin-yen Lin Cc: Abhishek Pandit-Subedi Cc: Łukasz Bartosik Cc: Jameson Thies Cc: Andrei Kuchynski Stephen Boyd (7): platform/chrome: cros_ec_typec: No pending status means attention platform/chrome: cros_ec_typec: Allow DP configure to work platform/chrome: cros_ec_typec: Support EC mode entry dt-bindings: Move google,cros-ec-typec binding to usb dt-bindings: usb: google,cros-ec-typec: Add ports for DP altmode platform/chrome: cros_ec_typec: Add support for DP altmode via drm_bridge platform/chrome: cros_ec_typec: Support DP muxing .../bindings/chrome/google,cros-ec-typec.yaml | 66 ----- .../bindings/connector/usb-connector.yaml | 6 + .../bindings/mfd/google,cros-ec.yaml | 7 +- .../bindings/usb/google,cros-ec-typec.yaml | 231 ++++++++++++++++++ drivers/platform/chrome/Kconfig | 1 + drivers/platform/chrome/cros_ec_typec.c | 167 ++++++++++++- drivers/platform/chrome/cros_ec_typec.h | 21 ++ drivers/platform/chrome/cros_typec_altmode.c | 121 +++++---- 8 files changed, 508 insertions(+), 112 deletions(-) delete mode 100644 Documentation/devicetree/bindings/chrome/google,cros-ec-typec.yaml create mode 100644 Documentation/devicetree/bindings/usb/google,cros-ec-typec.yaml base-commit: 2014c95afecee3e76ca4a56956a936e23283f05b