| Message ID | 20250527111227.2318021-1-quic_pkumpatl@quicinc.com |
|---|---|
| Headers | show |
| Series | Enable audio on qcs6490-RB3Gen2 and qcm6490-idp boards | expand |
On 5/27/25 1:12 PM, Prasad Kumpatla wrote: > From: Mohammad Rafi Shaik <quic_mohs@quicinc.com> > > Modify and enable WSA, VA, RX and TX lpass macros and lpass_tlmm clock > settings. For audioreach solution mclk, npl and fsgen clocks are enabled > through the q6prm clock driver. > > For qcs6490 RX drives clk from TX CORE which is mandated from DSP side, > Unlike dedicated core clocks. Core TX clk is used for both RX and > WSA as per DSP recommendations. > > Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> > Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com> > Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
On 5/27/2025 5:30 PM, Krzysztof Kozlowski wrote: > On 27/05/2025 13:12, Prasad Kumpatla wrote: >> From: Mohammad Rafi Shaik <quic_mohs@quicinc.com> >> >> Add the sound card node with tested playback over WSA8835 speakers >> and digital on-board mics. >> >> Signed-off-by: Mohammad Rafi Shaik <quic_mohs@quicinc.com> >> Co-developed-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com> >> Signed-off-by: Prasad Kumpatla <quic_pkumpatl@quicinc.com> >> Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> >> --- >> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 45 ++++++++++++++++++++ >> 1 file changed, 45 insertions(+) > > > Don't add one-node per patch. Add entire sound for this board. Ack, Will takecare in upcoming platforms. Thanks, Prasad> > Best regards, > Krzysztof
From: Mohammad Rafi Shaik <quic_mohs@quicinc.com> Audio support is now enabled on the qcs6490-RB3Gen2 and qcm6490-idp boards. The updates include adding the necessary audio device tree support and the required dependencies. Both the qcs6490-RB3Gen2 and qcm6490-idp boards are derived from the same SoC platform. Therefore, the audio support changes are included in a single patch set for consistency and ease of maintenance. Changes in [v4]: - Fix DT binding errors by adding dt-binding clock changes for ADSP base platform. - Link to V3 : https://lore.kernel.org/linux-arm-msm/20250520062618.2765109-1-quic_pkumpatl@quicinc.com/ Changes in [v3]: - Added protection-domain in gpr services. - Addressed the review commnets from Konrad Dybcio. - Fix DT binding errors reported by Rob Herring. - Link to V2 : https://lore.kernel.org/linux-arm-msm/20250429092430.21477-1-quic_pkumpatl@quicinc.com/ Changes in [v2]: - Created dtsi file to handle common audio nodes to support Audioreach. - Addressed the review comments. - Link to V1 : https://lore.kernel.org/linux-arm-msm/20250317054151.6095-2-quic_pkumpatl@quicinc.com/ Mohammad Rafi Shaik (8): arm64: dts: qcom: qcs6490-audioreach: Add gpr node ASoC: dt-bindings: qcom: Manage clock settings for ADSP solution arm64: dts: qcom: sc7280: Add WSA SoundWire and LPASS support arm64: dts: qcom: qcs6490-audioreach: Modify LPASS macros clock settings for audioreach arm64: dts: qcom: qcs6490-rb3gen2: Add WSA8830 speakers amplifier arm64: dts: qcom: qcs6490-rb3gen2: Add sound card arm64: dts: qcom: qcm6490-idp: Add WSA8830 speakers and WCD9370 headset codec arm64: dts: qcom: qcm6490-idp: Add sound card .../qcom,sc7280-lpass-lpi-pinctrl.yaml | 10 + .../bindings/sound/qcom,lpass-va-macro.yaml | 12 +- .../bindings/sound/qcom,lpass-wsa-macro.yaml | 24 ++- arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 180 ++++++++++++++++++ .../boot/dts/qcom/qcs6490-audioreach.dtsi | 158 +++++++++++++++ arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 80 ++++++++ arch/arm64/boot/dts/qcom/sc7280.dtsi | 78 +++++++- 7 files changed, 535 insertions(+), 7 deletions(-) create mode 100644 arch/arm64/boot/dts/qcom/qcs6490-audioreach.dtsi base-commit: 176e917e010cb7dcc605f11d2bc33f304292482b