mbox series

[v8,0/5] Enable IPQ5332 USB2

Message ID cover.1691999761.git.quic_varada@quicinc.com
Headers show
Series Enable IPQ5332 USB2 | expand

Message

Varadarajan Narayanan Aug. 14, 2023, 8:06 a.m. UTC 
This patch series adds the relevant phy and controller
configurations for enabling USB2 on IPQ5332

v8:
	Driver:-
		Change commit subject and message per review comments
		Don't include of_platform.h
		Change struct initialization coding style
		GENMASK -> BIT for one of the defines
v7:
	Binding:-
		Move 'compatible' to be the first entry
		In the example have 'usb-phy' instead of 'usb2-phy'
		Add 'Reviewed-by: Krzysztof Kozlowski'
v6:
	Binding and dts:-
		Dropped the qcom,dwc3.yaml patch as it has been picked up for linux-next
		Add const to compatible, vdd-supply
		Move nodes per register address
	Driver:-
		Add vdd-supply
		Cleanup error paths in probe with dev_err_probe
v5:
	Binding and dts:-
		Fix email id
		Removed 'Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>'
		as had to change bindings file to be able to use generic phy instead of
		usb-phy

	Driver:-
		Remove unused definition
		Use generic phy instead of usb-phy
v4:
	Binding and dts:-
		Change node name (bindings & dts)
	Driver:-
		Remove unused enum
		static const for '.data'
		Error handling for devm_clk_get
v3:
	Fix bindings file based on review comments

v1:
	Cleanup DTS
	Combine driver, kconfig and makefile patches
	Remove unused functions from M31 driver
	Drop the clock driver changes

Varadarajan Narayanan (5):
  dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
  phy: qcom: Introduce M31 USB PHY driver
  arm64: dts: qcom: ipq5332: Add USB related nodes
  arm64: dts: qcom: ipq5332: Enable USB
  arm64: defconfig: Enable M31 USB phy driver

 .../bindings/phy/qcom,ipq5332-usb-hsphy.yaml       |  59 +++++
 arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts        |  23 ++
 arch/arm64/boot/dts/qcom/ipq5332.dtsi              |  55 ++++
 arch/arm64/configs/defconfig                       |   1 +
 drivers/phy/qualcomm/Kconfig                       |  11 +
 drivers/phy/qualcomm/Makefile                      |   1 +
 drivers/phy/qualcomm/phy-qcom-m31.c                | 294 +++++++++++++++++++++
 7 files changed, 444 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
 create mode 100644 drivers/phy/qualcomm/phy-qcom-m31.c

Comments

Vinod Koul Aug. 17, 2023, 9:55 a.m. UTC | #1 
On Mon, 14 Aug 2023 13:36:00 +0530, Varadarajan Narayanan wrote:
> This patch series adds the relevant phy and controller
> configurations for enabling USB2 on IPQ5332
> 
> v8:
> 	Driver:-
> 		Change commit subject and message per review comments
> 		Don't include of_platform.h
> 		Change struct initialization coding style
> 		GENMASK -> BIT for one of the defines
> v7:
> 	Binding:-
> 		Move 'compatible' to be the first entry
> 		In the example have 'usb-phy' instead of 'usb2-phy'
> 		Add 'Reviewed-by: Krzysztof Kozlowski'
> v6:
> 	Binding and dts:-
> 		Dropped the qcom,dwc3.yaml patch as it has been picked up for linux-next
> 		Add const to compatible, vdd-supply
> 		Move nodes per register address
> 	Driver:-
> 		Add vdd-supply
> 		Cleanup error paths in probe with dev_err_probe
> v5:
> 	Binding and dts:-
> 		Fix email id
> 		Removed 'Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>'
> 		as had to change bindings file to be able to use generic phy instead of
> 		usb-phy
> 
> [...]

Applied, thanks!

[1/5] dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
      commit: b11f8acb937ed64841eeba22b0f0371ded58bef2
[2/5] phy: qcom: Introduce M31 USB PHY driver
      commit: 9bc2b3b35334aa2742ad3dc4219c001279a97998

Best regards,