From patchwork Tue Nov 26 15:34:37 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Georgi Djakov X-Patchwork-Id: 180213 Delivered-To: patch@linaro.org Received: by 2002:a92:38d5:0:0:0:0:0 with SMTP id g82csp4794329ilf; Tue, 26 Nov 2019 07:34:43 -0800 (PST) X-Google-Smtp-Source: APXvYqxjMD8r7jsH+x/wN6B0Xt8TaOADXgofHHkUz1smsbeQNtgL0QjV5iZ1AW0MB5MAo7Pkl3ag X-Received: by 2002:a05:6402:602:: with SMTP id n2mr26636922edv.23.1574782482987; Tue, 26 Nov 2019 07:34:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1574782482; cv=none; d=google.com; s=arc-20160816; b=YdCxQnteRy3Gr89THuoZ6CoKeNh4mBPOVNSUZzwV4hk5pa5eeXeLjt7KUxTzScuMXZ ykvYKo+GBhZB/wgpFBhYIamscsTsEH+OAbHb3jULAT+lz55ZKG5GI6fsxvbWbZFbIa/v Q2lg1z/9LCoXDvXvIk6gUBhiHd+5KTaizzHP7a/25WIxMft8dq7EWYHQUx2mUalr8WCE RMxlob+FtUpfxwM9mAtFTUUGJPRTZs58meuOAEYl3AifAqca6EXt886TTqF3fIF5rVxS 4p2/pL8YiTKAe4muYjPr9Ba4fYbQruTV4aZoB0JpyvOM3BV4mbrrDvyll4bZKXhn2EWO VHkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=XHpKE1+pRggjDZg3Vcgn+vzDPH0txuMe168rRQcCK68=; b=E+zWsjgeG8SnHnGtEYukq/ULAoKgXyEfdCDMJqOw0CrC4zdTj2O77mCFOXMiKdmvlH TWn/Dp+v6Mz7i5eNUk9wR0FVQsVjgvKkT5PYRC9WXqZ6bo6JfPV6pijtyoGeJcloGX/G RWYTok2qCgvGWejwUjM1wRhxNzW/TFyUC2915/uX47zjEVUMxczchEFFC2cge3Qhz+m9 go9n0aiuT71SJtdP3mjxOV7Mraw7+gDrvVQChc8Lbk1wBvfGHiM34eZQzYPMMWM9yEwq /SWhXkLckTP6+xQ7pcYLP9pxqUFfGsg2DX9GGnWjcnKG284OdRgIw/6oM40FaO3U+d8L d2+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w864Jom6; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id qw26si7355411ejb.103.2019.11.26.07.34.41; Tue, 26 Nov 2019 07:34:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=w864Jom6; spf=pass (google.com: best guess record for domain of linux-arm-msm-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-arm-msm-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727600AbfKZPel (ORCPT + 15 others); Tue, 26 Nov 2019 10:34:41 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:55976 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727135AbfKZPel (ORCPT ); Tue, 26 Nov 2019 10:34:41 -0500 Received: by mail-wm1-f66.google.com with SMTP id b11so3657482wmb.5 for ; Tue, 26 Nov 2019 07:34:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XHpKE1+pRggjDZg3Vcgn+vzDPH0txuMe168rRQcCK68=; b=w864Jom6wGOmf6sK60smmKGgc+SuwnyTekrouut8YkgOdmKIfioXo3WWtSDucAjPNR WYKH+7MhO2oaQ9OqDIvgWkjg0gy/lDu2VqmCi1+47V3irPn/aerma/cNc+OgLkYbpTyH CK7aZ5jQxixxxlW8zjdxfFjho+2+qTp5vmCBmWo0zLC5A1qdhl2zdj8AnrzS/LUQjeJn d+DDxvSktWFPp/y1YVj/1M1uMqwu9eGg16S8p9ywtgFt4VUup4/ERB5fMdSXrSn88XF5 uigHb9uV0hTG3cpI79vb1GnmTXZPwgXeyH3d0RvNJaMIS299a/Jqhh4kKigHioRL0uY5 U9Yg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=XHpKE1+pRggjDZg3Vcgn+vzDPH0txuMe168rRQcCK68=; b=ZLgAzACe+ar3EKkMu28qrj3LwryxuThnoQvU+HcYD7Yh8XLzuw4QCYcyHC8V4MUiVA 8wIq3Z7q53C9ZXjHVMBdCYAOQIGWSFy8p/NtVibNMevvLLSqgHdr6g8wFxVH2nUkGdtq nc1iqm8p2SBWK3UGeL0TNCheI5g1N2hVw4J+Ju3OUm+1XeekKUZct2yqOMIRd8UoP8Rl aEzuXLXXinS48fyraqPDygl+PthOHiWz9D3Tmta1XWSMAwdapoMCiRzCCsnjiOyhHgf8 Har/YtdY+7iGZdWRE5GvagS5sayYPlNtYY1zihllcRs1j7vHGfMUx+9j1BW8K4fd5jB3 0fiA== X-Gm-Message-State: APjAAAUMcQhnI8QayoTgdSpIpVnUy91KfpZ0eSnyoeLXJcEs2O3xaLNW 1/FJb3uocyLFdxsiAHtIGO8VFw== X-Received: by 2002:a1c:6144:: with SMTP id v65mr5025056wmb.53.1574782479214; Tue, 26 Nov 2019 07:34:39 -0800 (PST) Received: from localhost.localdomain ([212.45.67.2]) by smtp.googlemail.com with ESMTPSA id j10sm15210748wrx.30.2019.11.26.07.34.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 26 Nov 2019 07:34:38 -0800 (PST) From: Georgi Djakov To: sboyd@kernel.org, bjorn.andersson@linaro.org, robdclark@gmail.com Cc: mturquette@baylibre.com, agross@kernel.org, tdas@codeaurora.org, anischal@codeaurora.org, linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, georgi.djakov@linaro.org Subject: [PATCH] clk: qcom: gcc-sdm845: Add missing flag to votable GDSCs Date: Tue, 26 Nov 2019 17:34:37 +0200 Message-Id: <20191126153437.11808-1-georgi.djakov@linaro.org> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On sdm845 devices, during boot we see the following warnings (unless we have added 'pd_ignore_unused' to the kernel command line): hlos1_vote_mmnoc_mmu_tbu_sf_gdsc status stuck at 'on' hlos1_vote_mmnoc_mmu_tbu_hf1_gdsc status stuck at 'on' hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc status stuck at 'on' hlos1_vote_aggre_noc_mmu_tbu2_gdsc status stuck at 'on' hlos1_vote_aggre_noc_mmu_tbu1_gdsc status stuck at 'on' hlos1_vote_aggre_noc_mmu_pcie_tbu_gdsc status stuck at 'on' hlos1_vote_aggre_noc_mmu_audio_tbu_gdsc status stuck at 'on' As the name of these GDSCs suggests, they are "votable" and in downstream DT, they all have the property "qcom,no-status-check-on-disable", which means that we should not poll the status bit when we disable them. Luckily the VOTABLE flag already exists and it does exactly what we need, so let's make use of it to make the warnings disappear. Fixes: 06391eddb60a ("clk: qcom: Add Global Clock controller (GCC) driver for SDM845") Reported-by: Rob Clark Signed-off-by: Georgi Djakov --- drivers/clk/qcom/gcc-sdm845.c | 7 +++++++ 1 file changed, 7 insertions(+) Tested-by: Rob Clark diff --git a/drivers/clk/qcom/gcc-sdm845.c b/drivers/clk/qcom/gcc-sdm845.c index 95be125c3bdd..56d22dd225c9 100644 --- a/drivers/clk/qcom/gcc-sdm845.c +++ b/drivers/clk/qcom/gcc-sdm845.c @@ -3255,6 +3255,7 @@ static struct gdsc hlos1_vote_aggre_noc_mmu_audio_tbu_gdsc = { .name = "hlos1_vote_aggre_noc_mmu_audio_tbu_gdsc", }, .pwrsts = PWRSTS_OFF_ON, + .flags = VOTABLE, }; static struct gdsc hlos1_vote_aggre_noc_mmu_pcie_tbu_gdsc = { @@ -3263,6 +3264,7 @@ static struct gdsc hlos1_vote_aggre_noc_mmu_pcie_tbu_gdsc = { .name = "hlos1_vote_aggre_noc_mmu_pcie_tbu_gdsc", }, .pwrsts = PWRSTS_OFF_ON, + .flags = VOTABLE, }; static struct gdsc hlos1_vote_aggre_noc_mmu_tbu1_gdsc = { @@ -3271,6 +3273,7 @@ static struct gdsc hlos1_vote_aggre_noc_mmu_tbu1_gdsc = { .name = "hlos1_vote_aggre_noc_mmu_tbu1_gdsc", }, .pwrsts = PWRSTS_OFF_ON, + .flags = VOTABLE, }; static struct gdsc hlos1_vote_aggre_noc_mmu_tbu2_gdsc = { @@ -3279,6 +3282,7 @@ static struct gdsc hlos1_vote_aggre_noc_mmu_tbu2_gdsc = { .name = "hlos1_vote_aggre_noc_mmu_tbu2_gdsc", }, .pwrsts = PWRSTS_OFF_ON, + .flags = VOTABLE, }; static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc = { @@ -3287,6 +3291,7 @@ static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc = { .name = "hlos1_vote_mmnoc_mmu_tbu_hf0_gdsc", }, .pwrsts = PWRSTS_OFF_ON, + .flags = VOTABLE, }; static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf1_gdsc = { @@ -3295,6 +3300,7 @@ static struct gdsc hlos1_vote_mmnoc_mmu_tbu_hf1_gdsc = { .name = "hlos1_vote_mmnoc_mmu_tbu_hf1_gdsc", }, .pwrsts = PWRSTS_OFF_ON, + .flags = VOTABLE, }; static struct gdsc hlos1_vote_mmnoc_mmu_tbu_sf_gdsc = { @@ -3303,6 +3309,7 @@ static struct gdsc hlos1_vote_mmnoc_mmu_tbu_sf_gdsc = { .name = "hlos1_vote_mmnoc_mmu_tbu_sf_gdsc", }, .pwrsts = PWRSTS_OFF_ON, + .flags = VOTABLE, }; static struct clk_regmap *gcc_sdm845_clocks[] = {