diff mbox series

[8/8] arm64: defconfig: Enable IPQ5424 SoC base configs

Message ID 20240913121250.2995351-9-quic_srichara@quicinc.com
State Superseded
Headers show
Series Add minimal boot support for IPQ5424 | expand

Commit Message

Sricharan Ramabadhran Sept. 13, 2024, 12:12 p.m. UTC 
From: Sricharan Ramabadhran <quic_srichara@quicinc.com>

Enable the clock and pinctrl configs for Qualcomm IPQ5332 SoC

Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
---
 arch/arm64/configs/defconfig | 2 ++
 1 file changed, 2 insertions(+)

Comments

Sricharan Ramabadhran Sept. 25, 2024, 7:04 p.m. UTC | #1 
On 9/13/2024 6:23 PM, Dmitry Baryshkov wrote:
> On Fri, Sep 13, 2024 at 05:42:50PM GMT, Sricharan R wrote:
>> From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
>>
>> Enable the clock and pinctrl configs for Qualcomm IPQ5332 SoC
> 
> Please name the device rather than the platform. The defconfig affects
> all users, so it should be justified.
> 
Sorry, to understand correctly, you mean to use the board name here ?

>>
>> Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
>> Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> 
> Usual comment.
ok, will fix.

Regards,
  Sricharan
Dmitry Baryshkov Sept. 25, 2024, 9:31 p.m. UTC | #2 
On Thu, Sep 26, 2024 at 12:34:56AM GMT, Sricharan Ramabadhran wrote:
> 
> 
> On 9/13/2024 6:23 PM, Dmitry Baryshkov wrote:
> > On Fri, Sep 13, 2024 at 05:42:50PM GMT, Sricharan R wrote:
> > > From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> > > 
> > > Enable the clock and pinctrl configs for Qualcomm IPQ5332 SoC
> > 
> > Please name the device rather than the platform. The defconfig affects
> > all users, so it should be justified.
> > 
> Sorry, to understand correctly, you mean to use the board name here ?

Yes, the board which is generally accessible, if possible. You are
increasing kernel size for everybody using defconfig, so at least it
should be obvious, who is benefiting from that.

> 
> > > 
> > > Signed-off-by: Varadarajan Narayanan <quic_varada@quicinc.com>
> > > Signed-off-by: Sricharan Ramabadhran <quic_srichara@quicinc.com>
> > 
> > Usual comment.
> ok, will fix.
> 
> Regards,
>  Sricharan
Sricharan Ramabadhran Sept. 26, 2024, 7:14 a.m. UTC | #3 
On 9/26/2024 3:01 AM, Dmitry Baryshkov wrote:
> On Thu, Sep 26, 2024 at 12:34:56AM GMT, Sricharan Ramabadhran wrote:
>>
>>
>> On 9/13/2024 6:23 PM, Dmitry Baryshkov wrote:
>>> On Fri, Sep 13, 2024 at 05:42:50PM GMT, Sricharan R wrote:
>>>> From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
>>>>
>>>> Enable the clock and pinctrl configs for Qualcomm IPQ5332 SoC
>>>
>>> Please name the device rather than the platform. The defconfig affects
>>> all users, so it should be justified.
>>>
>> Sorry, to understand correctly, you mean to use the board name here ?
> 
> Yes, the board which is generally accessible, if possible. You are
> increasing kernel size for everybody using defconfig, so at least it
> should be obvious, who is benefiting from that.
> 

ok, will fix subject description accordingly.

Regards,
  Sricharan
diff mbox series

Patch

diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
index 81ca46e3ab4b..f1043a40846a 100644
--- a/arch/arm64/configs/defconfig
+++ b/arch/arm64/configs/defconfig
@@ -595,6 +595,7 @@  CONFIG_PINCTRL_IMX93=y
 CONFIG_PINCTRL_MSM=y
 CONFIG_PINCTRL_IPQ5018=y
 CONFIG_PINCTRL_IPQ5332=y
+CONFIG_PINCTRL_IPQ5424=y
 CONFIG_PINCTRL_IPQ8074=y
 CONFIG_PINCTRL_IPQ6018=y
 CONFIG_PINCTRL_IPQ9574=y
@@ -1304,6 +1305,7 @@  CONFIG_IPQ_APSS_6018=y
 CONFIG_IPQ_APSS_5018=y
 CONFIG_IPQ_GCC_5018=y
 CONFIG_IPQ_GCC_5332=y
+CONFIG_IPQ_GCC_5424=y
 CONFIG_IPQ_GCC_6018=y
 CONFIG_IPQ_GCC_8074=y
 CONFIG_IPQ_GCC_9574=y