| Message ID | 20241003215746.275349-6-rosenp@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | devicetree: move nvmem-cells users to nvmem-layout | expand |
On Thu, 03 Oct 2024 14:57:46 -0700, Rosen Penev wrote: > nvmem-cells are deprecated and replaced with nvmem-layout. For these > examples, replace. They're not relevant to the main point of the > document anyway. > > Signed-off-by: Rosen Penev <rosenp@gmail.com> > --- > .../mtd/partitions/qcom,smem-part.yaml | 19 +++++++++++-------- > .../bindings/net/marvell,aquantia.yaml | 13 ++++++++----- > 2 files changed, 19 insertions(+), 13 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/net/marvell,aquantia.example.dts:59.25-26 syntax error FATAL ERROR: Unable to parse input tree make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/net/marvell,aquantia.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2 make: *** [Makefile:224: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241003215746.275349-6-rosenp@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
diff --git a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml index 1c2b4e780ca9..8ae149534b23 100644 --- a/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml +++ b/Documentation/devicetree/bindings/mtd/partitions/qcom,smem-part.yaml @@ -45,17 +45,20 @@ examples: compatible = "qcom,smem-part"; partition-art { - compatible = "nvmem-cells"; - #address-cells = <1>; - #size-cells = <1>; label = "0:art"; - macaddr_art_0: macaddr@0 { - reg = <0x0 0x6>; - }; + nvmem-layout { + compatible = "fixed-layout"; + #address-cells = <1>; + #size-cells = <1>; + + macaddr_art_0: macaddr@0 { + reg = <0x0 0x6>; + }; - macaddr_art_6: macaddr@6 { - reg = <0x6 0x6>; + macaddr_art_6: macaddr@6 { + reg = <0x6 0x6>; + }; }; }; }; diff --git a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml index 9854fab4c4db..f57a6e7d0049 100644 --- a/Documentation/devicetree/bindings/net/marvell,aquantia.yaml +++ b/Documentation/devicetree/bindings/net/marvell,aquantia.yaml @@ -98,15 +98,18 @@ examples: /* ... */ partition@650000 { - compatible = "nvmem-cells"; label = "0:ethphyfw"; reg = <0x650000 0x80000>; read-only; - #address-cells = <1>; - #size-cells = <1>; - aqr_fw: aqr_fw@0 { - reg = <0x0 0x5f42a>; + nvmem-layout { + compatible = "fixed-layout" + #address-cells = <1>; + #size-cells = <1>; + + aqr_fw: aqr_fw@0 { + reg = <0x0 0x5f42a>; + }; }; };
nvmem-cells are deprecated and replaced with nvmem-layout. For these examples, replace. They're not relevant to the main point of the document anyway. Signed-off-by: Rosen Penev <rosenp@gmail.com> --- .../mtd/partitions/qcom,smem-part.yaml | 19 +++++++++++-------- .../bindings/net/marvell,aquantia.yaml | 13 ++++++++----- 2 files changed, 19 insertions(+), 13 deletions(-)