From patchwork Wed Feb 5 00:58:25 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peng Fan X-Patchwork-Id: 862630 Received: from PA4PR04CU001.outbound.protection.outlook.com (mail-francecentralazon11013050.outbound.protection.outlook.com [40.107.162.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4C83228385; Wed, 5 Feb 2025 00:59:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.162.50 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717182; cv=fail; b=O0myGGLfvVM+SBjZ82Bi9MbDzNqL8eYnBdsa2lel9FTK9cFlOoRzfbfFkaHKucYW9MfPNDusl6c/yaLgl5iGjXvSnVI+bVEKGDC8CiwRMGg7Lths+5eWUL6mrB2z4f5sdTqQ9HHhI2Sa763N+w2Pmn7vHS6Zn9QpLFIwj3RF2V4= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738717182; c=relaxed/simple; bh=AcWk+DTl4vJlEoX1Fz1L2UUCItL1uFcWaPK5Bz+U1lU=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kv2FOJjOlXEqJT4KNPxkZtIx/D9PXL+lan8H/riTgSV2SCA/zeEoBO7YilMY3VV9UWMJFAa/7wB/OlKXWjJoQNPbzEQjJ/GG6wnsUb8P31c4AEY6vk4e/x/k5ci1JFKGUPATNLnCKuX/vdlcrQMs3FDzjAxZm0/yb+Za6Q56yFc= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=xehDLvqm; arc=fail smtp.client-ip=40.107.162.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="xehDLvqm" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=NKAoflszZ7mlKl9PYHCgJY6OEDFp91cFt7//ipvC6nMo0K5WrAhVVg1db7OAjcqkHXHOjKSUGvxasdBoVi222Ff2tCoFnGZHR5LMeX+l1krQsXEfcwulh4v4sLlE2lA9wmchZdwZHHz/XkYADOILAdx5REpdtj5Nd9J5/oegjpChv8hZ7aXep8mileT31UmoovwSEGyqlCM3OA7++OQRpZ9YfplaaS7ioZp7WHImZAa+qS4nQ4rUpYLhRLikVivSkuuygs6dTEteacL8DTD2h2/0vSa3NZzWPyFQIP3TB9lUf3V54EcjikTIdknrKuvCJDZKPmR0I8S1IfVZgZROAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EwjZqLy9UAzAbl6jmLkoboiwEpYZWe0ARcy3BM/gy6g=; b=Iu7LzleXyPFTpA9pxajroIpa81mSuuKH6SWK35k61tWXeuB06gTi7EMZnmwTmMwRf3JNIN958e9nkmKE6125GmRPoCIscg+Utttte2KR1qpNTQqK1u/Bmn4nFFG8pmmkrFlO8By2BTQS9PJwqGYD6NC2zm7ut5XRACSX4zFx0dA1wqNZDNHF2ZP5BYWlW9GsqQB0/c10rQmzmfh2SE+EYTRaTVY8T9VSbpy0WhxYn7StF32LvREuai7yuPaCAaQWFm8mwzoGVxLBIrKEOnYignuk+kUB9JJ7CYMcT9JbHw3J6/JAK1gFyf6p/KX5UH7uQw7wHP5fKAyCsqqulRLKEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EwjZqLy9UAzAbl6jmLkoboiwEpYZWe0ARcy3BM/gy6g=; b=xehDLvqmOSYIWp59xODlz9s8xncr3v2CW4nz7PWrlcpSP0DgWSRC+d3PlXFADPlpLy7/v95oK4HJyVJcWE6gVcnAtICeYHhi6085fnpzX8E8g6gBDes9eV8F5wXDArdKR9TZsXkdIj4oyHu++ij20MbzOLRg4Dgp7aIgoUPBpJn4L4o9MVwrpTzxvwU9DYA+89DGSz+8YkhPeiLyZ2HSBb42ZNWFUYu38pdPN5sSdQHGV4lrbxG5pSYPUF83tEPWEuiHyU+K/qyn2g/4ayHojdEVXf3q2AZYaxBwRs3frS1WAvzr7UaoADYFisDxXrAcyzFhxsvYRDnMcIsPPyoe/g== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:37 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:37 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:25 +0800 Subject: [PATCH 7/7] rtc: pl031: Use resource managed API to simplify code Message-Id: <20250205-rtc-cleanup-v1-7-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1457; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=836X+TA/l2wfm7yon8oTf/+NEC4So+0tkKKh8ZKoqD0=; b=8b+RiW38bzcj7vW9C3nT/sXnco85VHDgcMhjl+0oTU3U8lRGFu1FS0OqHTfe7FEm8pMc6TD6S CcnR0JtCPB9Bg8e17MVnczKMvC1sDBxLvXZuA57wbWLOBQLeV5v1DtW X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 793ddd20-9a38-46cc-7474-08dd45805c9e X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?w9+YTbqn4IyU9Vl3B1oPLFGMByu4Auy?= =?utf-8?q?cmyrXZOHyMynAFZ3d1IFm8LQVWxFFtHsW7egrajWoQxcQc54zsSKDNY83WkEfw+W0?= =?utf-8?q?6QuyyXWDHjfBntCPVv+nkxkWCOyFL9E10NlZDf3laTJbtVXsofxSbApvvj7QVA4+A?= =?utf-8?q?RC63idePwbNCn/yhjBTWJgR7sWedvgSf2a7hI+vcgFHGWmicyxSVbdFHiuBxUkkaY?= =?utf-8?q?vx4MZjEMPR/cikzdlHzGrQF0cHSvNFzTzFAkkbgfsH8Co+KeTjqCBqxiO325BL9Dc?= =?utf-8?q?/Spvgb0CTPMjubpmHItiYTAkt+2ECzric7ew/17jejehYajEMOsoNFi0Mlcwk94H9?= =?utf-8?q?UmtAaNK9rrxAd72qfJIApr6MalUehOWHzrFVe9TA9/kGRVq3lozkseqkH3TSkxLNk?= =?utf-8?q?KExClgM9OYOCsXr6zkHrV90T28VLBGR5b0cLlAGjg/NdR+qpcK5MIDXzBj1Olyrun?= =?utf-8?q?s0rZ95R/TWXaQdvMZiHZPLvB7Lq/FK7iCO5x6vpPysDqH7EN8xhr1Jr3FpbbGffci?= =?utf-8?q?yCFG/CuxrtmDl43pBOb7dRUohaLxHsanJD1nAJTR0//7GZZrOlsfARnZiz801MLEM?= =?utf-8?q?pnCuc/VhRLF55IkRQacZlQRocFVuyzqd+7GgbUvszMJLIbfNv7PGFzcjG+g3I5+3m?= =?utf-8?q?ID6rbQm3V5QCLE8jxUi4cvc1BtmNVmxxnimpk2fXFL7dYyIQccWr+gVj6suezwMTR?= =?utf-8?q?q5Zp3VyxoM03/SJxKRQhR361k1yfkUlrHbvwcrTgWFMZrsvz9VA9k73C+/pYQgl/o?= =?utf-8?q?D/fqyt6nSGozkakwucsO4O7oYz5JWUSlMw2q4IWmGbHlTfYcICXwltkzq1Czp/4Fh?= =?utf-8?q?i8TekFy2qDdG8ljRwI/BkxAFdBQl7BFSIcE4wYBy36ywtY06GorMTjbbs2+DUeWVI?= =?utf-8?q?CyCQe/memun/s4kCufORkYgaHxNSEEdlbspnghWARgsoj2qK+1R/bcKKWVorMX+dF?= =?utf-8?q?kGQn7dS6fEdpvUkz2Ayb4jKICMH/wCACICXmcRlhTZfMIQBcUfJDG/4ibYnG0J0Yj?= =?utf-8?q?k3ETsDLjZYjQOh8bQ2JA5OaCt/uhk7T50Eg1mg1AkD5i9bg2ieo1VKyp2SKe3Fwb1?= =?utf-8?q?Oglju8su/ES4glill28yGAFImtq6sSwVJ7ZG+t0eREQnLYMzwShgVnB3eMHiCRxac?= =?utf-8?q?fTfo4+Vn3DLUyiu0dp0EjXuaIHKtZbG4UoQYE2IC0DRlAQ11zSSC8DQRBAgcC+GHT?= =?utf-8?q?tp9IW8awyvbVn29IwljhoRXzM244BlgmaZRJki/be0QdsoX3HumbZdaVQp4ShTlT8?= =?utf-8?q?YWDsbYwBs0Xvc2bcx/1+47u4WvsYW1U14jEalERcmwbvTDq8PkhOMLJN+yjFmsF9t?= =?utf-8?q?nwlYcQPrdhE/CXpPPlyCwADnhIJRG5oyJQ8EIQPxS9u4AcjFsetIYdDDRfFzMgMVx?= =?utf-8?q?2n6Y3cIW5bC?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PAXPR04MB8459.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?arH817r6/3CQWYFMdZsCiKGNPobt?= =?utf-8?q?hu7ywStJbazpAAYMPq5R91puBw/JXqMPJ0AbagUVj2gawKByXkecUVF+NkfDifbiT?= =?utf-8?q?A56jbJDcRxo5bZV49WNi72UuLe4xEZ9EDVh3S65WIamJWX/vsX5QK/CsFOhIOs+ed?= =?utf-8?q?w2ZfOWc+39DeLkbNbZaYX2tBiv6tUEsv6UIKQiEVO+cmS9uLubg56dykBU2sT94mC?= =?utf-8?q?b0AAhm7QuVg2xXxEQnMpuVji4SuFNUxOg/vB1ZeRkK46hFhHBwUl515206+L+PMDT?= =?utf-8?q?F8ctdDRYcK4+I1WFgoktCHyx4ooVLau6Z9puRytVzbVnu8jfrI2+905fYKvxtyFD9?= =?utf-8?q?3rYjkS/dHaSxQNhIM6hvTd0THETrQ7GCmA7R0AVdlUWscJ3CS2nbCAjFockAUiadq?= =?utf-8?q?DdX9k1AOmd10HeyJauWqT+zj5C1QEngBPVKWJZI9zRxE/4CpCmAI54rL7y+7PnmMe?= =?utf-8?q?kMmHbENerSFyR2bdAOo5fBwo/ZWQfQcss+eCLT5rvvkTx3ni+x+8RjitkXFouL7DQ?= =?utf-8?q?fu5BIah8j0yVDDWVEBJDmAFXuV6xVEDF0x9YycpdFCG2yzZbQSBJdZI3H0y7Gj9gc?= =?utf-8?q?l5wdaxXKGeIc1+4wZ5J8bMS2yiCxMAO5W/S8WFBxoLJGqfzaId1mMDWK2HC26+nAa?= =?utf-8?q?uztHkUEizBAYf1DBe0ESvFn/b0a5gaTXdHtQYw0S8DqfQ4TA2cWbNd85cp15SoLoy?= =?utf-8?q?VNXimonoya+9ZlplYTRoNzi+NegxzOtHHcXA1BP155jvhcDXKFnMsmZ/mUiWYv0Hs?= =?utf-8?q?bq5UcYjEtv5hDAEsh/CMYhW08JcsE1FXiRjseZ84f7rO4NU6C7KDuRnsklfsuQriD?= =?utf-8?q?r9yc3VER74SmDa/2Opc6Pdqy5CpCOM539PCX4Ru27yzKAClZrjY4Y50iXNdOHJ7Tu?= =?utf-8?q?s8jW2+nukoIQ/aYgLqLx5HgcLvzM67fyuyr9CziwH6VKxsHkFYpxbqaL2iY7+fvPK?= =?utf-8?q?cEvmJgh22mLx+3LIRu62mmU0OaBkfymEWdbjRSAj2AY5t+alRzZMd0ZwKB6FvPxDd?= =?utf-8?q?q82HUCJq5dkt3hj6irDfnqBHcTkbypctP5z+qZtIKMItoWyvAkhvnmShsnoPh2P+n?= =?utf-8?q?blIPQcnCXvaNAwfvhbkoDIjvpFw09Dyzj2UWxkC4h16RTXUCXS/IxvXHrZhA0Hzg3?= =?utf-8?q?QSaFCkfDbZmb9LftBa5PMxtQreHafG4T1mAeqhxY/xHwn8UeG0Nc29ayVTBDWGqTq?= =?utf-8?q?zc45m/DdHuxGt9IYKon+HUKC5Z29ClIH4P5i19ZPvcIk0OJPTfzzemqhGWqMoQ1TC?= =?utf-8?q?zb5ei4oFEq+Tyr/GDfnuHvRsdUVpcKGTIRbnf05I3e8PCbw2Hz+ZDT9wCD0kmw50u?= =?utf-8?q?1tCO5mBMnjnIEN9inqAsRslDcWHjtm9M9Kz1OEXwTNtV0xEgb7VUMVANRiMeVC4zq?= =?utf-8?q?XYWj/nebK28iQu1WAvgXzGkJX5qMOMNoUfz4ExWoIln0DnS1djc6Y+24KABwur7kp?= =?utf-8?q?sFj9R/HV6TSAJqCljE/P2XlYbHdGpTgF9UkZah7SlNmVgxQM07mf3e1JLy8xLZ/s2?= =?utf-8?q?j1BI55eJsv7l?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 793ddd20-9a38-46cc-7474-08dd45805c9e X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:36.9576 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2oPoxj+HRZgTo9C3XvebIy33LXIv+qsbQEPWs3oi2EnamYs+w73SWn3eqvWRDfveyM3wqXzBRRv4+6LlAn/9EA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Reviewed-by: Linus Walleij Signed-off-by: Peng Fan --- drivers/rtc/rtc-pl031.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/rtc/rtc-pl031.c b/drivers/rtc/rtc-pl031.c index bad6a5d9c6839ca70905e3d46286b9729c1fd435..47bfc5395e5908b7722b98276399120f1ba65af0 100644 --- a/drivers/rtc/rtc-pl031.c +++ b/drivers/rtc/rtc-pl031.c @@ -284,8 +284,6 @@ static void pl031_remove(struct amba_device *adev) { struct pl031_local *ldata = dev_get_drvdata(&adev->dev); - dev_pm_clear_wake_irq(&adev->dev); - device_init_wakeup(&adev->dev, false); if (adev->irq[0]) free_irq(adev->irq[0], ldata); amba_release_regions(adev); @@ -350,7 +348,7 @@ static int pl031_probe(struct amba_device *adev, const struct amba_id *id) } } - device_init_wakeup(&adev->dev, true); + devm_device_init_wakeup(&adev->dev); ldata->rtc = devm_rtc_allocate_device(&adev->dev); if (IS_ERR(ldata->rtc)) { ret = PTR_ERR(ldata->rtc); @@ -373,7 +371,7 @@ static int pl031_probe(struct amba_device *adev, const struct amba_id *id) vendor->irqflags, "rtc-pl031", ldata); if (ret) goto out; - dev_pm_set_wake_irq(&adev->dev, adev->irq[0]); + devm_pm_set_wake_irq(&adev->dev, adev->irq[0]); } return 0;