From patchwork Sat Mar 1 09:24:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dmitry Baryshkov X-Patchwork-Id: 869602 Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99C641DA10C for ; Sat, 1 Mar 2025 09:25:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740821115; cv=none; b=JZbtvtFuofYDV3KcGqxtp8e4ShVhRgEAsJEKlAEYj32i5K+TPBwf/PgNqT1JPUyHu7eZxdtVXT66H7JnK4IkzVrpyqVn3s6bqCUECasql1nuhFSQM2r7tanw5tJ4plrDfynbHnTVc/JhFtIM1uz/N0HUPHvmVVvN/+mv/nZ9Hl0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740821115; c=relaxed/simple; bh=xfJndy0LJ6tSYaPs6OPWvlHfde8Gt+RzIdnKqXQJW2A=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=tKvGbdmMoyTX2cfMJg/WkV5JGVotAG2ikHCTsvqlbs0Sab8au/yA6S69i8BmL1dSyGZ5yuJmRb6XsErVLFBGQ7xo0oQXJLYA07dvrEp0CvV/3qVop00cphoT3dLi4+bi2DJVfTUh4qp0OGTPm2mSr9RXAbt0gO4jafR+de6WDC4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rHxHPpTC; arc=none smtp.client-ip=209.85.208.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rHxHPpTC" Received: by mail-lj1-f171.google.com with SMTP id 38308e7fff4ca-30795988ebeso31669421fa.3 for ; Sat, 01 Mar 2025 01:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1740821112; x=1741425912; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=URwOcNjnz6PkMJ2QDjvaSLAsGLbSDP+kGsc1C7zaZt0=; b=rHxHPpTClM80Lh9L6ITu3fEew97kuaagqOFH1oAZQRx/t9pY7/wdphPV7e3DxySAd6 O2LDHa/akoZRVYnhQlOXhZAhxIFiiQExr1W+im8FNNFoFDimvFZewLrDKeJST497w6VN 0ouWAJU2KCeC4JToHPLxEdXsrnd6v3wRvtB4yagN9bEf3Dg8HC8Y8rDDCuoMWfP4YP5l XCO7GESFcqgLkfHrorBHxTnVD+dEomOIKLJ2a/DE1mlixs8OSRPF8O+VE6sFJuVnX0T1 EKkdxid9pKzO+gnqbfwGAtFo8YClInodsGos4SZJeb2LZ+/AmDDUUxqm4Wpeh2VzBe0u TLwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740821112; x=1741425912; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=URwOcNjnz6PkMJ2QDjvaSLAsGLbSDP+kGsc1C7zaZt0=; b=f3/dJH4Jx3yBXiDiArEkemqNjo5i0peLTqmZrmgEPodQu/INoxUp9czeaBxpwdaItc HYTu/aN3UCLPseeQSSgH3nGwUHQgfZuaLsugYbDFEmWr+HiZzQ+j9lTrFYP1F5RFX27n zyycCbkDWrALly+GKSuR6N/QMejQ4IN/nIFtBzZpyMQyivrQGMfrvDTQEJRkAlsgsnkU 0O5y4uYaX/5LtcAxQqRXTLfPIQQROmT1ugJOsJlrs09eqp8g7f2O++jRpzEX+xPVlTfh KXiIKmme5cOhO82xFMcB3Euau+ikaw27CTeWrtAo3eSijZYWZL5oNxs/jwbSMiVZGvKs F1vw== X-Gm-Message-State: AOJu0YwRP3fW4t7pP8MELdH2yMdePugQZB8R+Gp6sflrzmZCDzQISChe nmrjav66PJYFCc6un1sPwMg3yflrQscIHx+2duN5//cV5zUUqgGtcD5e9JUXecw= X-Gm-Gg: ASbGnctAle+xVt2Bs1ohoueAGr1/Yg8HuME99a5DyBLOJIGLIACnij1SQLdQL3/LRSQ pg/i21JP2aWJClh2Ip9gQxSd71rJzHTCDRs/wWKioey+oZXh4bp+5G3D7vRCQkeRnbPVEekDYRC WOZmwcVQvwK5iWc4lpwV4J80m51vPtPzUCBK8CFJ2dEkx62ylFqmXPqV4dnTsut7NGfkCGkYBme sjDmphJOx/6w0ELvIib16Ndb6gszd+VXtjFblN2eiVlkStcY24/J0KL1wcCiScXtIOPE7I/XiAX vt1Vn84ritDVdBhGKrufCq2h+FPtZJXPzJ/HJkxn4ZRTSJDlSSom X-Google-Smtp-Source: AGHT+IEh8A2sl1pAlOlMCHBvb8v6txd7ryhkeXioo/K+sIwr784pk95XMok+4SarSyMfmUmdP9cUsw== X-Received: by 2002:a05:6512:128e:b0:545:9e4:ca91 with SMTP id 2adb3069b0e04-5494c38072bmr2929372e87.39.1740821111736; Sat, 01 Mar 2025 01:25:11 -0800 (PST) Received: from umbar.lan ([192.130.178.90]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5494417432csm738406e87.52.2025.03.01.01.25.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Mar 2025 01:25:10 -0800 (PST) From: Dmitry Baryshkov Date: Sat, 01 Mar 2025 11:24:58 +0200 Subject: [PATCH v2 5/5] drm/msm/dpu: remove DSC feature bit for PINGPONG on SDM630 Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250301-dpu-fix-catalog-v2-5-498271be8b50@linaro.org> References: <20250301-dpu-fix-catalog-v2-0-498271be8b50@linaro.org> In-Reply-To: <20250301-dpu-fix-catalog-v2-0-498271be8b50@linaro.org> To: Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , =?utf-8?b?QmFybmFiw6FzIEN6w6ltw6Fu?= , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1811; i=dmitry.baryshkov@linaro.org; h=from:subject:message-id; bh=xfJndy0LJ6tSYaPs6OPWvlHfde8Gt+RzIdnKqXQJW2A=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBnwtJouDh1p63euLoMf/eO1Aa1kaVi4m9jHe64K bORUvpxw0GJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ8LSaAAKCRCLPIo+Aiko 1Q2wB/9+J8HcIzLcD4Z54mCSlyjwkQ3C2RZjJ0uAwHKstzXjx0uAq015I1fXZN787warvOm3j3L ig0302evj00WTzKaZrN10rzDnrgNK02AHwxv8GzoFst4YwaX6cEHT+KdUdURGSwS9ZTrJiTxTLw mxpz/opigMTdni3hSRSAGrPYop6rS3y8nVJ4FaFfXPptbG/RBr0iOlIfL8rgqK6DWb0bw7vYMJm xlMPF66WvRaTDGCudXLahAGjGqT4ggHR+p03OVjhQdOyCGRscvTvI7Q3JwqN09qFwJSKR/+y78n vU7sLNkNz1VHMK+BKtoWqHFza6tec6uBRWhHiKh9KtHSCX/W X-Developer-Key: i=dmitry.baryshkov@linaro.org; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A The SDM630 platform doesn't have DSC blocks nor does have it DSC registers in the PINGPONG block. Drop the DPU_PINGPONG_DSC feature bit from the PINGPONG's feature mask, replacing PINGPONG_SDM845_MASK with BIT(DPU_PINGPONG_DITHER). Fixes: 7204df5e7e68 ("drm/msm/dpu: add support for SDM660 and SDM630 platforms") Reported-by: Abhinav Kumar Signed-off-by: Dmitry Baryshkov --- Note, Konrad pointed out that vendor DT doesn't define DIPTHER support for this platform, however I believe this is because support for this platform predates DITHER support in the vendor kernels. --- drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h index 3aed9aa4c533f167ece7b4a5eb84fe49c4929df5..99c0f824d8f00474812bde12e7d83ba3de1834f1 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_3_3_sdm630.h @@ -115,14 +115,14 @@ static const struct dpu_pingpong_cfg sdm630_pp[] = { { .name = "pingpong_0", .id = PINGPONG_0, .base = 0x70000, .len = 0xd4, - .features = PINGPONG_SDM845_MASK, + .features = BIT(DPU_PINGPONG_DITHER), .sblk = &sdm845_pp_sblk, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 8), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 12), }, { .name = "pingpong_2", .id = PINGPONG_2, .base = 0x71000, .len = 0xd4, - .features = PINGPONG_SDM845_MASK, + .features = BIT(DPU_PINGPONG_DITHER), .sblk = &sdm845_pp_sblk, .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 10), .intr_rdptr = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 14),