From patchwork Wed Jun 11 13:33:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fuad Tabba X-Patchwork-Id: 896720 Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB5CF29AB16 for ; Wed, 11 Jun 2025 13:33:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.73 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749648827; cv=none; b=kPAAf57EfYcAr9OvdD3G6GXGxvEZkqF5+8P2MDAMJG9+3Wx9xgZMrUTvsk57AU1azguHAObCdlti3GOAuxWRjYHzYj4AwaCDNth6+Sp15NfEeKBbSHcBVKACYyoPKZZNfAO7c69uTnbvVgG+FOzsC3NV0EEHPT8YI/woWkVO0z8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749648827; c=relaxed/simple; bh=YGKWeS/02fp1ZvntQjnXiLE+15TL6ZwC9xQKq/URy3c=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=SbYwvwuoNiEwfFe71j3umuGKJt/bDe4SnxibKxC7QxHDs0eOVCgt5FesuX1h8j7j4TSZIzSBhmdKqPAWIY6Cqg0xlqunEbrgl3NGJokfUb2JHMK1+t2y8/WFWUDh5z2V1VbLUkIF/PdM98FpFTJZZfRfakgTeJF/VifYMlMcxfk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--tabba.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=ggIFgvgt; arc=none smtp.client-ip=209.85.128.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--tabba.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ggIFgvgt" Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4530c186394so16831405e9.0 for ; Wed, 11 Jun 2025 06:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1749648824; x=1750253624; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8aR8d2ohKDYUtwqlUQwft9/8cX0oCVtZ+VCOgpKfhcs=; b=ggIFgvgtb0U3D2aPVezV0lZEo6adA196EhwOLmg1ftZzOtcL46leWZnpKHPIHy4Sv/ quem/WtKwy49sROiAupVA2x/tO5VCWDn+SxfeKrF9zZ0zVtjXoPT7ROgPRcX/vfo6320 dpdJRfuScJl9lwGj+V/xyOrzQ6lQ8EdP6MN+suRNzYGmq7uOkRWcyaLjtLjVDkBNyAIV xN15cuiiJIhqmIqhs7vu2ZmBgBXJYw9h2r7WK9lSNetK27ZIZQ6qs2LZd7NZ888PFZai +NWxVYnPzaPMdfPLdxLwNrlmagvB/OpnwQiwhAo9+8nB1mke2DQgCQSB8XftUmsROYL7 OEyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749648824; x=1750253624; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8aR8d2ohKDYUtwqlUQwft9/8cX0oCVtZ+VCOgpKfhcs=; b=F1qYdqKt2MYCy7ZjhE14p31enpAHGEDuBs4fr2hH93NFrUvAJ7dSGnEyujpPz3uNHM r9ebX8zXWDAAzJL0PuJSECLMhelQzNM10Bqdb7aYbPB6sc8QZnIAa5OrO4HCz2WUwyWw ml8oNFCUPS+f+2HGE54wXpZWFIyFrLfn4uT6JIMucRZ8S4RguKbPrVzqoiaFGDiZpwfI OVh8FrKCVulp9AoIFv5Q0LopUGsBy+yIzbPZNHoERCCZK0y/Q17R67HHtwpDt2P6tga6 VqO6JCGo0KzeIgVPr58Au0x3FlUEx1ZXJy83+su6lW2S1pTUpv7l5PSxMIEmHAMdRWBr to/Q== X-Forwarded-Encrypted: i=1; AJvYcCVS2PyoqvWsaMTwAwE7vE/g7efImFUbNPT4qWYa9mAa4gHEvPJxpCnm6NLWL+RWSS1B2xrNG/Hy1xcr4P8n@vger.kernel.org X-Gm-Message-State: AOJu0Yy2ZEuqWTM2Yoi92x2chOhg7bFfWE43MIiq+8h9ljB474PD+9uK DCCMQAl4IynCpvjAbib4ZxAqyjB/AbzSjSYc94q8VZtyNHHzeQbic5nzg6DT6vNV6Q23C3omIv8 SsA== X-Google-Smtp-Source: AGHT+IFCb8jHeuPCB7LEmI7avFCyTPGfgQduPiszdiF9PVCb/8oC0jpiLuFzDzkO8e+SWuappNsS6C6Y4A== X-Received: from wmbez14.prod.google.com ([2002:a05:600c:83ce:b0:450:d422:69f9]) (user=tabba job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:3b9b:b0:44a:b9e4:4e6f with SMTP id 5b1f17b1804b1-4532956d50bmr9767915e9.16.1749648824195; Wed, 11 Jun 2025 06:33:44 -0700 (PDT) Date: Wed, 11 Jun 2025 14:33:18 +0100 In-Reply-To: <20250611133330.1514028-1-tabba@google.com> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20250611133330.1514028-1-tabba@google.com> X-Mailer: git-send-email 2.50.0.rc0.642.g800a2b2222-goog Message-ID: <20250611133330.1514028-7-tabba@google.com> Subject: [PATCH v12 06/18] KVM: Fix comments that refer to slots_lock From: Fuad Tabba To: kvm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-mm@kvack.org, kvmarm@lists.linux.dev Cc: pbonzini@redhat.com, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, seanjc@google.com, viro@zeniv.linux.org.uk, brauner@kernel.org, willy@infradead.org, akpm@linux-foundation.org, xiaoyao.li@intel.com, yilun.xu@intel.com, chao.p.peng@linux.intel.com, jarkko@kernel.org, amoorthy@google.com, dmatlack@google.com, isaku.yamahata@intel.com, mic@digikod.net, vbabka@suse.cz, vannapurve@google.com, ackerleytng@google.com, mail@maciej.szmigiero.name, david@redhat.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com, suzuki.poulose@arm.com, steven.price@arm.com, quic_eberman@quicinc.com, quic_mnalajal@quicinc.com, quic_tsoni@quicinc.com, quic_svaddagi@quicinc.com, quic_cvanscha@quicinc.com, quic_pderrin@quicinc.com, quic_pheragu@quicinc.com, catalin.marinas@arm.com, james.morse@arm.com, yuzenghui@huawei.com, oliver.upton@linux.dev, maz@kernel.org, will@kernel.org, qperret@google.com, keirf@google.com, roypat@amazon.co.uk, shuah@kernel.org, hch@infradead.org, jgg@nvidia.com, rientjes@google.com, jhubbard@nvidia.com, fvdl@google.com, hughd@google.com, jthoughton@google.com, peterx@redhat.com, pankaj.gupta@amd.com, ira.weiny@intel.com, tabba@google.com Fix comments so that they refer to slots_lock instead of slots_locks (remove trailing s). Reviewed-by: David Hildenbrand Reviewed-by: Ira Weiny Reviewed-by: Gavin Shan Reviewed-by: Shivank Garg Reviewed-by: Vlastimil Babka Signed-off-by: Fuad Tabba --- include/linux/kvm_host.h | 2 +- virt/kvm/kvm_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h index 76b85099da99..aec8e4182a65 100644 --- a/include/linux/kvm_host.h +++ b/include/linux/kvm_host.h @@ -859,7 +859,7 @@ struct kvm { struct notifier_block pm_notifier; #endif #ifdef CONFIG_KVM_GENERIC_MEMORY_ATTRIBUTES - /* Protected by slots_locks (for writes) and RCU (for reads) */ + /* Protected by slots_lock (for writes) and RCU (for reads) */ struct xarray mem_attr_array; #endif char stats_id[KVM_STATS_NAME_SIZE]; diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index 6efbea208fa6..d41bcc6a78b0 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -331,7 +331,7 @@ void kvm_flush_remote_tlbs_memslot(struct kvm *kvm, * All current use cases for flushing the TLBs for a specific memslot * are related to dirty logging, and many do the TLB flush out of * mmu_lock. The interaction between the various operations on memslot - * must be serialized by slots_locks to ensure the TLB flush from one + * must be serialized by slots_lock to ensure the TLB flush from one * operation is observed by any other operation on the same memslot. */ lockdep_assert_held(&kvm->slots_lock);