From patchwork Mon Jun 16 15:29:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 897602 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C825259C85 for ; Mon, 16 Jun 2025 15:29:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750087764; cv=none; b=rMEi64XFHXhevYxu3aMN41N6YWlOyJWFs3R1nS+222wF00vCUwxz+TdTjyqfzJdUjcZn2jHxOjgA74zoDVJT+6vwlAKeGZVERzkvdWXSDrINg+Z3XX/dHeantLHbUVjDgVDlkfVyZwZvEjyYL0Fc7j4pcJFNhaSyT1aFYvtnK0c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750087764; c=relaxed/simple; bh=nJe/rCU0mM1LK6ZhEfAvqmM6ue4Q9Vd6jDTW9fx9UlI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=ju3/9afS3ITZ65961aU+HjN9w3/4VdEbS5uQBtURmdgE4fCaMBbSDYUVLFlMRRvBbjc3mtG1uJC9VDE9FeZFDS0Ha4FHogfCHCk2uo3F2+h6WeEMqFpMr86AyTDxBkdy5a9zx5DYTdpW8IGq14rttufTjXKbuet0YclpyHKWtEA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Fntgc+a8; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Fntgc+a8" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-553bcba4ff8so1602872e87.2 for ; Mon, 16 Jun 2025 08:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1750087760; x=1750692560; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=tU/MOIKq84YnAfhWoL4YWtwA5Rdh3uTG/Wp8rz5grc0=; b=Fntgc+a8z5geufgs8sQoEQbGb/K+59HnfptcsL0592AYayiLkVrWQw75I19JSwYuN5 kY3NRTR5wCMKwcXdDiQPmUp/Q8uDOsc+kp63l8Axa6LLPTR/eItMX3RHFcN9PkaiEDJ1 erZdXwV8uzT0z+h8MZ1otW4QkQnIb3UvjI/2Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750087760; x=1750692560; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tU/MOIKq84YnAfhWoL4YWtwA5Rdh3uTG/Wp8rz5grc0=; b=AaJJCVEXzLu/mSScyUavIfvYqy++XH4IMxXO6ObCxyGvyzA9zwM3dwOxF2HX01AV6i I5pNVONh4P/dg8/ZpN+peQbto5nhpBvY0vcOT8cdC4m9PqCyNG+CjXlAoV2DqNeLfsMR Jf5l+iXF0SghzngVlCez4erkUgWs4s1VALDz2tzYQXiJZq2Zfb5CXMCOhXqmP8ebJT+D CflZlCL5xDHnihiOT7N1XHqIVdNxUrheUxjablpt1RGmp+jIYf6OnJFL69fADBafReBD 8bLaMc3u8jpGRYCkdj0bWG0W6qoGCCKVL3kKQEeg/6otr1YsXer6x1Q/XCUuwHtN5d6J zlLg== X-Forwarded-Encrypted: i=1; AJvYcCXTWeKqVNnXYPGECLUKk8ER/+MnFVIFV3Pf5BzbdO5ISFD8Wd0xgyfCfoPI7FJ1/fFjXkLJA9qDNuJhlni+@vger.kernel.org X-Gm-Message-State: AOJu0YzZwC3Tq/EkW0Gt3ylGS5qe7zA/fgtOKI5ZLEN4X9DNpJvFpBmf EOmAfqZ+Dous2n3ZIae7XjRkGnzFN0CAnykxFGVM3w6BSI11qav1qoTnMuxKVg/S+A== X-Gm-Gg: ASbGnctk7kt5EkWCV94qRY1vNAtHZMfwxhP4DTTNwgVvfXcCl0LDCqZYQ7BJamqTehe w7qtNJkdM3Ew9LkSjXFI4nUM5fdUNJa78BwyrCHN4HbbmLRJzXeHfzfBq9CVMngdxwv1kf56UOO 4Tzfm6q6gz2/10Y4jyC57ItP/nye1bLL/nE7xl+I2vhVSLPk1uhwCqPOM7SNLEORJ3umO1d7xwC R27IeozbrE7UW5VAz03YP6Cy1Z8dIlmAgjIAkx5+noWSCA0spllhv/YZN0bEahDXyAjjARrs/WX Xxjfyo1oKat+t41PQeLCiSpuv0hVsBhYgk9fTki43o8LoT9NF9ZxF+5sQ38YGJsoTwFrKrOXk/K NGnVukAELGY2IqT9EcUFHEK8IPytVoo9ekWBYHr9OQ7aKY6ECt8K1 X-Google-Smtp-Source: AGHT+IF9Hd3Wtj66G1qTf/FKk0SD1/kjIqCqNtZy8C7aM1FLVNBfFTvcQ0578pGYNs8i7deIw2reqQ== X-Received: by 2002:a05:6512:b0a:b0:54f:bce6:63bd with SMTP id 2adb3069b0e04-553b6f62293mr2330891e87.54.1750087760319; Mon, 16 Jun 2025 08:29:20 -0700 (PDT) Received: from ribalda.c.googlers.com (166.141.88.34.bc.googleusercontent.com. [34.88.141.166]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-553ac11ff5dsm1568020e87.31.2025.06.16.08.29.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jun 2025 08:29:20 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 16 Jun 2025 15:29:17 +0000 Subject: [PATCH v7 4/5] media: venus: venc: Make the range of us_per_frame explicit Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250616-test-v7-4-b8c0f98494fa@chromium.org> References: <20250616-test-v7-0-b8c0f98494fa@chromium.org> In-Reply-To: <20250616-test-v7-0-b8c0f98494fa@chromium.org> To: Vikash Garodia , Dikshita Agarwal , Bryan O'Donoghue , Mauro Carvalho Chehab , Stanimir Varbanov , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.14.2 Fps bigger than 0.000232829 fps, this fits in a 32 bit us_per_frame. There is no need to do a 64 bit division here. Also, the driver only works with whole fps. Found with cocci: drivers/media/platform/qcom/venus/venc.c:418:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead. Reviewed-by: Vikash Garodia Reviewed-by: Bryan O'Donoghue Signed-off-by: Ricardo Ribalda --- drivers/media/platform/qcom/venus/venc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c index 4979392aa20b6dc94895c7089878531b92b57754..13395aaf06bbb1f381d809c18be61c5d6da85723 100644 --- a/drivers/media/platform/qcom/venus/venc.c +++ b/drivers/media/platform/qcom/venus/venc.c @@ -412,8 +412,7 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a) do_div(us_per_frame, timeperframe->denominator); us_per_frame = clamp(us_per_frame, 1, USEC_PER_SEC); - fps = (u64)USEC_PER_SEC; - do_div(fps, us_per_frame); + fps = USEC_PER_SEC / (u32)us_per_frame; fps = min(VENUS_MAX_FPS, fps); inst->fps = fps;