From patchwork Fri Mar 7 09:29:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dan Carpenter X-Patchwork-Id: 871686 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F65C202C42 for ; Fri, 7 Mar 2025 09:29:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741339787; cv=none; b=tQV8Ndxe/0zL5rz6ZZhCYKxZdZEybjtxJGjdBb2M1j2eeAy+i/wY19fxgv8+PxXQxn1W8+HrwrYbneNxULxkQpLTocBp82f9hGMAL0U117SvmK5R/Rui6c6Uts0tt0aHPZKTz1JyhTQi7qhDPFH/Vi0ISHAI1I/guQ7y44S+g+A= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741339787; c=relaxed/simple; bh=OA/7Qe5aEekqV7T4SN23N+UJLdSmv9Rkedt7UYvoflg=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=dfiU1K8V5hLSYHxO+AwLbhmQRkmykjLG6kLd3I5k8ujdd/ukNlCavSRV8rBR7rqK5k3DzedpoDv+lkci4k+rP//QcyM0umDrzPq5YtcGy5f4OuKg1Ai11O6VDUnMTh58Uw1v2ldupx7Z/0W/YfU982Opy+khLVoB//yWgTEjB6s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ed9Eyaul; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ed9Eyaul" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43bcc04d4fcso9737095e9.2 for ; Fri, 07 Mar 2025 01:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1741339783; x=1741944583; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Im6pSo0BzRtrOvminHRm9b1Ao6lE3VOWmMljLzr+YZQ=; b=ed9Eyaulrc3fziPknhdHPMXo4Ya25d0DzW734oud1WnouOoJnoVyPQtU8PU0J6F2oo HsyvM08oKrNZ2st3hTUFpkwTJOCucLiW7MqEyLnxPi6Qjk2IrCwXSh0PG8dTy1oEywwx IHCyPf7RtRiOOqQ09brL3xCmOsPBIvLlqXglLDotRpVTvSu0qDJWDdZSEWzsRzREsM49 mVx2+rMijRM+7155yGVyID4DPjflHx57yhbaqaIgrnkpsR7NQPnrZ4WC1WBLVR3/tCg7 GoZii6LL4KOHCo3om/FmkqxnZZSZsjAZ8z1r9buVxB58PNTyzBaVRPvZrUEWOyO/C5Tm aFYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741339783; x=1741944583; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Im6pSo0BzRtrOvminHRm9b1Ao6lE3VOWmMljLzr+YZQ=; b=eSQQN44JB5u317FNHxX8gnaUaEmfyTtL92jd6TgTFGNRmgNDPmtjpChzKXLUpl8K+g w0ciKG8iO8svATcRIdb9SbNY69E5pHLH6IPkNCCdtJUKqUYcrufsTO07+s+U81EqZVnb J2oa/RzQtImxNIAeTBGuNC8v2qptZRUTvmIynCSdJnvM4YVkXnSvFAioGROf//sKSxiT ZpwQbuyOfe/k2iwF/ADGNNEsZTJ2fmaeLiBlTbBR+F8gqfvgIHh/ZZtWopLTZOYInM9H uIW9eDcAL2mviWW9/naBOnOrip+h0qseev4QYoPGn0fVjH566dUCDDnwzLVUJ4LJZ3ZG jalg== X-Forwarded-Encrypted: i=1; AJvYcCVxkGp9tqLDSbTW8t8l/eztEHSCe2MoFWRRbtJJEIrdZj6c/8V8h8DPsPTbeo+UHJ7MjUZMgtwsn5Y7WQKw@vger.kernel.org X-Gm-Message-State: AOJu0YzgL9MbvAh+EBfM8yGuJB3cqTyyF96iYPWm0Rn7xHO2aYmyRDE5 uc2n1NxbcDnKt0Dh4PNj0yWL7yEYNME99Xcr7EC4xzFszBxUOCp3xjPKOsMvndA= X-Gm-Gg: ASbGnctfL91XvIuISWJjSn02Gltpg7GqK+2fZWTQb+UJ4Fs6fZ1jItML11WAtvCLDTH uXqB6mLoLQPZaJlv6qqbS2xZTvlqeMjXP6XV1sznxkjVzh1Ny5vePFZKZdaShE4yAGOZltRYei6 sF3bhjwzAHHmR2Vxl97ber7xTm9nZeS7PlgZnQ/0HAqRcXlIeoFDbiYvnrBFC8pjHNWc8dPJ8au sQoY8vXyASr1G7D9ris/3dZ8b3P1IqRPq0UTZ0hjBM1ovA2VDtiEBIKE3H9QI5pit/Bodiz0uf8 BuA6Eh+6DjU5Ag7lev2TUDKL5knmirpsj2ta0T9t03vOkvc0tw== X-Google-Smtp-Source: AGHT+IG1aeOLiht/Zk+dJWxQiJtrE01AKe/jCJ9h6AR4ika6O/iJj47hJhtKgYXJCT1ozzCGM9Qjxg== X-Received: by 2002:a05:6000:2c6:b0:391:31f2:b99e with SMTP id ffacd0b85a97d-39132d1fc45mr1723216f8f.2.1741339783348; Fri, 07 Mar 2025 01:29:43 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-3912c0e3250sm4783347f8f.61.2025.03.07.01.29.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Mar 2025 01:29:42 -0800 (PST) Date: Fri, 7 Mar 2025 12:29:39 +0300 From: Dan Carpenter To: Jessica Zhang Cc: Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH next] drm/msm/dpu: Fix uninitialized variable in dpu_crtc_kickoff_clone_mode() Message-ID: Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Disposition: inline X-Mailer: git-send-email haha only kidding After the loop there is a check for whether "wb_encoder" has been set to non-NULL, however it was never set to NULL. Initialize it to NULL. Fixes: ad06972d5365 ("drm/msm/dpu: Reorder encoder kickoff for CWB") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c index b0a062d6fa3b..ff6f5c5303d4 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c @@ -956,7 +956,7 @@ static int _dpu_crtc_wait_for_frame_done(struct drm_crtc *crtc) static int dpu_crtc_kickoff_clone_mode(struct drm_crtc *crtc) { struct drm_encoder *encoder; - struct drm_encoder *rt_encoder = NULL, *wb_encoder; + struct drm_encoder *rt_encoder = NULL, *wb_encoder = NULL; struct dpu_kms *dpu_kms = _dpu_crtc_get_kms(crtc); /* Find encoder for real time display */