mbox series

[v13,0/4] Add support for NXP bluetooth chipsets

Message ID 20230316172214.3899786-1-neeraj.sanjaykale@nxp.com
Headers show
Series Add support for NXP bluetooth chipsets | expand

Message

Neeraj Sanjay Kale March 16, 2023, 5:22 p.m. UTC 
This patch adds a driver for NXP bluetooth chipsets.

The driver is based on H4 protocol, and uses serdev APIs. It supports host
to chip power save feature, which is signalled by the host by asserting
break over UART TX lines, to put the chip into sleep state.

To support this feature, break_ctl has also been added to serdev-tty along
with a new serdev API serdev_device_break_ctl().

This driver is capable of downloading firmware into the chip over UART.

The document specifying device tree bindings for this driver is also
included in this patch series.

Neeraj Sanjay Kale (4):
  serdev: Replace all instances of ENOTSUPP with EOPNOTSUPP
  serdev: Add method to assert break signal over tty UART port
  dt-bindings: net: bluetooth: Add NXP bluetooth support
  Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets

 .../net/bluetooth/nxp,88w8987-bt.yaml         |   45 +
 MAINTAINERS                                   |    7 +
 drivers/bluetooth/Kconfig                     |   12 +
 drivers/bluetooth/Makefile                    |    1 +
 drivers/bluetooth/btnxpuart.c                 | 1297 +++++++++++++++++
 drivers/tty/serdev/core.c                     |   17 +-
 drivers/tty/serdev/serdev-ttyport.c           |   16 +-
 include/linux/serdev.h                        |   10 +-
 8 files changed, 1398 insertions(+), 7 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
 create mode 100644 drivers/bluetooth/btnxpuart.c

Comments

Luiz Augusto von Dentz March 17, 2023, 8 p.m. UTC | #1 
Hi Neeraj,

On Thu, Mar 16, 2023 at 10:22 AM Neeraj Sanjay Kale
<neeraj.sanjaykale@nxp.com> wrote:
>
> This patch adds a driver for NXP bluetooth chipsets.
>
> The driver is based on H4 protocol, and uses serdev APIs. It supports host
> to chip power save feature, which is signalled by the host by asserting
> break over UART TX lines, to put the chip into sleep state.
>
> To support this feature, break_ctl has also been added to serdev-tty along
> with a new serdev API serdev_device_break_ctl().
>
> This driver is capable of downloading firmware into the chip over UART.
>
> The document specifying device tree bindings for this driver is also
> included in this patch series.
>
> Neeraj Sanjay Kale (4):
>   serdev: Replace all instances of ENOTSUPP with EOPNOTSUPP
>   serdev: Add method to assert break signal over tty UART port
>   dt-bindings: net: bluetooth: Add NXP bluetooth support
>   Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets
>
>  .../net/bluetooth/nxp,88w8987-bt.yaml         |   45 +
>  MAINTAINERS                                   |    7 +
>  drivers/bluetooth/Kconfig                     |   12 +
>  drivers/bluetooth/Makefile                    |    1 +
>  drivers/bluetooth/btnxpuart.c                 | 1297 +++++++++++++++++
>  drivers/tty/serdev/core.c                     |   17 +-
>  drivers/tty/serdev/serdev-ttyport.c           |   16 +-
>  include/linux/serdev.h                        |   10 +-
>  8 files changed, 1398 insertions(+), 7 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
>  create mode 100644 drivers/bluetooth/btnxpuart.c
>
> --
> 2.34.1

If there are no new comments to be addressed by the end of the day I'm
planning to merge this into bluetooth-next.
Simon Horman March 17, 2023, 8:42 p.m. UTC | #2 
On Fri, Mar 17, 2023 at 01:00:11PM -0700, Luiz Augusto von Dentz wrote:
> Hi Neeraj,
> 
> On Thu, Mar 16, 2023 at 10:22 AM Neeraj Sanjay Kale
> <neeraj.sanjaykale@nxp.com> wrote:
> >
> > This patch adds a driver for NXP bluetooth chipsets.
> >
> > The driver is based on H4 protocol, and uses serdev APIs. It supports host
> > to chip power save feature, which is signalled by the host by asserting
> > break over UART TX lines, to put the chip into sleep state.
> >
> > To support this feature, break_ctl has also been added to serdev-tty along
> > with a new serdev API serdev_device_break_ctl().
> >
> > This driver is capable of downloading firmware into the chip over UART.
> >
> > The document specifying device tree bindings for this driver is also
> > included in this patch series.
> >
> > Neeraj Sanjay Kale (4):
> >   serdev: Replace all instances of ENOTSUPP with EOPNOTSUPP
> >   serdev: Add method to assert break signal over tty UART port
> >   dt-bindings: net: bluetooth: Add NXP bluetooth support
> >   Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets
> >
> >  .../net/bluetooth/nxp,88w8987-bt.yaml         |   45 +
> >  MAINTAINERS                                   |    7 +
> >  drivers/bluetooth/Kconfig                     |   12 +
> >  drivers/bluetooth/Makefile                    |    1 +
> >  drivers/bluetooth/btnxpuart.c                 | 1297 +++++++++++++++++
> >  drivers/tty/serdev/core.c                     |   17 +-
> >  drivers/tty/serdev/serdev-ttyport.c           |   16 +-
> >  include/linux/serdev.h                        |   10 +-
> >  8 files changed, 1398 insertions(+), 7 deletions(-)
> >  create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> >  create mode 100644 drivers/bluetooth/btnxpuart.c
> >
> > --
> > 2.34.1
> 
> If there are no new comments to be addressed by the end of the day I'm
> planning to merge this into bluetooth-next.

FWIIW, as someone involved in the review of this series, I am fine with that.
Even though I have only supplied tags for some of the patches;
those for which I feel that it is appropriate.
Luiz Augusto von Dentz March 17, 2023, 8:48 p.m. UTC | #3 
Hi Simon,

On Fri, Mar 17, 2023 at 1:42 PM Simon Horman <simon.horman@corigine.com> wrote:
>
> On Fri, Mar 17, 2023 at 01:00:11PM -0700, Luiz Augusto von Dentz wrote:
> > Hi Neeraj,
> >
> > On Thu, Mar 16, 2023 at 10:22 AM Neeraj Sanjay Kale
> > <neeraj.sanjaykale@nxp.com> wrote:
> > >
> > > This patch adds a driver for NXP bluetooth chipsets.
> > >
> > > The driver is based on H4 protocol, and uses serdev APIs. It supports host
> > > to chip power save feature, which is signalled by the host by asserting
> > > break over UART TX lines, to put the chip into sleep state.
> > >
> > > To support this feature, break_ctl has also been added to serdev-tty along
> > > with a new serdev API serdev_device_break_ctl().
> > >
> > > This driver is capable of downloading firmware into the chip over UART.
> > >
> > > The document specifying device tree bindings for this driver is also
> > > included in this patch series.
> > >
> > > Neeraj Sanjay Kale (4):
> > >   serdev: Replace all instances of ENOTSUPP with EOPNOTSUPP
> > >   serdev: Add method to assert break signal over tty UART port
> > >   dt-bindings: net: bluetooth: Add NXP bluetooth support
> > >   Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets
> > >
> > >  .../net/bluetooth/nxp,88w8987-bt.yaml         |   45 +
> > >  MAINTAINERS                                   |    7 +
> > >  drivers/bluetooth/Kconfig                     |   12 +
> > >  drivers/bluetooth/Makefile                    |    1 +
> > >  drivers/bluetooth/btnxpuart.c                 | 1297 +++++++++++++++++
> > >  drivers/tty/serdev/core.c                     |   17 +-
> > >  drivers/tty/serdev/serdev-ttyport.c           |   16 +-
> > >  include/linux/serdev.h                        |   10 +-
> > >  8 files changed, 1398 insertions(+), 7 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml
> > >  create mode 100644 drivers/bluetooth/btnxpuart.c
> > >
> > > --
> > > 2.34.1
> >
> > If there are no new comments to be addressed by the end of the day I'm
> > planning to merge this into bluetooth-next.
>
> FWIIW, as someone involved in the review of this series, I am fine with that.
> Even though I have only supplied tags for some of the patches;
> those for which I feel that it is appropriate.

Thanks for the feedback and the review as well.
patchwork-bot+bluetooth@kernel.org March 17, 2023, 11:50 p.m. UTC | #4 
Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 16 Mar 2023 22:52:10 +0530 you wrote:
> This patch adds a driver for NXP bluetooth chipsets.
> 
> The driver is based on H4 protocol, and uses serdev APIs. It supports host
> to chip power save feature, which is signalled by the host by asserting
> break over UART TX lines, to put the chip into sleep state.
> 
> To support this feature, break_ctl has also been added to serdev-tty along
> with a new serdev API serdev_device_break_ctl().
> 
> [...]

Here is the summary with links:
  - [v13,1/4] serdev: Replace all instances of ENOTSUPP with EOPNOTSUPP
    https://git.kernel.org/bluetooth/bluetooth-next/c/d227f286d259
  - [v13,2/4] serdev: Add method to assert break signal over tty UART port
    https://git.kernel.org/bluetooth/bluetooth-next/c/5ea260df53c2
  - [v13,3/4] dt-bindings: net: bluetooth: Add NXP bluetooth support
    https://git.kernel.org/bluetooth/bluetooth-next/c/02986ce4a4fe
  - [v13,4/4] Bluetooth: NXP: Add protocol support for NXP Bluetooth chipsets
    https://git.kernel.org/bluetooth/bluetooth-next/c/3e662aa4453a

You are awesome, thank you!