mbox series

[BlueZ,00/20] Constify all the things

Message ID 20240116-const-v1-0-17c87978f40b@gmail.com
Headers show
Series Constify all the things | expand

Message

Emil Velikov via B4 Relay Jan. 16, 2024, 2 p.m. UTC
Hello list,

Here is series#2 of the paper cut fixes. Here we annotate a handful of
the data as constant alongside updating all the respective APIs.

There's nothing particularly existing or controversial here, despite the
size of the series. That said, I'm not 100% sure that all code-paths
have been (runtime) tested.

As always - any input will be appreciated.

Thanks
Emil

---
Emil Velikov (20):
      src: const annotate the bluetooth plugin API
      monitor: const annotate util_ltv_debugger instances and API
      monitor: const annotate cmd/handler tables
      monitor: const annotate misc arrays
      monitor: const annotate intel_version_tlv_desc::type_str and API
      monitor: const annotate type_table and related API
      profiles: annotate immutable data as const
      attrib: annotate immutable data as const
      client: annotate struct option instances as const
      emulator: const annotate rfcomm_crc_table[]
      gobex: const annotate RO arrays, use G_N_ELEMENTS
      lib: const annotate hci_map instances and related API
      lib: const annotate tupla instances and API
      mesh: const annotate misc data
      obexd: remove obex_mime_type_driver::set_io_watch
      obexd: const obex_mime_type_driver instances and API
      obexd: const obex_service_driver instances and API
      obexd: const obex_transport_driver instances and API
      obexd: const annotate misc immutable data
      obexd: const annotate obex_plugin_desc entrypoint

 attrib/gatttool.c               |  8 +++---
 attrib/interactive.c            |  2 +-
 client/mgmt.c                   | 42 ++++++++++++++++----------------
 emulator/bthost.c               |  2 +-
 gobex/gobex.c                   |  8 +++---
 lib/hci.c                       | 42 ++++++++++++++++----------------
 lib/hci_lib.h                   |  4 +--
 lib/sdp.c                       | 20 +++++++--------
 mesh/agent.c                    |  4 +--
 monitor/att.c                   | 54 ++++++++++++++++++++---------------------
 monitor/avctp.c                 |  2 +-
 monitor/intel.c                 | 28 ++++++++++-----------
 monitor/l2cap.c                 |  2 +-
 monitor/rfcomm.c                |  2 +-
 monitor/sdp.c                   | 10 ++++----
 obexd/client/manager.c          |  6 ++---
 obexd/client/map.c              |  4 +--
 obexd/client/mns.c              |  8 +++---
 obexd/plugins/bluetooth.c       |  6 ++---
 obexd/plugins/filesystem.c      |  8 +++---
 obexd/plugins/ftp.c             |  2 +-
 obexd/plugins/irmc.c            |  4 +--
 obexd/plugins/mas.c             | 18 +++++++-------
 obexd/plugins/opp.c             |  2 +-
 obexd/plugins/pbap.c            |  8 +++---
 obexd/plugins/pcsuite.c         |  4 +--
 obexd/plugins/phonebook-ebook.c |  2 +-
 obexd/plugins/syncevolution.c   |  4 +--
 obexd/src/genbuiltin            |  4 +--
 obexd/src/main.c                |  2 +-
 obexd/src/mimetype.c            | 26 +++++++-------------
 obexd/src/mimetype.h            | 12 +++++----
 obexd/src/obex-priv.h           |  4 +--
 obexd/src/obex.c                | 18 +++++++-------
 obexd/src/plugin.c              |  8 +++---
 obexd/src/plugin.h              |  4 +--
 obexd/src/server.c              | 10 ++++----
 obexd/src/server.h              |  2 +-
 obexd/src/service.c             | 20 +++++++--------
 obexd/src/service.h             |  6 ++---
 obexd/src/transport.c           | 14 +++++------
 obexd/src/transport.h           |  6 ++---
 profiles/audio/avctp.c          |  2 +-
 profiles/audio/avrcp.c          |  8 +++---
 profiles/audio/media.c          |  6 ++---
 profiles/audio/sink.c           |  2 +-
 profiles/audio/source.c         |  2 +-
 profiles/audio/transport.c      | 12 ++++-----
 profiles/health/hdp_util.c      | 15 ++++++------
 profiles/iap/main.c             |  2 +-
 src/genbuiltin                  |  4 +--
 src/log.c                       |  2 +-
 src/plugin.c                    |  6 ++---
 src/plugin.h                    |  6 ++---
 54 files changed, 251 insertions(+), 258 deletions(-)
---
base-commit: 770ad5614e7e8074133e6f563495ce4822f63fe4
change-id: 20240116-const-bc91df591e93

Best regards,

Comments

patchwork-bot+bluetooth@kernel.org Jan. 22, 2024, 11:53 p.m. UTC | #1
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 16 Jan 2024 14:00:25 +0000 you wrote:
> Hello list,
> 
> Here is series#2 of the paper cut fixes. Here we annotate a handful of
> the data as constant alongside updating all the respective APIs.
> 
> There's nothing particularly existing or controversial here, despite the
> size of the series. That said, I'm not 100% sure that all code-paths
> have been (runtime) tested.
> 
> [...]

Here is the summary with links:
  - [BlueZ,01/20] src: const annotate the bluetooth plugin API
    (no matching commit)
  - [BlueZ,02/20] monitor: const annotate util_ltv_debugger instances and API
    (no matching commit)
  - [BlueZ,03/20] monitor: const annotate cmd/handler tables
    (no matching commit)
  - [BlueZ,04/20] monitor: const annotate misc arrays
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=4630f3fba0fc
  - [BlueZ,05/20] monitor: const annotate intel_version_tlv_desc::type_str and API
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5380e63a80f2
  - [BlueZ,06/20] monitor: const annotate type_table and related API
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f8e0270a7a73
  - [BlueZ,07/20] profiles: annotate immutable data as const
    (no matching commit)
  - [BlueZ,08/20] attrib: annotate immutable data as const
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a8543fd2b062
  - [BlueZ,09/20] client: annotate struct option instances as const
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=20864af937f3
  - [BlueZ,10/20] emulator: const annotate rfcomm_crc_table[]
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=4d88fd2fabd6
  - [BlueZ,11/20] gobex: const annotate RO arrays, use G_N_ELEMENTS
    (no matching commit)
  - [BlueZ,12/20] lib: const annotate hci_map instances and related API
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=af552cd906a0
  - [BlueZ,13/20] lib: const annotate tupla instances and API
    (no matching commit)
  - [BlueZ,14/20] mesh: const annotate misc data
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=a9393b2e9eec
  - [BlueZ,15/20] obexd: remove obex_mime_type_driver::set_io_watch
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8e88f8cecaa8
  - [BlueZ,16/20] obexd: const obex_mime_type_driver instances and API
    (no matching commit)
  - [BlueZ,17/20] obexd: const obex_service_driver instances and API
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ae8f9c956069
  - [BlueZ,18/20] obexd: const obex_transport_driver instances and API
    (no matching commit)
  - [BlueZ,19/20] obexd: const annotate misc immutable data
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ac1d2369b29a
  - [BlueZ,20/20] obexd: const annotate obex_plugin_desc entrypoint
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=e0c64a2031e2

You are awesome, thank you!