From patchwork Tue Mar 13 16:44:44 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thierry Escande X-Patchwork-Id: 131504 Delivered-To: patch@linaro.org Received: by 10.46.84.17 with SMTP id i17csp962329ljb; Tue, 13 Mar 2018 09:45:15 -0700 (PDT) X-Google-Smtp-Source: AG47ELu95Uy5oypFex+cz+W/CUH39HMTJsJ8RDtcZjJeJTcmrLNvnt7hAMZfs0wIl7FLP0PPnm9d X-Received: by 10.101.78.5 with SMTP id r5mr1007601pgt.33.1520959515557; Tue, 13 Mar 2018 09:45:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1520959515; cv=none; d=google.com; s=arc-20160816; b=Fc9Ko/ny8IU/PIe0dZ4SEczRVw3HgodhweFzl4fBuocvBsXLHCr7klJ0vzjzi9wJD6 IIIkMQbctjYyzgeOVDGVIWGEvuylmgd1daS4/mj9fUtLTJ/SLKQHwfmu1m5DN9vBxoqs QBf7zyNqSg6F1GxxT0m3he7MPsxbJX8WSmLJRZBjRuMBIN3HmQZZt+R6BWXmtpFfBorn lON0LtJJNONGZQ+0TzCdfoAftyXyUutJhexL6bDpn/8Y/CKMC0eDjz9ZMhPToLZsE+/d ZbiWprRlgSntyr7T32cbDg+53mRXnFkkmmzq0v99r8Z3ceiaQDKAqnqySdDfIguYrLCq IQuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfert-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:arc-authentication-results; bh=coWpb3WLukyOrHugivdFDMMX3vfiENeCgvL1zms5gUY=; b=IG+tu2xBS9HV4ThNfJjteEsHy8VU2DNRwXrrMnWAmUXfy3N6ImeqVJ8EGn7mKk5PLd VR4MNOOGrVnGpdo0pC5sAy3/NlG52LubONfJk6tv69BjCK7oOM9vMmM1qtVFHBwdCskD uncy71PzE2GWQWMuMYsNSsRJpIczvJzNjUaoKqyfKEWpn8xuUkBGWvg/+4bhzYrYzkhn aTBCas/7SrIwnZO1PDoWt1DZf8y/HcisKL1WZsQxQIPb0IYkn54WowF3vDQQeUePZyVy cAd7bo6qVH+7m4As5sIcLiIRL72hWXic9SWRskSL5kAuK2kHz5XYacgUIxDMRg3ja3lR ouwg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HocTsYOV; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y23si344627pge.500.2018.03.13.09.45.15; Tue, 13 Mar 2018 09:45:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=HocTsYOV; spf=pass (google.com: best guess record for domain of linux-bluetooth-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-bluetooth-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752815AbeCMQpN (ORCPT + 1 other); Tue, 13 Mar 2018 12:45:13 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:35173 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933531AbeCMQpM (ORCPT ); Tue, 13 Mar 2018 12:45:12 -0400 Received: by mail-wr0-f196.google.com with SMTP id n12so758893wra.2 for ; Tue, 13 Mar 2018 09:45:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfert-encoding; bh=AbIKgFMN/ywn7ETjWMSai3dutKiBo5l4VZrYu+9z7bs=; b=HocTsYOV6zVJ43yWRfqWvmrxa6+OAXuCMdazB+Ga6hqWOul5274hhTw8FbdUJhjfVs qjCuFrZvGSwxSfcwe28dMbTY42FBIt7hd4yt8m6J1PpCujxgT7K+h29DEY1oJQ4sEB1l NrDtjy9A41xGmyfKZ0cAEWYVsyr1otzkRYquA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfert-encoding; bh=AbIKgFMN/ywn7ETjWMSai3dutKiBo5l4VZrYu+9z7bs=; b=QDftNQiaKVgKKTRWv72jLHYcWe+5zbfHJFHTBUECR2gDlGHCB5FmLSgslMowIKiYzU d5BunISnyKOJXnlYQhz17AAzWHlg1Edf3AvjSu3t6uuwvaWGg3q0KHeD14+Z+SH+ge8A ZfOIVhzl6XQpIDLoUSdNDPO/ubw+zlclG4RhcR9OpyHOssKDmcMLwwIcObSBLAniKhXM EHAvEGg+YyV5mYFhn9/o1bO4vXu7/vN+yq9cpiHRx32vqjYwTBOdKshRlg3KuE7xqTWa paeJzM1CoM25lTUExTAoZ05uXV8Mx6bnW2WObrVS96b9OaqFL2FEghWQNpSsSeg+5jmA QPzg== X-Gm-Message-State: AElRT7E9BoBWbxnqFicQyuIkUtBW/cQW5he9RIGYNwvbvOO3U8xL6bcq zKV+I4rXcqVQlSFOj3DzWTK4tQ== X-Received: by 10.28.217.205 with SMTP id q196mr1356461wmg.149.1520959510635; Tue, 13 Mar 2018 09:45:10 -0700 (PDT) Received: from localhost.localdomain (aig34-1-88-167-228-121.fbx.proxad.net. [88.167.228.121]) by smtp.gmail.com with ESMTPSA id 96sm707758wrk.54.2018.03.13.09.45.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 09:45:10 -0700 (PDT) From: Thierry Escande To: Rob Herring , Andy Gross , Marcel Holtmann , Johan Hedberg , David Brown , Mark Rutland Cc: Bjorn Andersson , Srinivas Kandagatla , linux-bluetooth@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 3/3] Bluetooth: hci_qca: Add serdev support Date: Tue, 13 Mar 2018 17:44:44 +0100 Message-Id: <20180313164444.19881-4-thierry.escande@linaro.org> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180313164444.19881-1-thierry.escande@linaro.org> References: <20180313164444.19881-1-thierry.escande@linaro.org> MIME-Version: 1.0 Content-Transfert-Encoding: 8bit Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Add support for Qualcomm serial slave devices. Probe the serial device, retrieve its maximum speed and register a new hci uart device. Signed-off-by: Thierry Escande --- drivers/bluetooth/Kconfig | 2 +- drivers/bluetooth/hci_qca.c | 102 +++++++++++++++++++++++++++++++++++++++++++- 2 files changed, 101 insertions(+), 3 deletions(-) -- 2.14.1 -- To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index 07e55cd8f8c8..c2a6a7ebd14b 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -195,7 +195,7 @@ config BT_HCIUART_BCM config BT_HCIUART_QCA bool "Qualcomm Atheros protocol support" - depends on BT_HCIUART + depends on BT_HCIUART_SERDEV select BT_HCIUART_H4 select BT_QCA help diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index 05ec530b8a3a..ca5428898702 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -29,7 +29,11 @@ */ #include +#include #include +#include +#include +#include #include #include @@ -50,6 +54,9 @@ #define IBS_TX_IDLE_TIMEOUT_MS 2000 #define BAUDRATE_SETTLE_TIMEOUT_MS 300 +/* divclk4 rate */ +#define DIVCLK4_RATE_32KHZ 32768 + /* HCI_IBS transmit side sleep protocol states */ enum tx_ibs_states { HCI_IBS_TX_ASLEEP, @@ -111,6 +118,12 @@ struct qca_data { u64 votes_off; }; +struct qca_serdev { + struct hci_uart serdev_hu; + struct gpio_desc *bt_en; + struct clk *divclk4; +}; + static void __serial_clock_on(struct tty_struct *tty) { /* TODO: Some chipset requires to enable UART clock on client @@ -386,6 +399,7 @@ static void hci_ibs_wake_retrans_timeout(struct timer_list *t) /* Initialize protocol */ static int qca_open(struct hci_uart *hu) { + struct qca_serdev *qcadev; struct qca_data *qca; BT_DBG("hu %p qca_open", hu); @@ -444,6 +458,13 @@ static int qca_open(struct hci_uart *hu) timer_setup(&qca->tx_idle_timer, hci_ibs_tx_idle_timeout, 0); qca->tx_idle_delay = IBS_TX_IDLE_TIMEOUT_MS; + if (hu->serdev) { + serdev_device_open(hu->serdev); + + qcadev = serdev_device_get_drvdata(hu->serdev); + gpiod_set_value(qcadev->bt_en, 1); + } + BT_DBG("HCI_UART_QCA open, tx_idle_delay=%u, wake_retrans=%u", qca->tx_idle_delay, qca->wake_retrans); @@ -512,6 +533,7 @@ static int qca_flush(struct hci_uart *hu) /* Close protocol */ static int qca_close(struct hci_uart *hu) { + struct qca_serdev *qcadev; struct qca_data *qca = hu->priv; BT_DBG("hu %p qca close", hu); @@ -525,6 +547,13 @@ static int qca_close(struct hci_uart *hu) destroy_workqueue(qca->workqueue); qca->hu = NULL; + if (hu->serdev) { + serdev_device_close(hu->serdev); + + qcadev = serdev_device_get_drvdata(hu->serdev); + gpiod_set_value(qcadev->bt_en, 0); + } + kfree_skb(qca->rx_skb); hu->priv = NULL; @@ -885,6 +914,14 @@ static int qca_set_baudrate(struct hci_dev *hdev, uint8_t baudrate) return 0; } +static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed) +{ + if (hu->serdev) + serdev_device_set_baudrate(hu->serdev, speed); + else + hci_uart_set_baudrate(hu, speed); +} + static int qca_setup(struct hci_uart *hu) { struct hci_dev *hdev = hu->hdev; @@ -905,7 +942,7 @@ static int qca_setup(struct hci_uart *hu) speed = hu->proto->init_speed; if (speed) - hci_uart_set_baudrate(hu, speed); + host_set_baudrate(hu, speed); /* Setup user speed if needed */ speed = 0; @@ -924,7 +961,7 @@ static int qca_setup(struct hci_uart *hu) ret); return ret; } - hci_uart_set_baudrate(hu, speed); + host_set_baudrate(hu, speed); } /* Setup patch / NVM configurations */ @@ -958,12 +995,73 @@ static struct hci_uart_proto qca_proto = { .dequeue = qca_dequeue, }; +static int qca_serdev_probe(struct serdev_device *serdev) +{ + struct qca_serdev *qcadev; + + qcadev = devm_kzalloc(&serdev->dev, sizeof(*qcadev), GFP_KERNEL); + if (!qcadev) + return -ENOMEM; + + qcadev->serdev_hu.serdev = serdev; + serdev_device_set_drvdata(serdev, qcadev); + + qcadev->bt_en = devm_gpiod_get(&serdev->dev, "bt-disable-n", + GPIOD_OUT_LOW); + if (IS_ERR(qcadev->bt_en)) { + dev_err(&serdev->dev, "failed to acquire bt-disable-n gpio\n"); + return PTR_ERR(qcadev->bt_en); + } + + gpiod_set_value(qcadev->bt_en, 0); + + qcadev->divclk4 = devm_clk_get(&serdev->dev, NULL); + if (IS_ERR(qcadev->divclk4)) { + dev_err(&serdev->dev, "failed to acquire divclk4\n"); + return PTR_ERR(qcadev->divclk4); + } + + clk_set_rate(qcadev->divclk4, DIVCLK4_RATE_32KHZ); + clk_prepare_enable(qcadev->divclk4); + + return hci_uart_register_device(&qcadev->serdev_hu, &qca_proto); +} + +static void qca_serdev_remove(struct serdev_device *serdev) +{ + struct qca_serdev *qcadev = serdev_device_get_drvdata(serdev); + + hci_uart_unregister_device(&qcadev->serdev_hu); + + clk_disable(qcadev->divclk4); + clk_unprepare(qcadev->divclk4); +} + +static const struct of_device_id qca_bluetooth_of_match[] = { + { .compatible = "qcom,qca6174-bt" }, + { }, +}; +MODULE_DEVICE_TABLE(of, qca_bluetooth_of_match); + +static struct serdev_device_driver qca_serdev_driver = { + .probe = qca_serdev_probe, + .remove = qca_serdev_remove, + .driver = { + .name = "hci_uart_qca", + .of_match_table = qca_bluetooth_of_match, + }, +}; + int __init qca_init(void) { + serdev_device_driver_register(&qca_serdev_driver); + return hci_uart_register_proto(&qca_proto); } int __exit qca_deinit(void) { + serdev_device_driver_unregister(&qca_serdev_driver); + return hci_uart_unregister_proto(&qca_proto); }