| Message ID | 20201202124959.29209-1-info@metux.net |
|---|---|
| State | New |
| Headers | show |
| Series | [1/7] net: 8021q: remove unneeded MODULE_VERSION() usage | expand |
On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> Thanks for the patches. Please drop the "metux IT consult" from the addresses. The from space is supposed to be for your name. > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c > index f292e0267bb9..683e9e825b9e 100644 > --- a/net/8021q/vlan.c > +++ b/net/8021q/vlan.c > @@ -36,15 +36,10 @@ > #include "vlan.h" > #include "vlanproc.h" > > -#define DRV_VERSION "1.8" > - > /* Global VLAN variables */ > > unsigned int vlan_net_id __read_mostly; > > -const char vlan_fullname[] = "802.1Q VLAN Support"; > -const char vlan_version[] = DRV_VERSION; This patches does not build. Please redo it more carefully. You'll need to fix and resend the entire series. When you do so please provide a cover letter, even if it only contains a couple of sentences and separate the patches for bluetooth and batman-adv out as stand alone patches, so the respective maintainers can pick them up.
On Fri, 2020-12-04 at 16:09 -0800, Jakub Kicinski wrote: > On Wed, 2 Dec 2020 13:49:53 +0100 Enrico Weigelt, metux IT consult > wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> > > Thanks for the patches. Please drop the "metux IT consult" from the > addresses. The from space is supposed to be for your name. If you _really_ want this superfluous 'metux IT consult' content in your signature, and I don't think you should, use parentheses around it. Enrico Weigelt (metux IT consult) <info@metux.net> Using a comma makes copy/paste into an email client think it's two addresses.
On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult wrote: > Remove MODULE_VERSION(), as it isn't needed at all: the only version > making sense is the kernel version. > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> > --- > net/8021q/vlan.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c > index f292e0267bb9..683e9e825b9e 100644 > --- a/net/8021q/vlan.c > +++ b/net/8021q/vlan.c > @@ -36,15 +36,10 @@ > #include "vlan.h" > #include "vlanproc.h" > > -#define DRV_VERSION "1.8" > - > /* Global VLAN variables */ > > unsigned int vlan_net_id __read_mostly; > > -const char vlan_fullname[] = "802.1Q VLAN Support"; > -const char vlan_version[] = DRV_VERSION; > - > /* End of global variables definitions. */ > > static int vlan_group_prealloc_vid(struct vlan_group *vg, > @@ -687,7 +682,7 @@ static int __init vlan_proto_init(void) > { > int err; > > - pr_info("%s v%s\n", vlan_fullname, vlan_version); > + pr_info("802.1Q VLAN Support\n"); How do we feel about deleting this not really informative message altogether in a future patch?
On Sat, Dec 05, 2020 at 01:20:18PM +0200, Vladimir Oltean wrote: > On Wed, Dec 02, 2020 at 01:49:53PM +0100, Enrico Weigelt, metux IT consult wrote: > > Remove MODULE_VERSION(), as it isn't needed at all: the only version > > making sense is the kernel version. > > > > Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> > > --- > > net/8021q/vlan.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c > > index f292e0267bb9..683e9e825b9e 100644 > > --- a/net/8021q/vlan.c > > +++ b/net/8021q/vlan.c > > @@ -36,15 +36,10 @@ > > #include "vlan.h" > > #include "vlanproc.h" > > > > -#define DRV_VERSION "1.8" > > - > > /* Global VLAN variables */ > > > > unsigned int vlan_net_id __read_mostly; > > > > -const char vlan_fullname[] = "802.1Q VLAN Support"; > > -const char vlan_version[] = DRV_VERSION; > > - > > /* End of global variables definitions. */ > > > > static int vlan_group_prealloc_vid(struct vlan_group *vg, > > @@ -687,7 +682,7 @@ static int __init vlan_proto_init(void) > > { > > int err; > > > > - pr_info("%s v%s\n", vlan_fullname, vlan_version); > > + pr_info("802.1Q VLAN Support\n"); > > How do we feel about deleting this not really informative message > altogether in a future patch? It too should be removed. If drivers are working properly, they are quiet.
On 05.12.20 16:53, Greg KH wrote: >> How do we feel about deleting this not really informative message >> altogether in a future patch? > > It too should be removed. If drivers are working properly, they are > quiet. Just sent a separate patch for removing this message. I'll rebase my patch queue when this patch went through. --mtx -- --- Hinweis: unverschlüsselte E-Mails können leicht abgehört und manipuliert werden ! Für eine vertrauliche Kommunikation senden Sie bitte ihren GPG/PGP-Schlüssel zu. --- Enrico Weigelt, metux IT consult Free software and Linux embedded engineering info@metux.net -- +49-151-27565287
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e0267bb9..683e9e825b9e 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -36,15 +36,10 @@ #include "vlan.h" #include "vlanproc.h" -#define DRV_VERSION "1.8" - /* Global VLAN variables */ unsigned int vlan_net_id __read_mostly; -const char vlan_fullname[] = "802.1Q VLAN Support"; -const char vlan_version[] = DRV_VERSION; - /* End of global variables definitions. */ static int vlan_group_prealloc_vid(struct vlan_group *vg, @@ -687,7 +682,7 @@ static int __init vlan_proto_init(void) { int err; - pr_info("%s v%s\n", vlan_fullname, vlan_version); + pr_info("802.1Q VLAN Support\n"); err = register_pernet_subsys(&vlan_net_ops); if (err < 0) @@ -743,4 +738,3 @@ module_init(vlan_proto_init); module_exit(vlan_cleanup_module); MODULE_LICENSE("GPL"); -MODULE_VERSION(DRV_VERSION);
Remove MODULE_VERSION(), as it isn't needed at all: the only version making sense is the kernel version. Signed-off-by: Enrico Weigelt, metux IT consult <info@metux.net> --- net/8021q/vlan.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-)