mbox series

[v4,0/4] Add Aspeed ACRY driver for hardware acceleration

Message ID 20221214070114.3966155-1-neal_liu@aspeedtech.com
Headers show
Series Add Aspeed ACRY driver for hardware acceleration | expand

Message

Neal Liu Dec. 14, 2022, 7:01 a.m. UTC 
Aspeed ACRY engine is designed to accelerate the throughput of
ECDSA/RSA signature and verification.

These patches aim to add Aspeed ACRY RSA driver support.
This driver also pass the run-time self tests that take place at
algorithm registration on both big-endian/little-endian system
in AST2600 evaluation board .

Tested-by below configs:
- CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set
- CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y
- CONFIG_DMA_API_DEBUG=y
- CONFIG_DMA_API_DEBUG_SG=y
- CONFIG_CPU_BIG_ENDIAN=y

Change since v3:
- Revise aspeed,ast2600-ahbc.yaml dt-bindings description.

Change since v2:
- Fix format and uninitialized warning.
- Revise binding description.

Change since v1:
- Fix dt-bindings description.
- Refine the Makefile which has been addressed.

Neal Liu (4):
  crypto: aspeed: Add ACRY RSA driver
  ARM: dts: aspeed: Add ACRY/AHBC device controller node
  dt-bindings: crypto: add documentation for Aspeed ACRY
  dt-bindings: bus: add documentation for Aspeed AHBC

 .../bindings/bus/aspeed,ast2600-ahbc.yaml     |  37 +
 .../bindings/crypto/aspeed,ast2600-acry.yaml  |  49 ++
 MAINTAINERS                                   |   2 +-
 arch/arm/boot/dts/aspeed-g6.dtsi              |  13 +
 drivers/crypto/aspeed/Kconfig                 |  11 +
 drivers/crypto/aspeed/Makefile                |   2 +
 drivers/crypto/aspeed/aspeed-acry.c           | 828 ++++++++++++++++++
 7 files changed, 941 insertions(+), 1 deletion(-)
 create mode 100644 Documentation/devicetree/bindings/bus/aspeed,ast2600-ahbc.yaml
 create mode 100644 Documentation/devicetree/bindings/crypto/aspeed,ast2600-acry.yaml
 create mode 100644 drivers/crypto/aspeed/aspeed-acry.c

Comments

Herbert Xu Dec. 30, 2022, 8:29 a.m. UTC | #1 
On Wed, Dec 14, 2022 at 03:01:11PM +0800, Neal Liu wrote:
>
> +static u8 *aspeed_rsa_key_copy(u8 *src, size_t len)
> +{
> +	return kmemdup(src, len, GFP_DMA | GFP_KERNEL);

Please explain why you are using GFP_DMA.

Thanks,