| Message ID | 20230601101451.357662-1-o.rempel@pengutronix.de |
|---|---|
| Headers | show |
| Series | Add support for various features to i.MX6 bindings | expand |
On Thu, Jun 01, 2023 at 12:14:47PM +0200, Oleksij Rempel wrote: > Add support for a 3rd clock, 'osc_per', for i.MX6DL to the 'fsl,imxgpt' > binding to resolve the following dtbs_check warning: > imx6dl-alti6p.dtb: timer@2098000: clocks: [[2, 119], [2, 120], [2, 237]] > is too long > From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > imx6dl-alti6p.dtb: timer@2098000: clock-names: ['ipg', 'per', 'osc_per'] > is too long > From schema: Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/timer/fsl,imxgpt.yaml | 22 ++++++++++++++----- > 1 file changed, 16 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > index adf617b8f353..21ff51c3f38f 100644 > --- a/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > +++ b/Documentation/devicetree/bindings/timer/fsl,imxgpt.yaml > @@ -46,14 +46,24 @@ properties: > maxItems: 1 > > clocks: > - items: > - - description: SoC GPT ipg clock > - - description: SoC GPT per clock > + anyOf: No need for anyOf. Just add the 3rd entry and 'minItems: 2'. > + - items: > + - description: SoC GPT ipg clock > + - description: SoC GPT per clock > + - items: > + - description: SoC GPT ipg clock > + - description: SoC GPT per clock > + - description: SoC GPT osc_per clock > > clock-names: > - items: > - - const: ipg > - - const: per > + anyOf: > + - items: > + - const: ipg > + - const: per > + - items: > + - const: ipg > + - const: per > + - const: osc_per > > required: > - compatible > -- > 2.39.2 >
On Thu, Jun 01, 2023 at 12:14:49PM +0200, Oleksij Rempel wrote: > Extend the 'clocks' and 'clock-names' properties to support optional > 'enet1_ref_pad' and 'enet2_ref_pad' clocks to resolve the following > dtbs_check warning: > imx6ul-prti6g.dtb: clock-controller@20c4000: clocks: [[17], [18], [19], > [20], [21]] is too long > From schema: Documentation/devicetree/bindings/clock/imx6ul-clock.yaml > > imx6ul-prti6g.dtb: clock-controller@20c4000: clock-names: ['ckil', > 'osc', 'ipp_di0', 'ipp_di1', 'enet1_ref_pad'] is too long > From schema: Documentation/devicetree/bindings/clock/imx6ul-clock.yaml > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > Documentation/devicetree/bindings/clock/imx6ul-clock.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml > index be54d4df5afa..d6a36fe575d3 100644 > --- a/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/imx6ul-clock.yaml > @@ -28,18 +28,24 @@ properties: > const: 1 > > clocks: > + minItems: 4 > items: > - description: 32k osc > - description: 24m osc > - description: ipp_di0 clock input > - description: ipp_di1 clock input > + - description: Optional lenet1_ref_pad or enet2_ref_pad clocks > + - description: Optional lenet1_ref_pad or enet2_ref_pad clocks > > clock-names: > + minItems: 4 > items: > - const: ckil > - const: osc > - const: ipp_di0 > - const: ipp_di1 > + - enum: [enet1_ref_pad, enet2_ref_pad] > + - enum: [enet1_ref_pad, enet2_ref_pad] pattern: '^enet[12]_ref_pad$' Rob
On Thu, Jun 01, 2023 at 12:14:50PM +0200, Oleksij Rempel wrote: > All clocks for this driver are optional, so this change allows the It's not about what the driver supports, but the h/w. You are saying this SoC can operate with only 1 of any of the clock inputs? > 'clocks' and 'clock-names' properties to accept a single clock. > Additionally, 'enet_ref_pad' clock is added. This resolves the following > dtbs_check warning: > imx6dl-alti6p.dtb: clock-controller@20c4000: clocks: [[24]] is too short > From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml > > imx6dl-alti6p.dtb: clock-controller@20c4000: clock-names:0: 'osc' was > expected > From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml > > imx6dl-alti6p.dtb: clock-controller@20c4000: clock-names: > ['enet_ref_pad'] is too short > From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > .../devicetree/bindings/clock/imx6q-clock.yaml | 15 +++++++++------ > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml > index bae4fcb3aacc..ed65d19c2e0e 100644 > --- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml > +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml > @@ -28,20 +28,23 @@ properties: > const: 1 > > clocks: > + minItems: 1 > items: > - description: 24m osc > - description: 32k osc > - description: ckih1 clock input > - description: anaclk1 clock input > - description: anaclk2 clock input > + - description: enet_ref_pad > > clock-names: > - items: > - - const: osc > - - const: ckil > - - const: ckih1 > - - const: anaclk1 > - - const: anaclk2 > + enum: > + - osc > + - ckil > + - ckih1 > + - anaclk1 > + - anaclk2 > + - enet_ref_pad > > fsl,pmic-stby-poweroff: > $ref: /schemas/types.yaml#/definitions/flag > -- > 2.39.2 >
This patch series is aimed at addressing several dtbs_check warnings by introducing additional support in the device tree bindings for i.MX6 series SoCs. The warnings surfaced while validating some i.MX6 boards. The issues were predominantly around unrecognized compatibility strings and missing properties in the device trees. Oleksij Rempel (7): dt-bindings: mmc: fsl-imx-esdhc: Add imx6ul support dt-bindings: timer: gpt: Add i.MX6UL support dt-bindings: timer: gpt: Support 3rd clock for i.MX6DL dt-bindings: crypto: fsl-dcp: Add i.MX6SL, i.MX6SLL, and i.MX6ULL support dt-bindings: clock: imx6ul: Support optional enet*_ref_pad clocks dt-bindings: clock: imx6q: Allow single optional clock and add enet_ref_pad dt-bindings: input: touchscreen: edt-ft5x06: Add 'threshold' property .../bindings/clock/imx6q-clock.yaml | 15 ++++++----- .../bindings/clock/imx6ul-clock.yaml | 6 +++++ .../devicetree/bindings/crypto/fsl-dcp.yaml | 19 +++++++++++--- .../input/touchscreen/edt-ft5x06.yaml | 6 +++++ .../bindings/mmc/fsl-imx-esdhc.yaml | 2 ++ .../devicetree/bindings/timer/fsl,imxgpt.yaml | 26 ++++++++++++++----- 6 files changed, 59 insertions(+), 15 deletions(-)