mbox series

[0/5] crypto: arm64 - clean up backwards function names

Message ID 20231010064127.323261-1-ebiggers@kernel.org
Headers show
Series crypto: arm64 - clean up backwards function names | expand

Message

Eric Biggers Oct. 10, 2023, 6:41 a.m. UTC 
In the Linux kernel, a function whose name has two leading underscores
is conventionally called by the same-named function without leading
underscores -- not the other way around.  Some of the arm64 crypto code
got this backwards.  Fix it.

Eric Biggers (5):
  crypto: arm64/sha1-ce - clean up backwards function names
  crypto: arm64/sha2-ce - clean up backwards function names
  crypto: arm64/sha512-ce - clean up backwards function names
  crypto: arm64/sha256 - clean up backwards function names
  crypto: arm64/sha512 - clean up backwards function names

 arch/arm64/crypto/sha1-ce-core.S   |  8 ++++----
 arch/arm64/crypto/sha1-ce-glue.c   | 21 ++++++++++----------
 arch/arm64/crypto/sha2-ce-core.S   |  8 ++++----
 arch/arm64/crypto/sha2-ce-glue.c   | 31 +++++++++++++++---------------
 arch/arm64/crypto/sha256-glue.c    | 26 ++++++++++++-------------
 arch/arm64/crypto/sha512-ce-core.S |  8 ++++----
 arch/arm64/crypto/sha512-ce-glue.c | 26 ++++++++++++-------------
 arch/arm64/crypto/sha512-glue.c    | 12 +++++-------
 8 files changed, 69 insertions(+), 71 deletions(-)

base-commit: 8468516f9f93a41dc65158b6428a1a1039c68f20

Comments

Herbert Xu Oct. 20, 2023, 5:53 a.m. UTC | #1 
Eric Biggers <ebiggers@kernel.org> wrote:
> In the Linux kernel, a function whose name has two leading underscores
> is conventionally called by the same-named function without leading
> underscores -- not the other way around.  Some of the arm64 crypto code
> got this backwards.  Fix it.
> 
> Eric Biggers (5):
>  crypto: arm64/sha1-ce - clean up backwards function names
>  crypto: arm64/sha2-ce - clean up backwards function names
>  crypto: arm64/sha512-ce - clean up backwards function names
>  crypto: arm64/sha256 - clean up backwards function names
>  crypto: arm64/sha512 - clean up backwards function names
> 
> arch/arm64/crypto/sha1-ce-core.S   |  8 ++++----
> arch/arm64/crypto/sha1-ce-glue.c   | 21 ++++++++++----------
> arch/arm64/crypto/sha2-ce-core.S   |  8 ++++----
> arch/arm64/crypto/sha2-ce-glue.c   | 31 +++++++++++++++---------------
> arch/arm64/crypto/sha256-glue.c    | 26 ++++++++++++-------------
> arch/arm64/crypto/sha512-ce-core.S |  8 ++++----
> arch/arm64/crypto/sha512-ce-glue.c | 26 ++++++++++++-------------
> arch/arm64/crypto/sha512-glue.c    | 12 +++++-------
> 8 files changed, 69 insertions(+), 71 deletions(-)
> 
> base-commit: 8468516f9f93a41dc65158b6428a1a1039c68f20

All applied.  Thanks.