From patchwork Thu Feb 4 11:09:45 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 376246 Delivered-To: patch@linaro.org Received: by 2002:a17:906:48d2:0:0:0:0 with SMTP id d18csp1188988ejt; Thu, 4 Feb 2021 03:12:29 -0800 (PST) X-Google-Smtp-Source: ABdhPJwLu6+bJWDioWji3FsgApoeI96q65Boz+Cv2cQTrjWZsPX2V/5NDGp2mp6Sh+XQ6sxJm4J7 X-Received: by 2002:a17:906:6449:: with SMTP id l9mr7864392ejn.320.1612437149691; Thu, 04 Feb 2021 03:12:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1612437149; cv=none; d=google.com; s=arc-20160816; b=S3DW7fDUYtVNetCTDxGquwXGppu3tkdkdZ82l7mnhQ3IK0JlP6OsNKmZs3ewXvu98R +2A0A+dbat9wB/M3dqdZ6Esq6KRrCoARtpDukJWfpwbS3R5Ho3+9276Fv+SZ9GcAazeY W5Ca+yL9WcUTukOWIF3cFTPZJVDcaCV3N2yx6eU8aKqasrYVG96ONrVqO0efzQX51cpq eXuPPbmZOyKcIXc2dT0cM6o5k0E1FR+mJzI5AqZG0r6YTnIIyJwBTvIks0nK9XetD7qj 2q+BTut3XhgGDJEyHX7pnaSBdiR1w5dLdgNc+9BL1eRXn4oCPUE2oelRiQJByknZHKmc pHAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9PQJyorI7NSFOmBlzU3qYIYb38rUcKuWau7MQ0QjGLc=; b=KFL80HGmNbF06SMu7q6GIdxEn2KGLSuposbcKLMHo0psTlb3sfT0WAKNnrJJpMeqQe 3pYHrhTlE7GCO5uvbOXQ09853I3dxt4f0shy+6ibIEDUrpr0Q/KTFrMG2s9OE6DngnyZ aQWlMPHim/XStwgf2RW/ZG8ixIX97y6s4bxzlrLvJyHSL5P5c0YgsrtS7V96pFwCRy9v AAAou8fm0Yam2tcUk1GB74L/dT2Y03LNKnoHHnzd89miHNZWup9rKDvZRnecLfnl7K2C E6xSfolLxjZSrwrX6z95Ue/zVZxdVt5ms4t+inZgGPSWS7hXVx0rceht9eNIsrgchYGX WOrg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="FSr/KZiv"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y25si3349293ejb.546.2021.02.04.03.12.29; Thu, 04 Feb 2021 03:12:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="FSr/KZiv"; spf=pass (google.com: domain of linux-crypto-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-crypto-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235720AbhBDLMZ (ORCPT + 2 others); Thu, 4 Feb 2021 06:12:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235675AbhBDLLr (ORCPT ); Thu, 4 Feb 2021 06:11:47 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11A4FC0617A7 for ; Thu, 4 Feb 2021 03:10:11 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id f16so2735532wmq.5 for ; Thu, 04 Feb 2021 03:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9PQJyorI7NSFOmBlzU3qYIYb38rUcKuWau7MQ0QjGLc=; b=FSr/KZivxIq+H/JsqxnJyXqNIN1K1v9CM8MSNUgKhBPSIYQoO9U08WhO3MexdqcSzu gpILk81W/zf9kGFNHKPWIuVEZNPAcRAw39QXhu6cW1zh0dTinkZbWbc4dd09ItE6twgb Fmhnwo5w4g0oDXtBu38c0voaX/yr0AlkAIvqVbWlfwz88N7myvfqTLv6to2OZDpMuZag L6R6aj7lbNhQ6WkdObOHke2kK/qaRDeB4HhnJRr3rkqdCWcAr3qA4O7H9ATKSwDZ6DPy CZaxYueFvtlzAd5KvpTMazQG34Ws82FZ6ActFk41KPqJJi48ARBHtoeY03glTGrZ1fSN GN3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9PQJyorI7NSFOmBlzU3qYIYb38rUcKuWau7MQ0QjGLc=; b=s0Oj71hoQyv2ZZGJe4MoLmHE7AAhhadebuxm1Cd7mxR4ST91P4AbXs9qYVJ9l44S6i aRY1O0VdPvt8bdRqUIoVj/FA9ZcZ9JqRhqy3EXk53aXDzmdkqUeSqgVAu0f/fLDxnplv fJwB+Tv9IYqhIlX3DX1BEMdz5xwuRFWawbkhjfwkEnlSy4L6tPzoPMdgfFiHyjKbXEb+ lPk/SvTo/33A43AvJEkFjd5yhAP9WOgN5eQbre92RmEJxqGfExD5Ouwsos/Rd5pBLC6p LqIfJ8l4We0M7d33WMi5tBALxpqoqeAnLa8bYsNHHBGl58RKQUsfSdMgneszsMbxijfd kxaw== X-Gm-Message-State: AOAM530DFPqfDctRF1KXwby088tEc+MegWlJzhRCj/GXUpN0Q+LvTi7z F/LbRGnVON0V7PmhY8hmFuxpmYp71oPFxw== X-Received: by 2002:a05:600c:230e:: with SMTP id 14mr7003253wmo.161.1612437009685; Thu, 04 Feb 2021 03:10:09 -0800 (PST) Received: from dell.default ([91.110.221.188]) by smtp.gmail.com with ESMTPSA id y18sm7696218wrt.19.2021.02.04.03.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Feb 2021 03:10:09 -0800 (PST) From: Lee Jones To: lee.jones@linaro.org Cc: linux-kernel@vger.kernel.org, Herbert Xu , "David S. Miller" , linux-crypto@vger.kernel.org Subject: [PATCH 05/20] crypto: bcm: spu: Fix formatting and misspelling issues Date: Thu, 4 Feb 2021 11:09:45 +0000 Message-Id: <20210204111000.2800436-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210204111000.2800436-1-lee.jones@linaro.org> References: <20210204111000.2800436-1-lee.jones@linaro.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/crypto/bcm/spu.c:464: warning: Excess function parameter 'Return' description in 'spum_gcm_ccm_pad_len' drivers/crypto/bcm/spu.c:524: warning: Function parameter or member 'iv_len' not described in 'spum_aead_ivlen' drivers/crypto/bcm/spu.c:524: warning: expecting prototype for spu_aead_ivlen(). Prototype was for spum_aead_ivlen() instead drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'alg_digest_size' not described in 'spum_digest_size' drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'alg' not described in 'spum_digest_size' drivers/crypto/bcm/spu.c:556: warning: Function parameter or member 'htype' not described in 'spum_digest_size' drivers/crypto/bcm/spu.c:583: warning: bad line: drivers/crypto/bcm/spu.c:927: warning: Function parameter or member 'is_inbound' not described in 'spum_cipher_req_finish' drivers/crypto/bcm/spu.c:927: warning: Excess function parameter 'isInbound' description in 'spum_cipher_req_finish' Cc: Herbert Xu Cc: "David S. Miller" Cc: linux-crypto@vger.kernel.org Signed-off-by: Lee Jones --- drivers/crypto/bcm/spu.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) -- 2.25.1 diff --git a/drivers/crypto/bcm/spu.c b/drivers/crypto/bcm/spu.c index 007abf92cc05b..6283e8c6d51d3 100644 --- a/drivers/crypto/bcm/spu.c +++ b/drivers/crypto/bcm/spu.c @@ -457,7 +457,7 @@ u16 spum_hash_pad_len(enum hash_alg hash_alg, enum hash_mode hash_mode, * @cipher_mode: Algo type * @data_size: Length of plaintext (bytes) * - * @Return: Length of padding, in bytes + * Return: Length of padding, in bytes */ u32 spum_gcm_ccm_pad_len(enum spu_cipher_mode cipher_mode, unsigned int data_size) @@ -510,10 +510,10 @@ u32 spum_assoc_resp_len(enum spu_cipher_mode cipher_mode, } /** - * spu_aead_ivlen() - Calculate the length of the AEAD IV to be included + * spum_aead_ivlen() - Calculate the length of the AEAD IV to be included * in a SPU request after the AAD and before the payload. * @cipher_mode: cipher mode - * @iv_ctr_len: initialization vector length in bytes + * @iv_len: initialization vector length in bytes * * In Linux ~4.2 and later, the assoc_data sg includes the IV. So no need * to include the IV as a separate field in the SPU request msg. @@ -543,9 +543,9 @@ enum hash_type spum_hash_type(u32 src_sent) /** * spum_digest_size() - Determine the size of a hash digest to expect the SPU to * return. - * alg_digest_size: Number of bytes in the final digest for the given algo - * alg: The hash algorithm - * htype: Type of hash operation (init, update, full, etc) + * @alg_digest_size: Number of bytes in the final digest for the given algo + * @alg: The hash algorithm + * @htype: Type of hash operation (init, update, full, etc) * * When doing incremental hashing for an algorithm with a truncated hash * (e.g., SHA224), the SPU returns the full digest so that it can be fed back as @@ -580,7 +580,7 @@ u32 spum_digest_size(u32 alg_digest_size, enum hash_alg alg, * @aead_parms: Parameters related to AEAD operation * @data_size: Length of data to be encrypted or authenticated. If AEAD, does * not include length of AAD. - + * * Return: the length of the SPU header in bytes. 0 if an error occurs. */ u32 spum_create_request(u8 *spu_hdr, @@ -911,7 +911,7 @@ u16 spum_cipher_req_init(u8 *spu_hdr, struct spu_cipher_parms *cipher_parms) * setkey() time in spu_cipher_req_init(). * @spu_hdr: Start of the request message header (MH field) * @spu_req_hdr_len: Length in bytes of the SPU request header - * @isInbound: 0 encrypt, 1 decrypt + * @is_inbound: 0 encrypt, 1 decrypt * @cipher_parms: Parameters describing cipher operation to be performed * @data_size: Length of the data in the BD field *