| Message ID | 20230911101939.86140-2-lucas.segarra.fernandez@intel.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add debugfs pm_status for qat driver | expand |
On Mon, Sep 11, 2023 at 12:19:38PM +0200, Lucas Segarra Fernandez wrote: > Include missing headers for GENMASK(), kstrtobool() and types. > > Add forward declaration for struct adf_accel_dev. Remove unneeded > include. > > This change doesn't introduce any function change. > > Signed-off-by: Lucas Segarra Fernandez <lucas.segarra.fernandez@intel.com> > Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com> > Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com> > --- > drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c | 3 +++ > drivers/crypto/intel/qat/qat_common/adf_gen4_pm.h | 4 +++- > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c > index 34c6cd8e27c0..3bde8759c2a2 100644 > --- a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c > +++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c > @@ -2,6 +2,9 @@ > /* Copyright(c) 2022 Intel Corporation */ > #include <linux/bitfield.h> > #include <linux/iopoll.h> > +#include <linux/kstrtox.h> > +#include <linux/types.h> Please use linux/kernel.h in C files. Thanks,
diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c index 34c6cd8e27c0..3bde8759c2a2 100644 --- a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c +++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.c @@ -2,6 +2,9 @@ /* Copyright(c) 2022 Intel Corporation */ #include <linux/bitfield.h> #include <linux/iopoll.h> +#include <linux/kstrtox.h> +#include <linux/types.h> + #include "adf_accel_devices.h" #include "adf_common_drv.h" #include "adf_gen4_pm.h" diff --git a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.h b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.h index c2768762cca3..39d37b352b45 100644 --- a/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.h +++ b/drivers/crypto/intel/qat/qat_common/adf_gen4_pm.h @@ -3,7 +3,9 @@ #ifndef ADF_GEN4_PM_H #define ADF_GEN4_PM_H -#include "adf_accel_devices.h" +#include <linux/bits.h> + +struct adf_accel_dev; /* Power management registers */ #define ADF_GEN4_PM_HOST_MSG (0x50A01C)