| Message ID | 20171212220143.31210-1-dmurphy@ti.com |
|---|---|
| Headers | show |
| Series | Updated LP8860 driver series | expand |
Dan, Patch set applied, thanks. -- Best regards, Jacek Anaszewski On 12/12/2017 11:01 PM, Dan Murphy wrote: > All > > v4 - Fix checkpatch warning for code indentation on the > leds: lp8860: Update the dt parsing for LED labeling patch. > > v3 - Made changes to the patch set to address concerns on DT node naming conventions > based on discussion in the RFC patch https://patchwork.kernel.org/patch/10089047/ > also made requested changes to the DT and driver based on feedback. Patchworks > links in each patch. > > v2 - Added an initial patch to bring the DT binding up to standard prior to adding > the changes for the label and triggers. > > v1 Cover letter repeat below > > After creating a new LED driver for the LM3692x device I went back to the > LP8860 driver that I authored and found some updates that need to be applied. > > First the way the LP8860 retrieved the label from the DT was incorrect as the > label should have been from a child node as opposed to the parent. This is now > fixed with this series. > > Second, since that device can be used to as either a backlight driver or as a > string agnostic driver a trigger to the backlight needed to be added. > > Finally there are changes to the driver that need to be made as either > unnoticed bugs or updates to the driver to align with the current LED > framework. For instance moving to the devm LED class registration, destroying > the mutex upon driver removal and removing the in driver dependency on CONFIG_OF > and moving it to the Kconfig. > > With these changes this should at least bring the driver into a better shape. > > There are additional changes coming for this driver but I wanted to get the > driver up to snuff before adding a feature to it. > > Dan > > Dan Murphy (6): > dt: bindings: lp8860: Update bindings for lp8860 > dt: bindings: lp8860: Update DT label binding > leds: lp8860: Update the dt parsing for LED labeling > dt: bindings: lp8860: Add trigger binding to the lp8860 > leds: lp8860: Add DT parsing to retrieve the trigger node > leds: lp8860: Various fixes to align with LED framework > > .../devicetree/bindings/leds/leds-lp8860.txt | 32 ++++++++++++----- > drivers/leds/Kconfig | 2 +- > drivers/leds/leds-lp8860.c | 40 ++++++++++++---------- > 3 files changed, 46 insertions(+), 28 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Dec 12, 2017 at 04:01:39PM -0600, Dan Murphy wrote: > Update the lp8860 label binding to the LED > standard as documented in > > Documentation/devicetree/bindings/leds/common.txt > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > > v4 - No changes > > v3 - Added address and size cells, updated label with color and inserted spaces > around the reg node - https://patchwork.kernel.org/patch/10093749/ > v2 - Added reg to child node and made it required > > Documentation/devicetree/bindings/leds/leds-lp8860.txt | 17 +++++++++++++++-- > 1 file changed, 15 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt > index b9d09acbaa73..c3d64ade1e26 100644 > --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt > +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt > @@ -9,20 +9,33 @@ Required properties: > - compatible : > "ti,lp8860" > - reg : I2C slave address > - - label : Used for naming LEDs > + - #address-cells : 1 > + - #size-cells : 0 > > Optional properties: > - enable-gpios : gpio pin to enable (active high)/disable the device. > - vled-supply : LED supply > > +Required child properties: > + - reg : 0 > + This should be in previous patch? > +Optional child properties: > + - label : see Documentation/devicetree/bindings/leds/common.txt > + > Example: > > led-controller@2d { > compatible = "ti,lp8860"; > + #address-cells = <1>; > + #size-cells = <0>; > reg = <0x2d>; > - label = "display_cluster"; > enable-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>; > vled-supply = <&vbatt>; > + > + led@0 { > + reg = <0>; > + label = "white:display_cluster"; > + }; > } > > For more product information please see the link below: > -- > 2.15.0.124.g7668cbc60 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html