| Message ID | 20180625143115.8346-1-srinivas.kandagatla@linaro.org |
|---|---|
| Headers | show |
| Series | ASoC: qdsp6: Fix dt based module loading | expand |
Acked-by: Niklas Cassel <niklas.cassel@linaro.org> On Mon, Jun 25, 2018 at 03:31:14PM +0100, Srinivas Kandagatla wrote: > module owner is already set in platform_driver_register(), so remove this > redundant assignment. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > sound/soc/qcom/apq8096.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/sound/soc/qcom/apq8096.c b/sound/soc/qcom/apq8096.c > index 561cd429e6f2..6e79fec7e789 100644 > --- a/sound/soc/qcom/apq8096.c > +++ b/sound/soc/qcom/apq8096.c > @@ -245,7 +245,6 @@ static struct platform_driver msm_snd_apq8096_driver = { > .remove = apq8096_platform_remove, > .driver = { > .name = "msm-snd-apq8096", > - .owner = THIS_MODULE, > .of_match_table = msm_snd_apq8096_dt_match, > }, > }; > -- > 2.16.2 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Jun 25, 2018 at 03:31:15PM +0100, Srinivas Kandagatla wrote: > q6adm_open can return error pointer or a null in error cases. > Fix this check this. Instead of "Fix this check this.", how about "Fix the return handling." > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > sound/soc/qcom/qdsp6/q6routing.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c > index caf2f847a886..c18f808c7730 100644 > --- a/sound/soc/qcom/qdsp6/q6routing.c > +++ b/sound/soc/qcom/qdsp6/q6routing.c > @@ -310,7 +310,7 @@ int q6routing_stream_open(int fedai_id, int perf_mode, > session->channels, topology, perf_mode, > session->bits_per_sample, 0, 0); > > - if (!copp) { > + if (IS_ERR_OR_NULL(copp)) { > mutex_unlock(&routing_data->lock); > return -EINVAL; > } > -- > 2.16.2 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 25/06/18 19:04, Niklas Cassel wrote: > On Mon, Jun 25, 2018 at 03:31:15PM +0100, Srinivas Kandagatla wrote: >> q6adm_open can return error pointer or a null in error cases. >> Fix this check this. > Instead of "Fix this check this.", how about "Fix the return handling." Thanks, I will reword this! --srini > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 25/06/18 19:03, Niklas Cassel wrote: > You can remove pdev_routing from struct q6adm, > since it is no longer in use. yep, I thought I removed this, but it looks like its still there. Will fix this in next version. thanks, srini -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html