mbox series

[v5,0/8] ASoC: Add support to WCD9335 Audio Codec

Message ID 20190110150616.2332-1-srinivas.kandagatla@linaro.org
Headers show
Series ASoC: Add support to WCD9335 Audio Codec | expand

Message

Srinivas Kandagatla Jan. 10, 2019, 3:06 p.m. UTC 
Thankyou for reviewing v4 patchset, here is v5 addressing comments from v4.
Major change is moving the driver out of MFD as there are no immediate plans
to add support to other drivers on this codec.

Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC.
It is integrated in multiple Qualcomm SoCs like: MSM8996, MSM8976,
and MSM8956 chipsets.

WCD9335 had multiple functional blocks, like: Soundwire controller,
interrupt mux, pin controller, Audio codec, MBHC, MAD(Mic activity Detection),
Ultrasonic proximity and pen detection, Battery-voltage monitoring and
Codec processing engine.

Currently this patchset has been only tested with SLIMbus interface due
to hardware avaiablity, but it can be easily made to work with both SLIMbus
and I2C/I2S.    

This patchset adds very basic playback and capture support without much
fancy features. New features will be added once the basic support is in.
This patchset is tested on top of linux-next on DB820c for both playback
, capture paths and MBHC.

Some parts of the code has been inherited from Qualcomm andriod kernel,
so credits to various authors.

WCD9335 can be interfaced via I2S/I2C or SLIMbus. 

Here is our integration branch incase someone want to try this out:
https://git.linaro.org/landing-teams/working/qualcomm/kernel.git/log/?h=integration-linux-qcomlt

Thanks,
Srini

Changes since v4 (https://lkml.org/lkml/2018/9/17/21/)
 - Move the driver out of MFD as discussed with Lee
 - defer support to MBHC for more testing!

Srinivas Kandagatla (8):
  ASoC: dt-bindings: update wcd9335 bindings.
  ASoC: wcd9335: add support to wcd9335 codec
  ASoC: wcd9335: add CLASS-H Controller support
  ASoC: wcd9335: add basic controls
  ASoC: wcd9335: add playback dapm widgets
  ASoC: wcd9335: add capture dapm widgets
  ASoC: wcd9335: add audio routings
  ASoC: apq8096: add slim support

 .../bindings/sound/qcom,wcd9335.txt           |   10 +-
 sound/soc/codecs/Kconfig                      |    6 +
 sound/soc/codecs/Makefile                     |    2 +
 sound/soc/codecs/wcd-clsh-v2.c                |  576 ++
 sound/soc/codecs/wcd-clsh-v2.h                |   49 +
 sound/soc/codecs/wcd9335.c                    | 5275 +++++++++++++++++
 sound/soc/codecs/wcd9335.h                    |  640 ++
 sound/soc/qcom/apq8096.c                      |   71 +-
 8 files changed, 6623 insertions(+), 6 deletions(-)
 create mode 100644 sound/soc/codecs/wcd-clsh-v2.c
 create mode 100644 sound/soc/codecs/wcd-clsh-v2.h
 create mode 100644 sound/soc/codecs/wcd9335.c
 create mode 100644 sound/soc/codecs/wcd9335.h

-- 
2.20.1

Comments

Mark Brown Jan. 22, 2019, 6:52 p.m. UTC | #1 
On Thu, Jan 10, 2019 at 03:06:12PM +0000, Srinivas Kandagatla wrote:

> +static const char * const wcd9335_ear_pa_gain_text[] = {

> +	"G_6_DB", "G_4P5_DB", "G_3_DB", "G_1P5_DB",

> +	"G_0_DB", "G_M2P5_DB", "UNDEFINED", "G_M12_DB"

> +};


Gains should be controlled with Volume controls, not enums.  Provide
information on the levels via TLV.

> +static const char * const rx_hph_mode_mux_text[] = {

> +	"CLS_H_INVALID", "CLS_H_HIFI", "CLS_H_LP", "CLS_AB", "CLS_H_LOHIFI"

> +};


Is there a strong reason not to use more human readable strings here?