mbox series

[v2,0/2] Add Reset controller support for HI3670 SoC

Message ID 20190215054955.788-1-manivannan.sadhasivam@linaro.org
Headers show
Series Add Reset controller support for HI3670 SoC | expand

Message

Manivannan Sadhasivam Feb. 15, 2019, 5:49 a.m. UTC
Hello,

This patchset adds Reset controller support for HiSilicon HI3670 SoC.
HI3670 SoC is architecturally same as HI3660 SoC, hence the same driver
is reused.

This patchset has been tested on HiKey970 board.

Thanks,
Mani

Changes in v2:

* Used the DT compatible fallback approach instead of adding a new one
  for HI3670

Manivannan Sadhasivam (2):
  dt-bindings: reset: Add HI3670 reset controller binding
  arm64: dts: hisilicon: hi3670: Add reset controller support

 .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt   | 7 ++++---
 arch/arm64/boot/dts/hisilicon/hi3670.dtsi                  | 6 ++++++
 2 files changed, 10 insertions(+), 3 deletions(-)

-- 
2.17.1

Comments

Philipp Zabel Feb. 15, 2019, 10:25 a.m. UTC | #1
On Fri, 2019-02-15 at 11:19 +0530, Manivannan Sadhasivam wrote:
> HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same

> driver is reused for HI3670 SoC and the binding is documented here which

> uses the fallback approach.

> 

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> ---

>  .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt   | 7 ++++---

>  1 file changed, 4 insertions(+), 3 deletions(-)

> 

> diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt

> index 2bf3344b2a02..2df4bddeb688 100644

> --- a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt

> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt

> @@ -5,11 +5,12 @@ Please also refer to reset.txt in this directory for common reset

>  controller binding usage.

>  

>  The reset controller registers are part of the system-ctl block on

> -hi3660 SoC.

> +hi3660 and hi3670 SoCs.

>  

>  Required properties:

> -- compatible: should be

> -		 "hisilicon,hi3660-reset"

> +- compatible: should be one of the following:

> +		 "hisilicon,hi3660-reset" for HI3660

> +		 "hisilicon,hi3670-reset", "hisilicon,hi3660-reset" for HI3670

>  - hisi,rst-syscon: phandle of the reset's syscon.

>  - #reset-cells : Specifies the number of cells needed to encode a

>    reset source.  The type shall be a <u32> and the value shall be 2.


Thank you, I think it makes sense for this to be merged together with
the other patch via the linux-hisi tree.

Acked-by: Philipp Zabel <p.zabel@pengutronix.de>


regards
Philipp
Rob Herring (Arm) Feb. 18, 2019, 8:08 p.m. UTC | #2
On Fri, 15 Feb 2019 11:19:54 +0530, Manivannan Sadhasivam wrote:
> HI3670 SoC is architecturally same as the HI3660 SoC. Hence, the same

> driver is reused for HI3670 SoC and the binding is documented here which

> uses the fallback approach.

> 

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>

> ---

>  .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt   | 7 ++++---

>  1 file changed, 4 insertions(+), 3 deletions(-)

> 


Reviewed-by: Rob Herring <robh@kernel.org>
Wei Xu April 15, 2019, 3:53 p.m. UTC | #3
Hi Manivannan,

On 2/15/2019 5:49 AM, Manivannan Sadhasivam wrote:
> Hello,

> 

> This patchset adds Reset controller support for HiSilicon HI3670 SoC.

> HI3670 SoC is architecturally same as HI3660 SoC, hence the same driver

> is reused.

> 

> This patchset has been tested on HiKey970 board.

> 

> Thanks,

> Mani

> 

> Changes in v2:

> 

> * Used the DT compatible fallback approach instead of adding a new one

>   for HI3670

> 

> Manivannan Sadhasivam (2):

>   dt-bindings: reset: Add HI3670 reset controller binding

>   arm64: dts: hisilicon: hi3670: Add reset controller support

> 

>  .../devicetree/bindings/reset/hisilicon,hi3660-reset.txt   | 7 ++++---

>  arch/arm64/boot/dts/hisilicon/hi3670.dtsi                  | 6 ++++++

>  2 files changed, 10 insertions(+), 3 deletions(-)

> 


Thanks!
Applied the series to the hisilicon dts tree.

Best Regards,
Wei