mbox series

[v3,0/6] ASoC: codecs: add support for LPASS Codec macros

Message ID 20201105113458.12360-1-srinivas.kandagatla@linaro.org
Headers show
Series ASoC: codecs: add support for LPASS Codec macros | expand

Message

Srinivas Kandagatla Nov. 5, 2020, 11:34 a.m. UTC 
This patchset adds support for two Codec Macro blocks( WSA and VA) available in
Qualcomm LPASS (Low Power Audio SubSystem).

There are WSA, VA, TX and RX Macros on LPASS IP, each of the Macro block
has specific connectivity like WSA Macros are intended to connect
to WSA Smart speaker codecs via SoundWire. VA Macro is intended for DMICs,
and TX/RX for Analog codecs via SoundWire like other WCD Codecs to provide
headphone/ear/lineout etc ..

Most of the work is derived from downstream Qualcomm kernels.
Credits to various Qualcomm authors from Patrick Lai's team who have
contributed to this code.

This patchset has been tested on support to Qualcomm Robotics RB5 Development
Kit based on QRB5165 Robotics SoC. This board has 2 WSA881X smart speakers
with onboard DMIC connected to internal LPASS codec via WSA  and VA macros
respectively.

Thanks,
srini

-Changes since v2:
 - various unnecessary variable intializations removed, suggested by Pierre
 - fixed a static checker error
 - collected reviews for dt-bindings.
 - fixed licence headers as suggested by Pierre.

Srinivas Kandagatla (6):
  ASoC: qcom: dt-bindings: add bindings for lpass wsa macro codec
  ASoC: codecs: lpass-wsa-macro: Add support to WSA Macro
  ASoC: codecs: lpass-wsa-macro: add dapm widgets and route
  ASoC: qcom: dt-bindings: add bindings for lpass va macro codec
  ASoC: codecs: lpass-va-macro: Add support to VA Macro
  ASoC: codecs: lpass-va-macro: add dapm widgets and routes

 .../bindings/sound/qcom,lpass-va-macro.yaml   |   67 +
 .../bindings/sound/qcom,lpass-wsa-macro.yaml  |   69 +
 sound/soc/codecs/Kconfig                      |    8 +
 sound/soc/codecs/Makefile                     |    4 +
 sound/soc/codecs/lpass-va-macro.c             | 1503 ++++++++++
 sound/soc/codecs/lpass-wsa-macro.c            | 2464 +++++++++++++++++
 sound/soc/codecs/lpass-wsa-macro.h            |   17 +
 7 files changed, 4132 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-va-macro.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,lpass-wsa-macro.yaml
 create mode 100644 sound/soc/codecs/lpass-va-macro.c
 create mode 100644 sound/soc/codecs/lpass-wsa-macro.c
 create mode 100644 sound/soc/codecs/lpass-wsa-macro.h

Comments

Pierre-Louis Bossart Nov. 5, 2020, 4:20 p.m. UTC | #1 
On 11/5/20 5:34 AM, Srinivas Kandagatla wrote:
> This patchset adds support for two Codec Macro blocks( WSA and VA) available in

> Qualcomm LPASS (Low Power Audio SubSystem).

> 

> There are WSA, VA, TX and RX Macros on LPASS IP, each of the Macro block

> has specific connectivity like WSA Macros are intended to connect

> to WSA Smart speaker codecs via SoundWire. VA Macro is intended for DMICs,

> and TX/RX for Analog codecs via SoundWire like other WCD Codecs to provide

> headphone/ear/lineout etc ..

> 

> Most of the work is derived from downstream Qualcomm kernels.

> Credits to various Qualcomm authors from Patrick Lai's team who have

> contributed to this code.

> 

> This patchset has been tested on support to Qualcomm Robotics RB5 Development

> Kit based on QRB5165 Robotics SoC. This board has 2 WSA881X smart speakers

> with onboard DMIC connected to internal LPASS codec via WSA  and VA macros

> respectively.


For the series,

Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Mark Brown Nov. 19, 2020, 5:09 p.m. UTC | #2 
On Thu, 5 Nov 2020 11:34:52 +0000, Srinivas Kandagatla wrote:
> This patchset adds support for two Codec Macro blocks( WSA and VA) available in

> Qualcomm LPASS (Low Power Audio SubSystem).

> 

> There are WSA, VA, TX and RX Macros on LPASS IP, each of the Macro block

> has specific connectivity like WSA Macros are intended to connect

> to WSA Smart speaker codecs via SoundWire. VA Macro is intended for DMICs,

> and TX/RX for Analog codecs via SoundWire like other WCD Codecs to provide

> headphone/ear/lineout etc ..

> 

> [...]


Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/6] ASoC: qcom: dt-bindings: add bindings for lpass wsa macro codec
      commit: ccbd847f15b0f08f8c6ed3ab5384e5f7055b08e5
[2/6] ASoC: codecs: lpass-wsa-macro: Add support to WSA Macro
      commit: 809bcbcecebff86003e13f07444d21b9d6652a64
[3/6] ASoC: codecs: lpass-wsa-macro: add dapm widgets and route
      commit: 2c4066e5d428d47a28f87407b3d73ebe40c06fd4
[4/6] ASoC: qcom: dt-bindings: add bindings for lpass va macro codec
      commit: 67d99b23c881b1411fc6907bc844d63565b536d6
[5/6] ASoC: codecs: lpass-va-macro: Add support to VA Macro
      commit: 908e6b1df26efc9d2df70c9a7bf4f5eae5c5702f
[6/6] ASoC: codecs: lpass-va-macro: add dapm widgets and routes
      commit: 58aad93015b9dc7cb8966c1dc775ec69f0280b79

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark