mbox series

[v18,0/4] PCI: microchip: Add host driver for Microchip PCIe controller

Message ID 20201203121018.16432-1-daire.mcnamara@microchip.com
Headers show
Series PCI: microchip: Add host driver for Microchip PCIe controller | expand

Message

Daire.McNamara@microchip.com Dec. 3, 2020, 12:10 p.m. UTC
From: Daire McNamara <daire.mcnamara@microchip.com>

This patchset adds support for the Microchip PCIe PolarFire PCIe
controller when configured in host (Root Complex) mode.

Updates since v17:
* Regenerated to apply to v5.10rc1
* Added self as maintainer
* Added clock enables and extra interrupt handling

Updates since v16:
* Patch needs CONFIG_PCI_HOST_COMMON.  Add this to Kconfig stanza

Updates since v15:
* Call platform_set_drvdata earlier in devm_pci_alloc_host_bridge()
* Use host_common_probe() and an init function to set up hw windows
* status is u32 in mc_pcie_isr()
* Removed mask var in mc_mask_intx_irq(), mc_unmask_intx_irq()
* irq var is now signed in mc_platform_init()

Updates since v14:
* Removed cfg_read/cfg_write inline functions
* Updated to irq_data_get_irq_chip_data()
* Updated to use devm_platform_ioremap_resource()
* Replaced of_pci_range parsing to setup windows via bridge pointer.

Updates since v13:
* Refactored to use pci_host_common_probe()

Updates since v12:
* Capitalised commit messages.  Use specific subject line for dt-bindings

Updates since v11:
* Adjusted so yaml file passses make dt_binding_check

Updates since v10:
* Adjusted driver as per Rob Herring's comments, notably:
  - use common PCI_MSI_FLAGS defines
  - reduce storage of unnecessary vars in mc_pcie struct
  - switched to read/write relaxed variants
  - extended lock in msi_domain_alloc routine
  - improved 32bit safety, switched from find_first_bit() to ilog2()
  - removed unnecessary twiddle of eCAM config space

Updates since v9:
* Adjusted commit logs
* make dt_bindings_check passes

Updates since v8:
* Refactored as per Rob Herring's comments:
  - bindings in schema format
  - Adjusted licence to GPLv2.0
  - Refactored access to config space between driver and common eCAM code
  - Adopted pci_host_probe()
  - Miscellanous other improvements

Updates since v7:
* Build for 64bit RISCV architecture only

Updates since v6:
* Refactored to use common eCAM driver
* Updated to CONFIG_PCIE_MICROCHIP_HOST etc
* Formatting improvements
* Removed code for selection between bridge 0 and 1

Updates since v5:
* Fixed Kconfig typo noted by Randy Dunlap
* Updated with comments from Bjorn Helgaas

Updates since v4:
* Fix compile issues.

Updates since v3:
* Update all references to Microsemi to Microchip
* Separate MSI functionality from legacy PCIe interrupt handling functionality

Updates since v2:
* Split out DT bindings and Vendor ID updates into their own patch
  from PCIe driver.
* Updated Change Log

Updates since v1:
* Incorporate feedback from Bjorn Helgaas

Daire McNamara (4):
  PCI: Call platform_set_drvdata earlier in devm_pci_alloc_host_bridge
  dt-bindings: PCI: microchip: Add Microchip PolarFire host binding
  PCI: microchip: Add host driver for Microchip PCIe controller
  Add Daire McNamara as maintainer for the Microchip PCIe driver

 .../bindings/pci/microchip,pcie-host.yaml     |  93 +++
 MAINTAINERS                                   |   7 +
 drivers/pci/controller/Kconfig                |  10 +
 drivers/pci/controller/Makefile               |   1 +
 drivers/pci/controller/pci-host-common.c      |   4 +-
 drivers/pci/controller/pcie-microchip-host.c  | 607 ++++++++++++++++++
 6 files changed, 720 insertions(+), 2 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
 create mode 100644 drivers/pci/controller/pcie-microchip-host.c


base-commit: 3650b228f83adda7e5ee532e2b90429c03f7b9ec

Comments

Lorenzo Pieralisi Dec. 7, 2020, 6:01 p.m. UTC | #1
On Thu, Dec 03, 2020 at 12:10:18PM +0000, daire.mcnamara@microchip.com wrote:
> From: Daire McNamara <daire.mcnamara@microchip.com>


Add a commit log.

Subject should start with "MAINTAINERS:".

Next time you change a file read the git log --oneline history for
it so that we don't have to repeat these comments indefinitely.

> Signed-off-by: Daire McNamara <daire.mcnamara@microchip.com>

> ---

>  MAINTAINERS | 7 +++++++

>  1 file changed, 7 insertions(+)

> 

> diff --git a/MAINTAINERS b/MAINTAINERS

> index e73636b75f29..dc926b36116b 100644

> --- a/MAINTAINERS

> +++ b/MAINTAINERS

> @@ -13628,6 +13628,13 @@ S:	Supported

>  F:	Documentation/devicetree/bindings/pci/mediatek*

>  F:	drivers/pci/controller/*mediatek*

>  

> +PCIE DRIVER FOR MICROCHIP

> +M:	Daire McNamara <daire.mcnamara@microchip.com>

> +L:	linux-pci@vger.kernel.org

> +S:	Supported

> +F:	Documentation/devicetree/bindigs/pci/microchip*


s/bindigs/bindings

> +F:	drivers/pci/controller/*microchip*

> +

>  PCIE DRIVER FOR QUALCOMM MSM

>  M:	Stanimir Varbanov <svarbanov@mm-sol.com>

>  L:	linux-pci@vger.kernel.org

> -- 

> 2.25.1

>